This is an archive of the discontinued LLVM Phabricator instance.

[clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

Authored by Ericson2314 on Jan 15 2022, 10:15 PM.



I am breaking apart D99484 so the cause of build failures is easier to

Diff Detail

Event Timeline

Ericson2314 created this revision.Jan 15 2022, 10:15 PM
Ericson2314 requested review of this revision.Jan 15 2022, 10:15 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 15 2022, 10:15 PM
  1. Updating D117419: [clang][cmake] Use GNUInstallDirs to support custom installation dirs #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

Add missing import

beanz added inline comments.Jan 18 2022, 4:30 PM

If GNUInstallDirs is included before the project call enables languages it results in a CMake warning being logged.

Ericson2314 added inline comments.Jan 19 2022, 9:28 AM

See D117639 where we are discussing this problem and what to do about it.

Avoid warning

Ericson2314 marked an inline comment as done.Jan 19 2022, 10:02 AM

Remove the LLVM part, which is now D101070, and furthermore known to cause issues.

I will land this next as part of my great D99484 bisect. Now that I have in fact found the issue, I am more confident this part, which is analogous to all the parts that have gone in fine, is harmless.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 21 2022, 3:58 PM
This revision was automatically updated to reflect the committed changes.