This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add patterns for vector widening integer multiply-add instructions
ClosedPublic

Authored by eopXD on Jan 15 2022, 12:12 PM.

Diff Detail

Event Timeline

eopXD created this revision.Jan 15 2022, 12:12 PM
eopXD requested review of this revision.Jan 15 2022, 12:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 15 2022, 12:12 PM
craig.topper added inline comments.Jan 16 2022, 12:54 AM
llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td
580

Indent this at least one more space so that its more clear that its nested under the add.

583

Indent this one more space.

eopXD updated this revision to Diff 400355.Jan 16 2022, 12:59 AM
eopXD marked 2 inline comments as done.

Address comments: update indention.

This revision is now accepted and ready to land.Jan 16 2022, 11:45 AM
jacquesguan added inline comments.Jan 16 2022, 6:32 PM
llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td
576

I think if move these class definations to upper section near to other class definations and leave pattern def here, maybe more clear.

eopXD updated this revision to Diff 400415.Jan 16 2022, 6:36 PM

Address comment: Move class definitions to upper section.

eopXD marked an inline comment as done.Jan 16 2022, 6:36 PM
This revision was landed with ongoing or failed builds.Jan 16 2022, 6:37 PM
This revision was automatically updated to reflect the committed changes.