The current state of the top level Analysis/ directory is that it contains two libraries;
a generic Analysis library (free from dialect dependencies), and a LoopAnalysis library
that contains various analysis utilities that originated from Affine loop transformations.
This commit moves the LoopAnalysis to the more appropriate home of Dialect/Affine/Analysis/,
given the use and intention of the majority of the code within it. After the move, if there
are generic utilities that would fit better in the top-level Analysis/ directory, we can move
them.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
This looks good and was long overdue. getMemRefSizeInBytes and matchReduction appear to be the only two things from Utils.h and LoopAnalysis.h that should stay in MLIRAnalysis. It'll be good to avoid two moves and keep these functions there?
Comment Actions
I moved matchReduction back to Analysis. getMemRefSizeInBytes looks very similar to ShapedType::getSizeInBits, it'd probably be best to converge there and just remove getMemRefSizeInBytes altogether (but that would be better served with a different patch).