This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Fix not adding return address use to tail calls
AbandonedPublic

Authored by arsenm on Jan 11 2022, 4:20 PM.

Diff Detail

Event Timeline

arsenm created this revision.Jan 11 2022, 4:20 PM
arsenm requested review of this revision.Jan 11 2022, 4:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2022, 4:20 PM
Herald added a subscriber: wdng. · View Herald Transcript

This looks like it was fixed by D114652, but that got reverted?

(The pre-merge checks report a failure for CodeGen/AMDGPU/indirect-call.ll)

This looks like it was fixed by D114652, but that got reverted?

Yes, that got reverted as there were some failures in OpenMP. I am working on a revised patch which I am hoping to post in a couple of days.

If it is not urgent, may be this patch can wait @arsenm ?

arsenm abandoned this revision.Nov 18 2022, 4:17 PM

Returns aren't supposed to explicitly have the return address register use anymore

Herald added a project: Restricted Project. · View Herald TranscriptNov 18 2022, 4:17 PM
Herald added a subscriber: kosarev. · View Herald Transcript