This is an archive of the discontinued LLVM Phabricator instance.

Update LLVM CMakeFiles to include BOLT
ClosedPublic

Authored by Amir on Jan 11 2022, 3:53 PM.

Details

Summary

Add BOLT to the project list enabling its build.

Diff Detail

Event Timeline

Amir created this revision.Jan 11 2022, 3:53 PM
Amir requested review of this revision.Jan 11 2022, 3:53 PM
Herald added a project: Restricted Project. · View Herald Transcript
Amir edited the summary of this revision. (Show Details)Jan 11 2022, 3:55 PM
Amir added a reviewer: mehdi_amini.
Amir added a subscriber: maksfb.

LGTM.

This is to land after Bolt merge gets pushed right?

Amir added a comment.Jan 11 2022, 4:13 PM

LGTM.

This is to land after Bolt merge gets pushed right?

BOLT is now merged! https://github.com/llvm/llvm-project/commit/4c106cfdf7cf7eec861ad3983a3dd9a9e8f3a8ae

Actually, would it make sense to add it to LLVM_EXTRA_PROJECTS instead similar to flang?

Actually, would it make sense to add it to LLVM_EXTRA_PROJECTS instead similar to flang?

Flang is there because it requires C++17 I believe.

(I assume Bolt supports the same environments (compilers / host) as LLVM overall?)

Amir added a comment.Jan 11 2022, 4:22 PM

(I assume Bolt supports the same environments (compilers / host) as LLVM overall?)

Right.

Amir added a comment.Jan 11 2022, 8:20 PM

LGTM.

This is to land after Bolt merge gets pushed right?

Could you accept the diff?

mehdi_amini accepted this revision.Jan 11 2022, 9:06 PM
This revision is now accepted and ready to land.Jan 11 2022, 9:06 PM
This revision was landed with ongoing or failed builds.Jan 11 2022, 9:19 PM
This revision was automatically updated to reflect the committed changes.