This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Rename CPY to DUP. NFC
ClosedPublic

Authored by dmgreen on Jan 5 2022, 5:14 AM.

Details

Summary

These instructions have nothing to do with the new MOP CPY instructions, and are better named DUP to avoid confusion.

Diff Detail

Event Timeline

dmgreen created this revision.Jan 5 2022, 5:14 AM
dmgreen requested review of this revision.Jan 5 2022, 5:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2022, 5:14 AM

This renames the following instructions that were captured by the scheduler regex: CPYi8, CPYi16, CPYi32, CPYi64.

The regex was also (unintentionally?) capturing the following SVE instructoins: CPY_ZPmI_B, CPY_ZPmI_D, CPY_ZPmI_H, CPY_ZPmI_S, CPY_ZPmR_B, CPY_ZPmR_D, CPY_ZPmR_H, CPY_ZPmR_S, CPY_ZPmV_B, CPY_ZPmV_D, CPY_ZPmV_H, CPY_ZPmV_S, CPY_ZPzI_B, CPY_ZPzI_D, CPY_ZPzI_H, CPY_ZPzI_S

Do we need to do anything with them?

This renames the following instructions that were captured by the scheduler regex: CPYi8, CPYi16, CPYi32, CPYi64.

The regex was also (unintentionally?) capturing the following SVE instructoins: CPY_ZPmI_B, CPY_ZPmI_D, CPY_ZPmI_H, CPY_ZPmI_S, CPY_ZPmR_B, CPY_ZPmR_D, CPY_ZPmR_H, CPY_ZPmR_S, CPY_ZPmV_B, CPY_ZPmV_D, CPY_ZPmV_H, CPY_ZPmV_S, CPY_ZPzI_B, CPY_ZPzI_D, CPY_ZPzI_H, CPY_ZPzI_S

Do we need to do anything with them?

I though it was fine - the only cpu that has scheduling info and SVE instructions at the moment is the A64FX. That schedule has other lines for the CPY instructions, but looking again it looks like they are actually commented out.

I've uncommented them so they are the same as before.

dmgreen updated this revision to Diff 397594.Jan 5 2022, 8:37 AM
This revision is now accepted and ready to land.Jan 5 2022, 10:03 AM
This revision was landed with ongoing or failed builds.Jan 5 2022, 12:02 PM
This revision was automatically updated to reflect the committed changes.