Page MenuHomePhabricator
Differential D116573

[jitlink] add R_RISCV_BRANCH to jitlink
ClosedPublic
Actions

Authored by fourdim on Jan 3 2022, 8:15 PM.

Details

Reviewers
lhames
jrtc27
luismarques
Commits
rG0c6f76262277: [jitlink] add R_RISCV_BRANCH to jitlink
Summary

This patch supported the R_RISCV_BRANCH relocation.

Diff Detail

Event Timeline

fourdim created this revision.Jan 3 2022, 8:15 PM
Herald added subscribers: VincentWu, luke957, achieveartificialintelligence and 25 others. · View Herald TranscriptJan 3 2022, 8:15 PM
fourdim requested review of this revision.Jan 3 2022, 8:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2022, 8:15 PM
Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B141423: Diff 397190.Jan 3 2022, 9:32 PM
fourdim updated this revision to Diff 397787.Jan 5 2022, 10:18 PM

Add prefix for hexadecimal numeric.

Harbormaster completed remote builds in B141830: Diff 397787.Jan 5 2022, 10:18 PM
fourdim updated this revision to Diff 397788.Jan 5 2022, 10:37 PM

Include the recent commits.

Harbormaster completed remote builds in B141831: Diff 397788.Jan 5 2022, 10:38 PM
fourdim updated this revision to Diff 397789.Jan 5 2022, 10:49 PM

Include the recent commits.

Harbormaster completed remote builds in B141832: Diff 397789.Jan 5 2022, 10:56 PM
fourdim updated this revision to Diff 397810.Jan 6 2022, 12:52 AM

Fix the behavior after extractBits function's update.

Harbormaster completed remote builds in B141847: Diff 397810.Jan 6 2022, 1:39 AM
StephenFan added a subscriber: StephenFan.Jan 6 2022, 2:36 AM
StephenFan added inline comments.
llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp
167

More concise.

fourdim updated this revision to Diff 397833.Jan 6 2022, 3:02 AM

Address the comments.

Harbormaster completed remote builds in B141863: Diff 397833.Jan 6 2022, 4:03 AM
lhames accepted this revision.Jan 13 2022, 6:27 PM

LGTM! Thanks very much @fourdim!

This revision is now accepted and ready to land.Jan 13 2022, 6:27 PM
fourdim updated this revision to Diff 399889.Jan 13 2022, 10:06 PM
fourdim marked an inline comment as done.

Include the recent commits.

Harbormaster completed remote builds in B143314: Diff 399889.Jan 13 2022, 11:05 PM
Closed by commit rG0c6f76262277: [jitlink] add R_RISCV_BRANCH to jitlink (authored by fourdim). · Explain WhyJan 14 2022, 11:37 AM
This revision was automatically updated to reflect the committed changes.
fourdim added a commit: rG0c6f76262277: [jitlink] add R_RISCV_BRANCH to jitlink.
StephenFan mentioned this in D118151: [JITLink] Fix the incorrect relocation behavior for R_RISCV_BRANCH and extractBits function.Jan 25 2022, 8:09 AM
StephenFan mentioned this in rG9920943ea201: [JITLink] Fix the incorrect relocation behavior for R_RISCV_BRANCH.Feb 6 2022, 10:39 PM

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
ExecutionEngine/
JITLink/
7 lines
lib/
ExecutionEngine/
JITLink/
28 lines
2 lines
test/
ExecutionEngine/
JITLink/
RISCV/
37 lines

Diff 400094

View Options

llvm/include/llvm/ExecutionEngine/JITLink/riscv.h

Loading...
View Options

llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp

Loading...
View Options

llvm/lib/ExecutionEngine/JITLink/riscv.cpp

Loading...
View Options

llvm/test/ExecutionEngine/JITLink/RISCV/ELF_branch.s

Loading...