Page MenuHomePhabricator

[OpenMP] Add nec and nvidia as compiler vendors for OpenMP
ClosedPublic

Authored by saiislam on Jan 3 2022, 8:59 AM.

Diff Detail

Event Timeline

saiislam created this revision.Jan 3 2022, 8:59 AM
saiislam requested review of this revision.Jan 3 2022, 8:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2022, 8:59 AM
  1. I don't know why "pgi" is present here as a vendor. Should it be renamed as nvidia instead? @Meinersbur @tra
  2. Should "cray" be renamed as "hpe" here? @sandoval
  3. Should this vendor list be reordered as per Spec 5.1 [https://www.openmp.org/wp-content/uploads/OpenMP-API-Additional-Definitions-2-0.pdf] ?
jdoerfert accepted this revision.Jan 3 2022, 9:13 AM
  1. I don't know why "pgi" is present here as a vendor. Should it be renamed as nvidia instead? @Meinersbur @tra

It was in the spec list and I would not remove it now.

  1. Should "cray" be renamed as "hpe" here? @sandoval

No, both are listed in the spec.

  1. Should this vendor list be reordered as per Spec 5.1 [https://www.openmp.org/wp-content/uploads/OpenMP-API-Additional-Definitions-2-0.pdf] ?

It was ordered as per that spec, which is just alphabetical. Can you add nec as well and keep the others please.

LG, see above.

This revision is now accepted and ready to land.Jan 3 2022, 9:13 AM
saiislam updated this revision to Diff 397108.Jan 3 2022, 11:02 AM
  1. Added nec as compiler vendor.
  2. Fixed clang test cases.
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2022, 11:02 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
saiislam retitled this revision from [OpenMP] Add nvidia as a compiler vendor for OpenMP to [OpenMP] Add nec and nvidia as compiler vendors for OpenMP.Jan 3 2022, 11:03 AM
saiislam edited the summary of this revision. (Show Details)
  1. I don't know why "pgi" is present here as a vendor. Should it be renamed as nvidia instead? @Meinersbur @tra

It was in the spec list and I would not remove it now.

Specs 5.0 and 5.1 linked above doesn't contain PGI as a vendor. But, we can leave it as is.

  1. Should "cray" be renamed as "hpe" here? @sandoval

No, both are listed in the spec.

Ok.

  1. Should this vendor list be reordered as per Spec 5.1 [https://www.openmp.org/wp-content/uploads/OpenMP-API-Additional-Definitions-2-0.pdf] ?

It was ordered as per that spec, which is just alphabetical. Can you add nec as well and keep the others please.

Spec 5.1 has moved "unknown" from last position to the first. Some reordering also due to "hpe or cray" thing as well.

LG, see above.

Done.

This revision was landed with ongoing or failed builds.Jan 4 2022, 4:31 AM
This revision was automatically updated to reflect the committed changes.