Diff Detail
| Time | Test | |
|---|---|---|
| 60,040 ms | x64 debian > libFuzzer.libFuzzer::fuzzer-leak.test Script:
--
: 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/LeakTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/fuzzer-leak.test.tmp-LeakTest
| |
| 60,280 ms | x64 debian > libFuzzer.libFuzzer::large.test Script:
--
: 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/LargeTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/large.test.tmp-LargeTest
| |
| 60,030 ms | x64 debian > libFuzzer.libFuzzer::minimize_crash.test Script:
--
: 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/NullDerefTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/minimize_crash.test.tmp-NullDerefTest
| |
| 60,050 ms | x64 debian > libFuzzer.libFuzzer::out-of-process-fuzz.test Script:
--
: 'RUN: at line 2'; rm -rf /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/out-of-process-fuzz.test.tmp && mkdir /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/out-of-process-fuzz.test.tmp
| |
| 60,020 ms | x64 debian > libFuzzer.libFuzzer::value-profile-load.test Script:
--
: 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/LoadTest.cpp -fsanitize-coverage=trace-gep -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/value-profile-load.test.tmp-LoadTest
| |
| View Full Test Results (7 Failed) |
Event Timeline
| llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp | ||
|---|---|---|
| 3415 | Is this really necessary given that we're generally moving away from using G_EXTRACT at all? | |
- Removed G_EXTRACT checks
- Refactored parts of code dealing with setting OP_SEL_0 and OP_SEL_1 bits.
| llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp | ||
|---|---|---|
| 3410 | MI cannot be null | |
| 3496 | Don't need = 0 | |
| 3503 | MI cannot be null | |
| 3511 | Ditto | |
| 3514 | Move comment into else if and fix weird line break | |
| 3528–3535 | This matching is a bit heavy. Seems like we're missing some combines? This at least could use some comments for the pattern being matched | |
| 3545–3546 | Why would this pattern appear? | |
| llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp | ||
|---|---|---|
| 3528–3535 | The Or+Shl+And come from RegBankSelect when it breaks down G_BUILD_VECTOR(_TRUNC) instructions that form <2 x 16> operands. There are other cases where such combine could help but it's a separate issue. | |
| 3545–3546 | Added comment to clarify. Register is s32 but fneg that we want to match is for s16. | |
Seems reasonable overall, but I am a bit worried about testing all the possible corner cases.
| llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp | ||
|---|---|---|
| 3521 | I don't understand how this can be safe, when you never even look at MI->getOperand(2). Did you mean to test the mask elements for equality, e.g. ShuffleMask[0] == 1 instead of ShuffleMask[0] != 0? | |
| 3539 | This is NegLo ^= ... | |
| 3542 | Are there tests for this case? If HiSrc is undef then I am a bit surprised that we would ever match m_GShl(m_Reg(HiSrc), m_SpecificICst(16)) above. Also, do we need an equivalent case for when LoSrc is undef? | |
| 3554 | NegHi ^= ... | |
- Fix handling of G_SHUFFLE_VECTOR
- Handled case where low part of <2 x 16> could also be undef.
- Added tests for new cases
| llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp | ||
|---|---|---|
| 3521 | I mistakenly thought that ShuffleMask.size() == 2 would be enough of a restriction. That was a bug. Also, a lot more cases are covered now. | |
| 3542 | Cases where hi part is undef are common when operations on <N x 16> vectors with odd number of elements are broken down into multiple packed instructions. Arguments for last packed instruction will be undef for high part. Added new test insert_with_undef which has case with both lo and hi as undef. As for matching above, | |
Oops, this was at least mostly re-implemented. Is there anything here main doesn't have already?