This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Remove lz and nomip combine from codegen
ClosedPublic

Authored by sebastian-ne on Dec 21 2021, 9:16 AM.

Details

Summary

These combines have been moved into the IR combiner in D116042.

Diff Detail

Event Timeline

sebastian-ne created this revision.Dec 21 2021, 9:16 AM
sebastian-ne requested review of this revision.Dec 21 2021, 9:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 21 2021, 9:16 AM

Friendly ping for review

foad added a comment.Jan 14 2022, 3:29 AM

It looks like for some tests you manually optimized the IR, but for other tests you updated the expected ISA. Any reason for the difference?

It looks like for some tests you manually optimized the IR, but for other tests you updated the expected ISA. Any reason for the difference?

I don’t remember if I had a reason for that.
Just tried regenerating the tests without changing the IR it seems to work as well (just ends up with more _mip instructions).

arsenm accepted this revision.Jan 17 2022, 4:43 PM
This revision is now accepted and ready to land.Jan 17 2022, 4:43 PM
This revision was landed with ongoing or failed builds.Jan 21 2022, 3:09 AM
This revision was automatically updated to reflect the committed changes.
llvm/test/CodeGen/AMDGPU/image_ls_mipmap_zero.ll