Page MenuHomePhabricator
Differential D115976

[clang] Fix a crash case when reporting an uninitialized field.
Needs ReviewPublic
Actions

Authored by hliao on Dec 17 2021, 3:06 PM.

Details

Reviewers
rsmith
Summary
  • As the initializer list's getSyntacticForm() may return NULL, need to consider the current semantic initalizer list itself as the synatic form. Wrap that together into a new getSourceRange method.

Diff Detail

Unit TestsFailed
View All

TimeTest
50 msx64 debian > LLVM.Bindings/Go::go.test
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llvm-go go=/usr/bin/go test llvm.org/llvm/bindings/go/llvm

Event Timeline

hliao requested review of this revision.Dec 17 2021, 3:06 PM
hliao created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2021, 3:06 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B139922: Diff 395228.Dec 17 2021, 3:42 PM
hliao updated this revision to Diff 395248.Dec 17 2021, 6:11 PM

Revise the formatting.

Harbormaster completed remote builds in B139940: Diff 395248.Dec 17 2021, 7:04 PM
hliao updated this revision to Diff 396225.Dec 26 2021, 9:13 AM

Rebase

Harbormaster completed remote builds in B140660: Diff 396225.Dec 26 2021, 9:51 AM

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
AST/
3 lines
lib/
Sema/
3 lines
test/
SemaCXX/
17 lines

Diff 396225

View Options

clang/include/clang/AST/Expr.h

Loading...
View Options

clang/lib/Sema/SemaInit.cpp

Loading...
View Options

clang/test/SemaCXX/uninitialized.cpp

Loading...