This is an archive of the discontinued LLVM Phabricator instance.

Differential D115827

[clang]: add missing Interpreter -> ClangDriverOptions dependency
ClosedPublic

Authored by • t184256 on Dec 15 2021, 1:10 PM.

Details

Reviewers
llvm-commits
thakis
v.g.vassilev
Commits
rGb5eaf500f244: [clang] Add missing Interpreter -> ClangDriverOptions dependency
Summary

Without this, it is possible that
Interpreter.cpp is being built before
clang/Driver/Options.inc is generated.

Observed only infrequently,
serial builds and ext4 manifest the problem
much more often than parallel builds and btrfs.

https://reviews.llvm.org/rG06487b010d48c36c7714ee083ed38dff65711812
is a very similar case.

Diff Detail

Event Timeline

• t184256 created this revision.Dec 15 2021, 1:10 PM
Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. · View Herald TranscriptDec 15 2021, 1:10 PM
• t184256 requested review of this revision.Dec 15 2021, 1:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2021, 1:10 PM
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. · View Herald Transcript
v.g.vassilev accepted this revision.Dec 15 2021, 1:29 PM

Lgtm!

This revision is now accepted and ready to land.Dec 15 2021, 1:29 PM
Harbormaster completed remote builds in B139505: Diff 394646.Dec 15 2021, 1:57 PM
v.g.vassilev added a comment.Jun 24 2022, 4:16 AM

@t184256, do we still need this? Should I commit it in case you don't have commit access?

Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2022, 4:16 AM
This revision was landed with ongoing or failed builds.Jun 26 2022, 6:51 AM
Closed by commit rGb5eaf500f244: [clang] Add missing Interpreter -> ClangDriverOptions dependency (authored by v.g.vassilev). · Explain Why
This revision was automatically updated to reflect the committed changes.
v.g.vassilev added a commit: rGb5eaf500f244: [clang] Add missing Interpreter -> ClangDriverOptions dependency.

Revision Contents

PathSize
clang/
lib/
Interpreter/
1 line

Diff 440062

clang/lib/Interpreter/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
core core
native native
Option Option
OrcJit OrcJit
Support Support
Target Target
) )
add_clang_library(clangInterpreter add_clang_library(clangInterpreter
IncrementalExecutor.cpp IncrementalExecutor.cpp
IncrementalParser.cpp IncrementalParser.cpp
Interpreter.cpp Interpreter.cpp
DEPENDS DEPENDS
intrinsics_gen intrinsics_gen
ClangDriverOptions
LINK_LIBS LINK_LIBS
clangAST clangAST
clangAnalysis clangAnalysis
clangBasic clangBasic
clangDriver clangDriver
clangEdit clangEdit
clangFrontend clangFrontend
clangLex clangLex
clangParse clangParse
clangSema clangSema
clangSerialization clangSerialization
clangCodeGen clangCodeGen
clangFrontendTool clangFrontendTool
) )