It's legal per the Vulkan / SPIR-V spec; still it's better to avoid
such duplication to have cleaner blob and reduce the binary size.
Depends On D115531
Paths
| Differential D115532
[mlir][spirv] Avoid duplicated Block decoration during serialization ClosedPublic Authored by antiagainst on Dec 10 2021, 8:52 AM.
Details Summary It's legal per the Vulkan / SPIR-V spec; still it's better to avoid Depends On D115531
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Dec 10 2021, 9:03 AM antiagainst added a child revision: D115534: [mlir][spirv] Change default subgroup size.Dec 10 2021, 9:14 AM Closed by commit rG222d7fc7f819: [mlir][spirv] Avoid duplicated Block decoration during serialization (authored by antiagainst). · Explain WhyDec 10 2021, 4:21 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 393512 mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
mlir/unittests/Dialect/SPIRV/SerializationTest.cpp
|