Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D115583

[mlir][spirv] Use ScopedPrinter in deserialization debugging
ClosedPublic
Actions

Authored by antiagainst on Dec 11 2021, 11:36 AM.

Details

Reviewers
Hardcode84
mravishankar
Commits
rGf56b1d813fc9: [mlir][spirv] Use ScopedPrinter in deserialization debugging
Summary

This gives us better debugging print as it supports indent
levels and other nice features.

Depends On D115582

Diff Detail

Event Timeline

antiagainst created this revision.Dec 11 2021, 11:36 AM
Herald added a reviewer: mravishankar. · View Herald TranscriptDec 11 2021, 11:36 AM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 22 others. · View Herald Transcript
antiagainst requested review of this revision.Dec 11 2021, 11:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 11 2021, 11:36 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B138810: Diff 393686.Dec 11 2021, 11:37 AM
antiagainst updated this revision to Diff 393688.Dec 11 2021, 12:01 PM

Update to use reference

Harbormaster completed remote builds in B138811: Diff 393688.Dec 11 2021, 12:02 PM
Hardcode84 accepted this revision.Dec 11 2021, 2:39 PM
This revision is now accepted and ready to land.Dec 11 2021, 2:39 PM
This revision was landed with ongoing or failed builds.Dec 13 2021, 7:52 AM
Closed by commit rGf56b1d813fc9: [mlir][spirv] Use ScopedPrinter in deserialization debugging (authored by antiagainst). · Explain Why
This revision was automatically updated to reflect the committed changes.
antiagainst added a commit: rGf56b1d813fc9: [mlir][spirv] Use ScopedPrinter in deserialization debugging.

Revision Contents
Changeset List

PathSize
mlir/
lib/
Target/
SPIRV/
Deserialization/
4 lines
13 lines
230 lines

Diff 393901

View Options

mlir/lib/Target/SPIRV/Deserialization/DeserializeOps.cpp

Loading...
View Options

mlir/lib/Target/SPIRV/Deserialization/Deserializer.h

Loading...
View Options

mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp

Loading...