Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[mlir][spirv] Avoid duplicated Block decoration during serialization
ClosedPublic
Actions

Authored by antiagainst on Dec 10 2021, 8:52 AM.

Details

Reviewers

scotttodd
mravishankar

Commits

rG222d7fc7f819: [mlir][spirv] Avoid duplicated Block decoration during serialization

Summary

It's legal per the Vulkan / SPIR-V spec; still it's better to avoid
such duplication to have cleaner blob and reduce the binary size.

Depends On D115531

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

antiagainst created this revision.Dec 10 2021, 8:52 AM

Herald added a reviewer: mravishankar. · View Herald TranscriptDec 10 2021, 8:52 AM

Herald added subscribers: sdasgup3, wenzhicui, wrengr and 22 others. · View Herald Transcript

antiagainst requested review of this revision.Dec 10 2021, 8:52 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2021, 8:52 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

scotttodd accepted this revision.Dec 10 2021, 9:03 AM

This revision is now accepted and ready to land.Dec 10 2021, 9:03 AM

Harbormaster completed remote builds in B138685: Diff 393512.Dec 10 2021, 9:14 AM

antiagainst added a child revision: D115534: [mlir][spirv] Change default subgroup size.Dec 10 2021, 9:14 AM

Closed by commit rG222d7fc7f819: [mlir][spirv] Avoid duplicated Block decoration during serialization (authored by antiagainst). · Explain WhyDec 10 2021, 4:21 PM

This revision was automatically updated to reflect the committed changes.

antiagainst added a commit: rG222d7fc7f819: [mlir][spirv] Avoid duplicated Block decoration during serialization.

Revision Contents
Changeset List

Path

Size

mlir/

lib/

Target/

SPIRV/

Serialization/

SerializeOps.cpp

12 lines

Serializer.cpp

12 lines

unittests/

Dialect/

SPIRV/

SerializationTest.cpp

56 lines

Diff 393625

View Options

mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp

View Options

mlir/lib/Target/SPIRV/Serialization/Serializer.cpp

View Options

mlir/unittests/Dialect/SPIRV/SerializationTest.cpp

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[mlir][spirv] Avoid duplicated Block decoration during serializationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 393625

mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp

mlir/lib/Target/SPIRV/Serialization/Serializer.cpp

mlir/unittests/Dialect/SPIRV/SerializationTest.cpp

[mlir][spirv] Avoid duplicated Block decoration during serialization
ClosedPublic
Actions

Revision Contents
Changeset List