[mlir][spirv] Add serialization control to emit symbol name
ClosedPublic
Actions

Authored by antiagainst on Dec 10 2021, 8:52 AM.

Details

Reviewers

scotttodd
mravishankar

Commits

rGb289266cb239: [mlir][spirv] Add serialization control to emit symbol name

Summary

In SPIR-V, symbol names are encoded as OpName instructions.
They are not semantic impacting and can be omitted, which can
reduce the binary size.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

antiagainst created this revision.Dec 10 2021, 8:52 AM

Herald added a reviewer: mravishankar. · View Herald TranscriptDec 10 2021, 8:52 AM

Herald added subscribers: sdasgup3, wenzhicui, wrengr and 22 others. · View Herald Transcript

antiagainst requested review of this revision.Dec 10 2021, 8:52 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2021, 8:52 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

antiagainst added a child revision: D115532: [mlir][spirv] Avoid duplicated Block decoration during serialization.Dec 10 2021, 8:52 AM

scotttodd accepted this revision.Dec 10 2021, 9:00 AM

This revision is now accepted and ready to land.Dec 10 2021, 9:00 AM

Harbormaster completed remote builds in B138684: Diff 393511.Dec 10 2021, 9:07 AM

Closed by commit rGb289266cb239: [mlir][spirv] Add serialization control to emit symbol name (authored by antiagainst). · Explain WhyDec 10 2021, 4:21 PM

This revision was automatically updated to reflect the committed changes.

antiagainst added a commit: rGb289266cb239: [mlir][spirv] Add serialization control to emit symbol name.

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Target/

SPIRV/

SPIRVBinaryUtils.h

14 lines

Serialization.h

9 lines

lib/

Target/

SPIRV/

Deserialization/

DeserializeOps.cpp

1 line

Deserializer.h

13 lines

Serialization/

Serialization.cpp

4 lines

Serializer.h

8 lines

Serializer.cpp

15 lines

TranslateRegistration.cpp

9 lines

unittests/

Dialect/

SPIRV/

SerializationTest.cpp

63 lines

Diff 393624

View Options

mlir/include/mlir/Target/SPIRV/SPIRVBinaryUtils.h

View Options

mlir/include/mlir/Target/SPIRV/Serialization.h

View Options

mlir/lib/Target/SPIRV/Deserialization/DeserializeOps.cpp

View Options

mlir/lib/Target/SPIRV/Deserialization/Deserializer.h

View Options

mlir/lib/Target/SPIRV/Serialization/Serialization.cpp

View Options

mlir/lib/Target/SPIRV/Serialization/Serializer.h

View Options

mlir/lib/Target/SPIRV/Serialization/Serializer.cpp

View Options

mlir/lib/Target/SPIRV/TranslateRegistration.cpp

View Options

mlir/unittests/Dialect/SPIRV/SerializationTest.cpp

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[mlir][spirv] Add serialization control to emit symbol nameClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 393624

mlir/include/mlir/Target/SPIRV/SPIRVBinaryUtils.h

mlir/include/mlir/Target/SPIRV/Serialization.h

mlir/lib/Target/SPIRV/Deserialization/DeserializeOps.cpp

mlir/lib/Target/SPIRV/Deserialization/Deserializer.h

mlir/lib/Target/SPIRV/Serialization/Serialization.cpp

mlir/lib/Target/SPIRV/Serialization/Serializer.h

mlir/lib/Target/SPIRV/Serialization/Serializer.cpp

mlir/lib/Target/SPIRV/TranslateRegistration.cpp

mlir/unittests/Dialect/SPIRV/SerializationTest.cpp

[mlir][spirv] Add serialization control to emit symbol name
ClosedPublic
Actions

Revision Contents
Changeset List