This is an archive of the discontinued LLVM Phabricator instance.

Differential D114863

[BuildLibCalls] Add additional attrs to memcpy_chk.
ClosedPublic

Authored by fhahn on Dec 1 2021, 3:59 AM.

Details

Reviewers
ab
xbolva00
efriedma
jdoerfert
Commits
rG0496edad4993: [BuildLibCalls] Add additional attrs to memcpy_chk.
Summary

memcpy_chk can be treated like memcpy, with the exception that it
may not return (if it aborts the program).

See D114793 for a similar patch for memset_chk.

Diff Detail

Event Timeline

fhahn created this revision.Dec 1 2021, 3:59 AM
Herald added a subscriber: hiraditya. · View Herald TranscriptDec 1 2021, 3:59 AM
fhahn requested review of this revision.Dec 1 2021, 3:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2021, 3:59 AM
fhahn mentioned this in D114793: [BuildLibCalls] Add argmemonly, writeonly, nounwind to memset_chk..Dec 1 2021, 4:00 AM
xbolva00 accepted this revision.Dec 1 2021, 4:31 AM

LG

This revision is now accepted and ready to land.Dec 1 2021, 4:31 AM
Harbormaster completed remote builds in B136886: Diff 390972.Dec 1 2021, 4:32 AM
This revision was landed with ongoing or failed builds.Dec 2 2021, 1:50 AM
Closed by commit rG0496edad4993: [BuildLibCalls] Add additional attrs to memcpy_chk. (authored by fhahn). · Explain Why
This revision was automatically updated to reflect the committed changes.
fhahn added a commit: rG0496edad4993: [BuildLibCalls] Add additional attrs to memcpy_chk..

Revision Contents

PathSize
llvm/
lib/
Transforms/
Utils/
7 lines
test/
Transforms/
InferFunctionAttrs/
4 lines

Diff 391257

llvm/lib/Transforms/Utils/BuildLibCalls.cpp

Show First 20 Lines • Show All 446 Lines • ▼ Show 20 Lines case LibFunc_memmove:
Changed |= setWillReturn(F); Changed |= setWillReturn(F);
Changed |= setReturnedArg(F, 0); Changed |= setReturnedArg(F, 0);
Changed |= setOnlyWritesMemory(F, 0); Changed |= setOnlyWritesMemory(F, 0);
Changed |= setDoesNotCapture(F, 1); Changed |= setDoesNotCapture(F, 1);
Changed |= setOnlyReadsMemory(F, 1); Changed |= setOnlyReadsMemory(F, 1);
return Changed; return Changed;
case LibFunc_mempcpy: case LibFunc_mempcpy:
case LibFunc_memccpy: case LibFunc_memccpy:
Changed |= setWillReturn(F);
LLVM_FALLTHROUGH;
case LibFunc_memcpy_chk:
Changed |= setDoesNotThrow(F); Changed |= setDoesNotThrow(F);
Changed |= setOnlyAccessesArgMemory(F); Changed |= setOnlyAccessesArgMemory(F);
Changed |= setWillReturn(F);
Changed |= setDoesNotAlias(F, 0); Changed |= setDoesNotAlias(F, 0);
Changed |= setOnlyWritesMemory(F, 0); Changed |= setOnlyWritesMemory(F, 0);
Changed |= setDoesNotAlias(F, 1); Changed |= setDoesNotAlias(F, 1);
Changed |= setDoesNotCapture(F, 1); Changed |= setDoesNotCapture(F, 1);
Changed |= setOnlyReadsMemory(F, 1); Changed |= setOnlyReadsMemory(F, 1);
return Changed; return Changed;
case LibFunc_memcpy_chk:
Changed |= setDoesNotThrow(F);
return Changed;
case LibFunc_memalign: case LibFunc_memalign:
Changed |= setOnlyAccessesInaccessibleMemory(F); Changed |= setOnlyAccessesInaccessibleMemory(F);
Changed |= setRetNoUndef(F); Changed |= setRetNoUndef(F);
Changed |= setDoesNotThrow(F); Changed |= setDoesNotThrow(F);
Changed |= setRetDoesNotAlias(F); Changed |= setRetDoesNotAlias(F);
Changed |= setWillReturn(F); Changed |= setWillReturn(F);
return Changed; return Changed;
case LibFunc_mkdir: case LibFunc_mkdir:
▲ Show 20 Lines • Show All 1,206 Lines • Show Last 20 Lines

llvm/test/Transforms/InferFunctionAttrs/annotate.ll

Show First 20 Lines • Show All 625 Lines • ▼ Show 20 Lines
declare i8* @memchr(i8*, i32, i64) declare i8* @memchr(i8*, i32, i64)
; CHECK: declare i32 @memcmp(i8* nocapture, i8* nocapture, i64) [[ARGMEMONLY_NOFREE_NOUNWIND_READONLY]] ; CHECK: declare i32 @memcmp(i8* nocapture, i8* nocapture, i64) [[ARGMEMONLY_NOFREE_NOUNWIND_READONLY]]
declare i32 @memcmp(i8*, i8*, i64) declare i32 @memcmp(i8*, i8*, i64)
; CHECK: declare i8* @memcpy(i8* noalias returned writeonly, i8* noalias nocapture readonly, i64) [[ARGMEMONLY_NOFREE_NOUNWIND_WILLRETURN]] ; CHECK: declare i8* @memcpy(i8* noalias returned writeonly, i8* noalias nocapture readonly, i64) [[ARGMEMONLY_NOFREE_NOUNWIND_WILLRETURN]]
declare i8* @memcpy(i8*, i8*, i64) declare i8* @memcpy(i8*, i8*, i64)
; CHECK: declare i8* @__memcpy_chk(i8*, i8*, i64, i64) [[NOFREE_NOUNWIND]] ; CHECK: declare i8* @__memcpy_chk(i8* noalias writeonly, i8* noalias nocapture readonly, i64, i64) [[ARGMEMONLY_NOFREE_NOUNWIND:#[0-9]+]]
declare i8* @__memcpy_chk(i8*, i8*, i64, i64) declare i8* @__memcpy_chk(i8*, i8*, i64, i64)
; CHECK: declare i8* @mempcpy(i8* noalias writeonly, i8* noalias nocapture readonly, i64) [[ARGMEMONLY_NOFREE_NOUNWIND_WILLRETURN]] ; CHECK: declare i8* @mempcpy(i8* noalias writeonly, i8* noalias nocapture readonly, i64) [[ARGMEMONLY_NOFREE_NOUNWIND_WILLRETURN]]
declare i8* @mempcpy(i8*, i8*, i64) declare i8* @mempcpy(i8*, i8*, i64)
; CHECK: declare i8* @memmove(i8* returned writeonly, i8* nocapture readonly, i64) [[ARGMEMONLY_NOFREE_NOUNWIND_WILLRETURN]] ; CHECK: declare i8* @memmove(i8* returned writeonly, i8* nocapture readonly, i64) [[ARGMEMONLY_NOFREE_NOUNWIND_WILLRETURN]]
declare i8* @memmove(i8*, i8*, i64) declare i8* @memmove(i8*, i8*, i64)
; CHECK: declare i8* @memset(i8* writeonly, i32, i64) [[ARGMEMONLY_NOFREE_NOUNWIND_WILLRETURN:#[0-9]+]] ; CHECK: declare i8* @memset(i8* writeonly, i32, i64) [[ARGMEMONLY_NOFREE_NOUNWIND_WILLRETURN:#[0-9]+]]
declare i8* @memset(i8*, i32, i64) declare i8* @memset(i8*, i32, i64)
; CHECK: declare i8* @__memset_chk(i8* writeonly, i32, i64, i64) [[ARGMEMONLY_NOFREE_NOUNWIND:#[0-9]+]] ; CHECK: declare i8* @__memset_chk(i8* writeonly, i32, i64, i64) [[ARGMEMONLY_NOFREE_NOUNWIND]]
declare i8* @__memset_chk(i8*, i32, i64, i64) declare i8* @__memset_chk(i8*, i32, i64, i64)
; CHECK: declare noundef i32 @mkdir(i8* nocapture noundef readonly, i16 noundef zeroext) [[NOFREE_NOUNWIND]] ; CHECK: declare noundef i32 @mkdir(i8* nocapture noundef readonly, i16 noundef zeroext) [[NOFREE_NOUNWIND]]
declare i32 @mkdir(i8*, i16 zeroext) declare i32 @mkdir(i8*, i16 zeroext)
; CHECK: declare noundef i64 @mktime(%opaque* nocapture noundef) [[NOFREE_NOUNWIND_WILLRETURN]] ; CHECK: declare noundef i64 @mktime(%opaque* nocapture noundef) [[NOFREE_NOUNWIND_WILLRETURN]]
declare i64 @mktime(%opaque*) declare i64 @mktime(%opaque*)
▲ Show 20 Lines • Show All 380 Lines • Show Last 20 Lines