Page MenuHomePhabricator

[AArch64] Use Feature for A53 Erratum 835769 Fix
ClosedPublic

Authored by lenary on Nov 29 2021, 5:50 AM.

Details

Summary

When this pass was originally implemented, the fix pass was enabled
using a llvm command-line flag. This works fine, except in the case of
LTO, where the flag is not passed into the linker plugin in order to
enable the function pass in the LTO backend.

Now LTO exists, the expectation now is to use target features rather
than command-line arguments to control code generation, as this ensures
that different command-line arguments in different files are correctly
represented, and target-features always get to the LTO plugin as they
are encoded into LLVM IR.

The fall-out of this change is that the fix pass has to always be added
to the backend pass pipeline, so now it makes no changes if the function
does not have the right target feature to enable it. This should make a
minimal difference to compile time.

One advantage is it's now much easier to enable when compiling for a
Cortex-A53, as CPUs imply their own individual sets of target-features,
in a more fine-grained way. I haven't done this yet, but it is an
option, if the fix should be enabled in more places.

Existing tests of the user interface are unaffected, the changes are to
reflect that the argument is now turned into a target feature.

Diff Detail

Event Timeline

lenary created this revision.Nov 29 2021, 5:50 AM
lenary requested review of this revision.Nov 29 2021, 5:50 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 29 2021, 5:50 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
tmatheson accepted this revision.Nov 30 2021, 1:51 AM
tmatheson added a subscriber: tmatheson.

Makes sense to me

This revision is now accepted and ready to land.Nov 30 2021, 1:51 AM
This revision was automatically updated to reflect the committed changes.