Page MenuHomePhabricator

[mlir][Vector] Thread 0-d vectors through InsertElementOp.
ClosedPublic

Authored by nicolasvasilache on Mon, Nov 22, 12:57 PM.

Details

Summary

This revision makes concrete use of 0-d vectors to extend the semantics of
InsertElementOp.

Diff Detail

Event Timeline

nicolasvasilache requested review of this revision.Mon, Nov 22, 12:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Nov 22, 12:57 PM
pifon2a accepted this revision.Tue, Nov 23, 1:09 AM
pifon2a added inline comments.
mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir
518

nit: wrap the line

This revision is now accepted and ready to land.Tue, Nov 23, 1:09 AM
dcaballe accepted this revision.Tue, Nov 23, 1:43 AM

LGTM. Just one minor question. Thanks!

mlir/test/Dialect/Vector/ops.mlir
198

Would it be ok to use %b[] with a 1D vector? Could we add a test for that either to invalid or here depending on the answer?

Rebase past windows build error.

Address comments and fix bugs.

This revision was landed with ongoing or failed builds.Tue, Nov 23, 4:56 AM
This revision was automatically updated to reflect the committed changes.