This is an archive of the discontinued LLVM Phabricator instance.

Revert "[amdgpu] Enable selection of `s_cselect_b64`."
Needs ReviewPublic

Authored by david-salinas on Nov 10 2021, 4:04 PM.

Details

Reviewers
kzhuravl
Summary

This reverts commit 640beb38e7710b939b3cfb3f4c54accc694b1d30.
The change being reverted was some codegen clean up, and cause compilation and performance issues. Reverting for now until we can get a better solution.

Change-Id: Ib1b6c277fcbdd55f50b9e6a4ae961c4b9b006e09

Diff Detail

Event Timeline

david-salinas created this revision.Nov 10 2021, 4:04 PM
david-salinas requested review of this revision.Nov 10 2021, 4:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2021, 4:04 PM
Revert "[amdgpu] Enable selection of `s_cselect_b64`."

This reverts commit 640beb38e7710b939b3cfb3f4c54accc694b1d30

Description missing justification

foad added a comment.Nov 16 2021, 1:10 AM

Description missing justification

Agreed. Can you say why or provide a test case or something?

david-salinas edited the summary of this revision. (Show Details)Dec 16 2021, 8:00 AM
llvm/test/CodeGen/AMDGPU/addrspacecast.ll