[LLDB] Remove access check of decl in TypeSystemClang.cpp

[zequanwu]

Summary

As the deleted comment says, we don't care about the access specifier.
I also encountered a crash at here (called from https://github.com/llvm/llvm-project/blob/main/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp#L2141) when fixing a bug on SymbolFileNativePDB.cpp.

[shafik]

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

95

No, we don't care about the return value but we care about the assert which means the AST node is not well formed. In this case IIRC we are verifying that a member has an access specifier that is not set to AS_none.

[teemperor]

I'm pretty sure you're trying to solve the same problem as here: D85993

In short: You're calling CreateFunctionDeclaration to create a function in a record, but you actually want to call AddMethodToCXXRecordType which allows passing and setting an access specifier (which is what the assert here checks). You can fix this in the PDB plugin by looking at the DeclContext and if decl_ctx->isRecord() -> AddMethodToCXXRecordType and otherwise CreateFunctionDeclaration.

[zequanwu]

D113930 is the correct fix for that.

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

 using namespace clang;
 using llvm::StringSwitch;
 
 LLDB_PLUGIN_DEFINE(TypeSystemClang)
 
 namespace {
 static void VerifyDecl(clang::Decl *decl) {
   assert(decl && "VerifyDecl called with nullptr?");
-#ifndef NDEBUG
-  // We don't care about the actual access value here but only want to trigger
-  // that Clang calls its internal Decl::AccessDeclContextSanity check.
-  decl->getAccess();
-#endif
 }
 
 static inline bool
 TypeSystemClangSupportsLanguage(lldb::LanguageType language) {
   return language == eLanguageTypeUnknown || // Clang is the default type system
          lldb_private::Language::LanguageIsC(language) ||
          lldb_private::Language::LanguageIsCPlusPlus(language) ||
          lldb_private::Language::LanguageIsObjC(language) ||