Replace filenames, variable names, check prefixes uses of blacklist with ignore list.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Hi! Thank you for the clean-up :)
I feel there might be a bit of work still left. While renaming filenames and function names should be mostly inconsequential renaming command line options and sanitizer ignorelist content (and by that changing the syntax) most likely need accompanying changes in clang itself.
I noticed you have at least one other similar patch but I don't see the changes I'd expect there - please let me know if I'm just missing something!
Do the tests actually pass with this patch?
clang/test/CodeGen/address-safety-attr.cpp | ||
---|---|---|
9 | Shouldn't we teach ASan about the new syntax of ignorelist as well fun:*IgnorelistedFunction*? | |
10 | Shouldn't the change of the option name to -fsanitize-ignorelist in tests be accompanied with analogous change in driver and/or cc1 options definition? | |
clang/test/CodeGenCXX/cfi-ignorelist.cpp | ||
3 | We should use the verb "to ignorelist smth" (without the space) consistently. |
I will not be part of this language policing.
-10 to any changes that break existing external interface (that is, it is not okay to just rename externally-visible command-line flags, config options, etc.)
Thanks for the quick review. The tests do pass, it looks like there has been a patch that allowed the ignorelist options to be accepted by clang: https://reviews.llvm.org/D101832.
LGTM
clang/test/CodeGen/address-safety-attr.cpp | ||
---|---|---|
9 | Nvm - that's just name of the test function below. |
Shouldn't we teach ASan about the new syntax of ignorelist as well fun:*IgnorelistedFunction*?