The modified tests fail because 64-bit XCOFF object files are not currently supported on AIX. This patch disables these tests on 64-bit AIX for now.
This patch is similar to D111887 except the failures on this patch are on a 64-bit build.
Paths
| Differential D113049
[AIX] Disable tests that fail because of no 64-bit XCOFF object file support ClosedPublic Authored by Jake-Egan on Nov 2 2021, 1:49 PM.
Details
Summary The modified tests fail because 64-bit XCOFF object files are not currently supported on AIX. This patch disables these tests on 64-bit AIX for now. This patch is similar to D111887 except the failures on this patch are on a 64-bit build.
Diff Detail
Event TimelineHerald added subscribers: ormris, lxfind, pengfei and 3 others. · View Herald TranscriptNov 2 2021, 1:49 PM Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 2 2021, 1:49 PM Comment Actions This seems not right. Now we disable too many debug cases for object mode even for 32bit target. Maybe we should test clang (built with --default-target-triple=powerpc64-ibm-aix) after our backend support 64-bit object mode(-filetype=obj) Comment Actions
If 64-bit XCOFF object files will be supported in the future, I think it makes more sense to use XFAIL because these tests will still be run and pass after implementation. Comment Actions
We should remove the UNSUPPORTED when we enable the 64-bit XCOFF object file support . It is a waste of machine time to run them *NOW*, especially considering the number of these failing tests. Comment Actions
Agree, I would prefer we do something similar to https://reviews.llvm.org/rG666accf283311c5110ae4e2e5e4c4b99078eed15#change-NFfZJdfkKBjR to exclude the unsupported files for now. Comment Actions Thanks for the review. I updated the patch to use lit.cfg.py to filter tests that use obj options. For tests that don't use the option or has an individual folder, I changed them to UNSUPPORTED instead of XFAIL.
Jake-Egan added inline comments.
Jake-Egan added inline comments.
Comment Actions Look almost good! Thanks for doing this.
This revision is now accepted and ready to land.Jan 6 2022, 5:21 PM This revision was landed with ongoing or failed builds.Jan 9 2022, 9:26 AM Closed by commit rGfbf52caf58b3: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support (authored by Jake-Egan). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 384521 clang/test/ASTMerge/anonymous-fields/test.cppclang/test/ASTMerge/codegen-body/test.c
clang/test/ASTMerge/injected-class-name-decl/test.cpp
clang/test/ClangScanDeps/modules-full-by-mod-name.cpp
clang/test/ClangScanDeps/modules-pch-common-submodule.c
clang/test/ClangScanDeps/modules-pch-common-via-submodule.c
clang/test/ClangScanDeps/modules-pch.c
clang/test/ClangScanDeps/resource_directory.c
clang/test/CodeGenCXX/crash.cpp
clang/test/CodeGenCXX/ubsan-coroutines.cpp
clang/test/Driver/as-version.s
clang/test/Driver/cc-print-proc-stat.c
clang/test/Driver/compilation_database.c
clang/test/Driver/modules-ts.cpp
clang/test/Driver/report-stat.c
clang/test/Misc/clear-ast-before-backend.c
clang/test/Misc/time-passes.c
clang/test/Modules/DebugInfoSubmodules.c
clang/test/Modules/lsv-debuginfo.cpp
clang/test/Modules/odr_hash-Friend.cpp
clang/test/Modules/path-resolution.modulemap
clang/test/Modules/self-referencing-lambda.cpp
clang/test/PCH/debug-info-pch-container-path.c
clang/test/PCH/debug-info-pch-path.c
clang/test/PCH/pch-hdrstop-warn.cpp
clang/test/PCH/pch-hdrstop.cpp
clang/test/PCH/pch-no-hdrstop.cpp
clang/test/PCH/pch-through4.cpp
clang/test/PCH/pch-through4a.cpp
llvm/test/CodeGen/X86/dbg-distringtype-uint.ll
llvm/test/DebugInfo/Generic/2010-04-06-NestedFnDbgInfo.ll
llvm/test/DebugInfo/Generic/2010-05-10-MultipleCU.ll
llvm/test/DebugInfo/Generic/DICommonBlock.ll
llvm/test/DebugInfo/Generic/PR20038.ll
llvm/test/DebugInfo/Generic/constant-pointers.ll
llvm/test/DebugInfo/Generic/containing-type-extension.ll
llvm/test/DebugInfo/Generic/cross-cu-inlining.ll
llvm/test/DebugInfo/Generic/cross-cu-linkonce-distinct.ll
llvm/test/DebugInfo/Generic/cross-cu-linkonce.ll
llvm/test/DebugInfo/Generic/cu-range-hole.ll
llvm/test/DebugInfo/Generic/cu-ranges.ll
llvm/test/DebugInfo/Generic/dead-argument-order.ll
llvm/test/DebugInfo/Generic/debug-info-enum.ll
llvm/test/DebugInfo/Generic/debug-info-qualifiers.ll
llvm/test/DebugInfo/Generic/debug-label-inline.ll
llvm/test/DebugInfo/Generic/debug-label.ll
llvm/test/DebugInfo/Generic/debug-names-empty-cu.ll
llvm/test/DebugInfo/Generic/def-line.ll
llvm/test/DebugInfo/Generic/discriminated-union.ll
llvm/test/DebugInfo/Generic/discriminator.ll
llvm/test/DebugInfo/Generic/disubrange_vla.ll
llvm/test/DebugInfo/Generic/disubrange_vla_no_dbgvalue.ll
llvm/test/DebugInfo/Generic/dwarf-public-names.ll
llvm/test/DebugInfo/Generic/empty.ll
llvm/test/DebugInfo/Generic/enum.ll
llvm/test/DebugInfo/Generic/fortran-subprogram-attr.ll
llvm/test/DebugInfo/Generic/global.ll
llvm/test/DebugInfo/Generic/gmlt.test
llvm/test/DebugInfo/Generic/gmlt_profiling.ll
llvm/test/DebugInfo/Generic/imported-name-inlined.ll
llvm/test/DebugInfo/Generic/incorrect-variable-debugloc.ll
llvm/test/DebugInfo/Generic/inline-scopes.ll
llvm/test/DebugInfo/Generic/inlined-arguments.ll
llvm/test/DebugInfo/Generic/inlined-strings.ll
llvm/test/DebugInfo/Generic/linkage-name-abstract.ll
llvm/test/DebugInfo/Generic/lto-comp-dir.ll
llvm/test/DebugInfo/Generic/mainsubprogram.ll
llvm/test/DebugInfo/Generic/member-order.ll
llvm/test/DebugInfo/Generic/member-pointers.ll
llvm/test/DebugInfo/Generic/namespace_function_definition.ll
llvm/test/DebugInfo/Generic/namespace_inline_function_definition.ll
llvm/test/DebugInfo/Generic/no-empty-child-vars.ll
llvm/test/DebugInfo/Generic/noscopes.ll
llvm/test/DebugInfo/Generic/pass-by-value.ll
llvm/test/DebugInfo/Generic/ptrsize.ll
llvm/test/DebugInfo/Generic/recursive_inlining.ll
llvm/test/DebugInfo/Generic/skeletoncu.ll
llvm/test/DebugInfo/Generic/sugared-constants.ll
llvm/test/DebugInfo/Generic/template-recursive-void.ll
llvm/test/DebugInfo/Generic/thrownTypes.ll
llvm/test/DebugInfo/Generic/two-cus-from-same-file.ll
llvm/test/DebugInfo/Generic/typedef.ll
llvm/test/DebugInfo/Generic/unconditional-branch.ll
llvm/test/DebugInfo/Generic/univariant-discriminated-union.ll
llvm/test/DebugInfo/Generic/version.ll
llvm/test/DebugInfo/Generic/virtual-index.ll
llvm/test/DebugInfo/X86/dwarfdump-generic_subrange.ll
llvm/test/DebugInfo/X86/dwarfdump-generic_subrange_const.ll
llvm/test/DebugInfo/X86/dwarfdump-generic_subrange_count.ll
llvm/test/DebugInfo/X86/dwarfdump-rankConst.ll
llvm/test/DebugInfo/X86/dwarfdump-rankExp.ll
llvm/test/DebugInfo/X86/dwarfdump-signed_const.ll
llvm/test/DebugInfo/X86/global-constants.ll
llvm/test/DebugInfo/X86/invalid-global-constants.ll
llvm/test/DebugInfo/cross-cu-scope.ll
llvm/test/DebugInfo/dwo.ll
llvm/test/DebugInfo/omit-empty.ll
llvm/test/DebugInfo/skeletoncu.ll
llvm/test/LTO/X86/bcsection.ll
llvm/test/LTO/X86/remangle_intrinsics.ll
llvm/test/Linker/subprogram-linkonce-weak.ll
llvm/test/Linker/type-unique-odr-a.ll
llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
|
Do we still need this? -emit-obj is already excluded?