Page MenuHomePhabricator

[mlir][sparse] Adding dynamic-size support for sparse=>dense conversion
ClosedPublic

Authored by wrengr on Oct 27 2021, 4:08 PM.

Diff Detail

Event Timeline

wrengr created this revision.Oct 27 2021, 4:08 PM
wrengr requested review of this revision.Oct 27 2021, 4:08 PM
wrengr updated this revision to Diff 383134.Oct 28 2021, 12:55 PM

Rebased onto newest version of D110790

wrengr updated this revision to Diff 383172.Oct 28 2021, 2:51 PM

Rebasing to latest version of D110790

aartbik accepted this revision.Oct 28 2021, 4:28 PM

I would also add or extend the end-to-end integration test for a case like this, but that can be done in a follow-up revision.

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp
447

you could add an assert here that the constants match, but perhaps that is overkilll

This revision is now accepted and ready to land.Oct 28 2021, 4:28 PM

I would also add or extend the end-to-end integration test for a case like this, but that can be done in a follow-up revision.

New integration tests (and some debugging) is in D112854.