This is an archive of the discontinued LLVM Phabricator instance.

Differential D112151

[llvm-dwarfdump] Add a test for --summarize-types
ClosedPublic

Authored by gbreynoo on Oct 20 2021, 9:21 AM.

Details

Reviewers
MaskRay
dblaikie
Higuoxing
jhenderson
Commits
rG2b841e4cb9f2: [llvm-dwarfdump] Improve testing of --summarize-types
Summary

I could not find a test for --summarize-types, this change adds one.

Diff Detail

Event Timeline

gbreynoo created this revision.Oct 20 2021, 9:21 AM
Herald added a subscriber: cmtice. · View Herald TranscriptOct 20 2021, 9:21 AM
gbreynoo requested review of this revision.Oct 20 2021, 9:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2021, 9:21 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
gbreynoo added a comment.Oct 20 2021, 9:22 AM

I was looking to do this in YAML but I don't think there is support for debug_types?

Harbormaster completed remote builds in B129756: Diff 380988.Oct 20 2021, 10:04 AM
Higuoxing accepted this revision.Oct 20 2021, 6:59 PM
In D112151#3075510, @gbreynoo wrote:

I was looking to do this in YAML but I don't think there is support for debug_types?

Yeah, you're right, yaml2obj doesn't support debug_types.

LGTM. Thanks!

This revision is now accepted and ready to land.Oct 20 2021, 6:59 PM
dblaikie requested changes to this revision.Oct 20 2021, 8:47 PM

I'm not sure what you mean that this feature isn't tested - a quick search through llvm/test seems to indicate a test case here: llvm/test/DebugInfo/dwarfdump-type-units.test:RUN: llvm-dwarfdump -v %p/Inputs/dwarfdump-type-units.elf-x86-64 -summarize-types | FileCheck -check-prefix=CHECK -check-prefix=SHORT %s - is this test inadequate?

This revision now requires changes to proceed.Oct 20 2021, 8:47 PM
gbreynoo updated this revision to Diff 381524.Oct 22 2021, 6:23 AM

Good catch dblaikie, I missed that test and it covers almost all I was testing here. This updated revision adds a check that I think was missing from the existing test.

Harbormaster completed remote builds in B130126: Diff 381524.Oct 22 2021, 6:32 AM
dblaikie added a comment.Oct 22 2021, 1:05 PM

Maybe adding -implicit-check-not=DW_TAG (or even -implicit-check-not=DW_ maybe) to the short FileCheck invocation would be suitable?

gbreynoo added a comment.Oct 25 2021, 9:24 AM

Using -implicit-check-not=DW_TAG fails due to finding the string output in other sections, I think the explicit check might be required.

dblaikie added a comment.Oct 25 2021, 10:40 AM

Perhaps the summarize-types test could be changed to only dump -debug-types (passing that arg instead of -v to the llvm-dwarfdump invocation) & then it could use -implicit-check-not=DW_?

gbreynoo updated this revision to Diff 383364.Oct 29 2021, 8:28 AM

As suggested by dblaikie, now the call with summarize-types dumps -debug-types and not the other sections. To keep the useful check of the type_signature value it has been changed to the LONG prefix check.

Harbormaster completed remote builds in B131433: Diff 383364.Oct 29 2021, 9:25 AM
dblaikie accepted this revision.Oct 29 2021, 2:33 PM

Looks good, thanks!

This revision is now accepted and ready to land.Oct 29 2021, 2:33 PM
Closed by commit rG2b841e4cb9f2: [llvm-dwarfdump] Improve testing of --summarize-types (authored by gbreynoo). · Explain WhyNov 1 2021, 4:07 AM
This revision was automatically updated to reflect the committed changes.
gbreynoo added a commit: rG2b841e4cb9f2: [llvm-dwarfdump] Improve testing of --summarize-types.

Revision Contents

PathSize
llvm/
test/
DebugInfo/
2 lines

Diff 381524

llvm/test/DebugInfo/dwarfdump-type-units.test

Show All 19 Lines
SHORT: name = SHORT: name =
CHECK-SAME: 'bar', type_signature = [[BAR_SIG]] CHECK-SAME: 'bar', type_signature = [[BAR_SIG]]
SHORT-SAME: length = SHORT-SAME: length =
LONG-SAME: type_offset = 0x[[BAR_OFF:[0-9a-f]*]] (next unit at LONG-SAME: type_offset = 0x[[BAR_OFF:[0-9a-f]*]] (next unit at
LONG: DW_TAG_type_unit LONG: DW_TAG_type_unit
LONG-NOT: NULL LONG-NOT: NULL
LONG: 0x0000[[BAR_OFF]]: DW_TAG_structure_type LONG: 0x0000[[BAR_OFF]]: DW_TAG_structure_type
LONG-NEXT: DW_AT_name {{.*}}"bar" LONG-NEXT: DW_AT_name {{.*}}"bar"
SHORT-NOT: DW_AT_name {{.*}}"bar"
LONG: 0x00000000: Type Unit: {{.*}} name = LONG: 0x00000000: Type Unit: {{.*}} name =
SHORT: name = SHORT: name =
CHECK-SAME: 'foo', type_signature = [[FOO_SIG]] CHECK-SAME: 'foo', type_signature = [[FOO_SIG]]
LONG-SAME: type_offset = 0x[[FOO_OFF:[0-9a-f]*]] (next unit at LONG-SAME: type_offset = 0x[[FOO_OFF:[0-9a-f]*]] (next unit at
LONG: DW_TAG_type_unit LONG: DW_TAG_type_unit
LONG-NOT: NULL LONG-NOT: NULL
LONG: 0x0000[[FOO_OFF]]: DW_TAG_structure_type LONG: 0x0000[[FOO_OFF]]: DW_TAG_structure_type
LONG-NEXT: DW_AT_name {{.*}}"foo" LONG-NEXT: DW_AT_name {{.*}}"foo"
SHORT-NOT: DW_AT_name {{.*}}"foo"
TYPES-NOT: debug_info contents: TYPES-NOT: debug_info contents:
TYPES: debug_types contents: TYPES: debug_types contents: