[llvm-dwarfdump] Add a test for --summarize-types

[gbreynoo]

Summary

I could not find a test for --summarize-types, this change adds one.

[gbreynoo]

I was looking to do this in YAML but I don't think there is support for debug_types?

[Higuoxing]

In D112151#3075510, @gbreynoo wrote:

I was looking to do this in YAML but I don't think there is support for debug_types?

Yeah, you're right, yaml2obj doesn't support debug_types.

LGTM. Thanks!

[dblaikie]

I'm not sure what you mean that this feature isn't tested - a quick search through llvm/test seems to indicate a test case here: llvm/test/DebugInfo/dwarfdump-type-units.test:RUN: llvm-dwarfdump -v %p/Inputs/dwarfdump-type-units.elf-x86-64 -summarize-types | FileCheck -check-prefix=CHECK -check-prefix=SHORT %s - is this test inadequate?

[gbreynoo]

Good catch dblaikie, I missed that test and it covers almost all I was testing here. This updated revision adds a check that I think was missing from the existing test.

[dblaikie]

Maybe adding -implicit-check-not=DW_TAG (or even -implicit-check-not=DW_ maybe) to the short FileCheck invocation would be suitable?

[gbreynoo]

Using -implicit-check-not=DW_TAG fails due to finding the string output in other sections, I think the explicit check might be required.

[dblaikie]

Perhaps the summarize-types test could be changed to only dump -debug-types (passing that arg instead of -v to the llvm-dwarfdump invocation) & then it could use -implicit-check-not=DW_?

[gbreynoo]

As suggested by dblaikie, now the call with summarize-types dumps -debug-types and not the other sections. To keep the useful check of the type_signature value it has been changed to the LONG prefix check.

[dblaikie]

Looks good, thanks!

llvm/test/DebugInfo/dwarfdump-type-units.test

-RUN: llvm-dwarfdump -v %p/Inputs/dwarfdump-type-units.elf-x86-64 | FileCheck -check-prefix=CHECK -check-prefix=LONG %s
-RUN: llvm-dwarfdump -v %p/Inputs/dwarfdump-type-units.elf-x86-64 -summarize-types | FileCheck -check-prefix=CHECK -check-prefix=SHORT %s
+RUN: llvm-dwarfdump -v %p/Inputs/dwarfdump-type-units.elf-x86-64 | FileCheck -check-prefix=INFO -check-prefix=CHECK -check-prefix=LONG %s
+RUN: llvm-dwarfdump -debug-types %p/Inputs/dwarfdump-type-units.elf-x86-64 -summarize-types | FileCheck -implicit-check-not=DW_ -check-prefix=CHECK -check-prefix=SHORT %s
 RUN: llvm-dwarfdump -v -debug-types %p/Inputs/dwarfdump-type-units.elf-x86-64 | FileCheck -check-prefix=TYPES %s
 
-CHECK: debug_info contents:
+INFO: debug_info contents:
 
-CHECK: DW_TAG_variable
-CHECK-NEXT: DW_AT_name {{.*}}"f"
-CHECK: DW_AT_type [DW_FORM_ref_sig8] ([[FOO_SIG:0x[0-9a-f]*]]
-
-CHECK: DW_TAG_variable
-CHECK-NEXT: DW_AT_name {{.*}}"b"
-CHECK: DW_AT_type [DW_FORM_ref_sig8] ([[BAR_SIG:0x[0-9a-f]*]]
+INFO: DW_TAG_variable
+INFO-NEXT: DW_AT_name {{.*}}"f"
+INFO: DW_AT_type [DW_FORM_ref_sig8] ([[FOO_SIG:0x[0-9a-f]*]]
+
+INFO: DW_TAG_variable
+INFO-NEXT: DW_AT_name {{.*}}"b"
+INFO: DW_AT_type [DW_FORM_ref_sig8] ([[BAR_SIG:0x[0-9a-f]*]]
 
 
 CHECK: debug_types contents:
 
 LONG: 0x00000000: Type Unit: {{.*}} name =
 SHORT-NOT: Type Unit
 SHORT: name =
-CHECK-SAME: 'bar', type_signature = [[BAR_SIG]]
+CHECK-SAME: 'bar', type_signature = 
+LONG: [[BAR_SIG]]
 SHORT-SAME: length =
 LONG-SAME: type_offset = 0x[[BAR_OFF:[0-9a-f]*]] (next unit at
 LONG: DW_TAG_type_unit
 LONG-NOT: NULL
 LONG: 0x0000[[BAR_OFF]]: DW_TAG_structure_type
 LONG-NEXT: DW_AT_name {{.*}}"bar"
 
 LONG: 0x00000000: Type Unit: {{.*}} name =
 SHORT: name =
-CHECK-SAME: 'foo', type_signature = [[FOO_SIG]]
+CHECK-SAME: 'foo', type_signature =
+LONG: [[FOO_SIG]]
 LONG-SAME: type_offset = 0x[[FOO_OFF:[0-9a-f]*]] (next unit at
 LONG: DW_TAG_type_unit
 LONG-NOT: NULL
 LONG: 0x0000[[FOO_OFF]]: DW_TAG_structure_type
 LONG-NEXT: DW_AT_name {{.*}}"foo"
 
 TYPES-NOT: debug_info contents:
 TYPES: debug_types contents: