[llvm-dwarfdump] Add a test for --summarize-types

[gbreynoo]

Summary

I could not find a test for --summarize-types, this change adds one.

[gbreynoo]

I was looking to do this in YAML but I don't think there is support for debug_types?

[Higuoxing]

In D112151#3075510, @gbreynoo wrote:

I was looking to do this in YAML but I don't think there is support for debug_types?

Yeah, you're right, yaml2obj doesn't support debug_types.

LGTM. Thanks!

[dblaikie]

I'm not sure what you mean that this feature isn't tested - a quick search through llvm/test seems to indicate a test case here: llvm/test/DebugInfo/dwarfdump-type-units.test:RUN: llvm-dwarfdump -v %p/Inputs/dwarfdump-type-units.elf-x86-64 -summarize-types | FileCheck -check-prefix=CHECK -check-prefix=SHORT %s - is this test inadequate?

[gbreynoo]

Good catch dblaikie, I missed that test and it covers almost all I was testing here. This updated revision adds a check that I think was missing from the existing test.

[dblaikie]

Maybe adding -implicit-check-not=DW_TAG (or even -implicit-check-not=DW_ maybe) to the short FileCheck invocation would be suitable?

[gbreynoo]

Using -implicit-check-not=DW_TAG fails due to finding the string output in other sections, I think the explicit check might be required.

[dblaikie]

Perhaps the summarize-types test could be changed to only dump -debug-types (passing that arg instead of -v to the llvm-dwarfdump invocation) & then it could use -implicit-check-not=DW_?

[gbreynoo]

As suggested by dblaikie, now the call with summarize-types dumps -debug-types and not the other sections. To keep the useful check of the type_signature value it has been changed to the LONG prefix check.

[dblaikie]

Looks good, thanks!

llvm/test/tools/llvm-dwarfdump/X86/summarize-types.s

+## Demonstrate that --summarize-types abbreviates output of type information
+# RUN: llvm-mc -triple x86_64-unknown-linux %s -filetype=obj -o %t.o
+
+# RUN: llvm-dwarfdump --debug-types %t.o | FileCheck %s
+# RUN: llvm-dwarfdump --debug-types --summarize-types %t.o | \
+# RUN: FileCheck %s --check-prefix=SUMMARIZED --match-full-lines
+
+# CHECK: .debug_types contents:
+# CHECK-NEXT: 0x00000000: Type Unit:
+# CHECK-SAME: length = 0x0000001a
+# CHECK-SAME: format = DWARF32
+# CHECK-SAME: version = 0x0004
+# CHECK-SAME: abbr_offset = 0x0000
+# CHECK-SAME: addr_size = 0x08
+# CHECK-SAME: name = 'foo'
+# CHECK-SAME: type_signature = 0x0011223344556677
+# CHECK-SAME: type_offset = 0x0017 (next unit at 0x0000001e)
+# CHECK: DW_AT_name ("foo")
+
+# SUMMARIZED: .debug_types contents:
+# SUMMARIZED-NEXT: name = 'foo', type_signature = 0x0011223344556677, length = 0x0000001a
+# SUMMARIZED-NOT: DW_AT_name ("foo")
+
+    .section .debug_str,"MS",@progbits,1
+.Lfoo:
+    .asciz  "foo"
+    
+    .section .debug_abbrev,"",@progbits
+    .byte 0x01  # Abbrev code
+    .byte 0x36  # DW_TAG_base_type
+    .byte 0x00  # DW_CHILDREN_no (no members)
+    .byte 0x03  # DW_AT_name
+    .byte 0x0e  # DW_FORM_strp
+    .byte 0x00  # EOM(1)
+    .byte 0x00  # EOM(2)
+    .byte 0x00  # EOM(3)
+
+    .section .debug_types,"",@progbits
+.Lstart:
+    .long  .Lend-.Lversion   # Length of Unit
+.Lversion:
+    .short 4                 # DWARF version number
+    .long .debug_abbrev      # Offset Into Abbrev. Section
+    .byte 8                  # Address Size (in bytes)
+    .quad 0x0011223344556677 # Type Signature
+    .long .Ltype-.Lstart     # Type offset
+.Ltype:
+    .byte 1
+    .long .Lfoo
+    .byte 0
+    .byte 0
+.Lend:
+