This is an archive of the discontinued LLVM Phabricator instance.

first draft of a written policy around git repos
ClosedPublic

Authored by kuhnel on Oct 13 2021, 8:15 AM.

Details

Summary

This is a frist draft of a set of policies around new git repos and how we grant write access to our GitHub organisation.

This proposal is based on the discussions in:
https://github.com/llvm/llvm-iwg/issues/40
https://github.com/llvm/llvm-iwg/issues/51

Diff Detail

Event Timeline

kuhnel requested review of this revision.Oct 13 2021, 8:15 AM
kuhnel created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2021, 8:15 AM

This is just general comment as I want to read this and think a bit on it, but I think that any criteria about adding a repo should only be in the developer policy. The rest about what to do after, can remain in a separate document.

Tagging @lattner

mehdi_amini added inline comments.Oct 13 2021, 8:22 PM
llvm/docs/RepoPolicy.md
3 ↗(On Diff #379401)
4 ↗(On Diff #379401)
kristof.beyls added inline comments.
llvm/docs/RepoPolicy.md
17–18 ↗(On Diff #379401)

is the URL ending in CONTRIBUTING.md the right URL for LICENSE.TXT here?
I guess that in special circumstances, there could be an exception for a repo to use a different license? E.g. it seems the existing https://github.com/llvm/bugzilla2gitlab and https://github.com/llvm/phabricator repos have different licenses?
I do agree that we should require a LICENSE.TXT or alternative mechanism to clearly document the license covering the repo.

30 ↗(On Diff #379401)

s/provides/providers/?

This doc looks like a nice clarification, thank you for driving this!

llvm/docs/GettingInvolved.rst
22

Would it be problematic to expand this to GitRepositoryPolicy.md ?

kuhnel updated this revision to Diff 379970.Oct 15 2021, 4:49 AM
kuhnel marked 5 inline comments as done.

addressed review feedback

Thx everyone for the reviews, I updated the proposal accordingly.

@tonic
Let me know if you want to see (parts of) this change moved to DeveloperPolicy.rst.
My rationale was: Keep info we only need a handful of times per year out of DeveloperPolicy.

llvm/docs/RepoPolicy.md
17–18 ↗(On Diff #379401)

is the URL ending in CONTRIBUTING.md the right URL for LICENSE.TXT here?

Thx, was a copy-and-paste error

I guess that in special circumstances, there could be an exception for a repo to use a different license? E.g. it seems the existing https://github.com/llvm/bugzilla2gitlab and https://github.com/llvm/phabricator repos have different licenses?

Good point. I reworded to prefer the LLVM license but others are possible.

tonic added a comment.Oct 18 2021, 1:58 PM

Thx everyone for the reviews, I updated the proposal accordingly.

@tonic
Let me know if you want to see (parts of) this change moved to DeveloperPolicy.rst.
My rationale was: Keep info we only need a handful of times per year out of DeveloperPolicy.

Sounds like Chris is fine with it, so I am too. I just wanted to make sure he saw the patch and had a chance to review.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 19 2021, 1:06 AM
This revision was automatically updated to reflect the committed changes.