- User Since
- Jan 14 2015, 10:00 AM (359 w, 3 d)
Jan 28 2021
Nov 18 2020
LGTM. Thanks Tom!
Jun 27 2020
Jun 6 2020
Dec 12 2019
Oct 29 2019
Jun 6 2019
Beanz if you can send me an example of what you think the directory layout should look like I'll try to implement one of these on the mono-repo and get a test bot running. Then folks could have an example to look at.
Perhaps if they existed, it might be easier to bot owners to use them.
I think bot owners need to create and maintain them. Today bot owners control what flags they pass to CMake and we shouldn't change that.
Aug 29 2018
First off, thanks for offering to help make the website work correctly! This all looks pretty reasonable to me. I'm wondering though, would it be possible to break this patch up into a few smaller patches? Since we do not have any type of staging infrastructure for llvm.org, I would prefer we not change so many files all at once. I feel like three steps here might be appropriate:
- Try with one file (one of the files with a one or two line change) to ensure the changes work as we expect them to.
- Apply changes to the rest of the files with the exception of footer.incl.
Jul 26 2018
Jul 19 2018
I have added the recommonmark python package to the server. It should be available to the doc bot now so I would say go ahead and land this patch and let's see what happens.
Jun 27 2018
Jun 18 2018
Apr 6 2018
Though my Buildbot foo is a bit rusty these days, this LGTM.
Apr 2 2018
It appears the commit related to this review has cause a bot failure on
Green Dragon. This failure was masked by an earlier failure which was
reverted a short time ago. Please have a look at:
either revert your commit or notify me if you will be submitting a patch
within the next hour.
Mar 27 2018
Mar 12 2018
Mar 9 2018
Any chance you could have one more look at this and let me know if the
patch is acceptable?
Mar 5 2018
I copied what Eric did here: https://github.com/llvm-mirror/libcxx/commit/6878e852d1d26cca0abee3013822311cd894ca3e. I have tested this on our bots and the fix works fine.
Nov 3 2017
I'm fine with the changes being made. We just need to coordinate a date & time for the cutover so we don't set Green Dragon ablaze.
Nov 1 2017
Sep 19 2017
So after locally reverting r313643 and then applying only the patch related to libcxx/cmake/Modules/HandleOutOfTreeLLVM.cmake I was able to configure and build libcxx successfully.
May 2 2017
May 1 2017
Chris Matthews asked me to make the above revisions and then go ahead and commit.
Adjusted code per comments from cmatthews.
Apr 24 2017
Based on the feedback I have received form Mehdi, I am going to abandon this revision and go refactor this so it makes more sense. Thanks for the feedback Mehdi!
Apr 21 2017
Oct 20 2016
cmatthews replied "LGTM" via email.
Oct 11 2016
Aug 30 2016
Feb 27 2016
I will admit that I do not understand enough about how diff works to be confident that diff'ing the symbolic link to the binary would produce the same result as diff'ing the binary itself. It seems to. Probably dumb, but I wanted to be able to say with absolute certainty that I was diff'ing the just built binaries.
Feb 26 2016
Feb 25 2016
Feb 22 2016
Removed unnecessary assertions.
Removed unnecessary assertions.
Feb 21 2016
After review from silvas, used the asserts in a better manner. Also removed unneeded parenthesis from the lit_args join expression.
I applied the comments silvas provided and also adjusted the formatting of the shell_command for the last build step.
I may have gone a bit overboard with the asserts, happy to hear your (or any other) opinion on the matter.
Feb 20 2016
New Rule: Mike is no longer allowed to post patches after Midnight PST. This is a bad fix. I will go and rethink the proper solution with a clear head now.