Page MenuHomePhabricator

sqlbyme (Mike Edwards)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 14 2015, 10:00 AM (239 w, 4 d)

Recent Activity

Jun 6 2019

sqlbyme added a comment to D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files..

Btw, where would you want to put them?

Pre-monorepo, it would depend on what the bot is building, but with the mono-repo we could just create a new top-level directory to contain them all. Name each file to match the bot config it runs.

Beanz if you can send me an example of what you think the directory layout should look like I'll try to implement one of these on the mono-repo and get a test bot running. Then folks could have an example to look at.

Perhaps if they existed, it might be easier to bot owners to use them.

I think bot owners need to create and maintain them. Today bot owners control what flags they pass to CMake and we shouldn't change that.

Jun 6 2019, 5:09 PM · Restricted Project

Aug 29 2018

sqlbyme added a comment to D51255: [WWW] Use https instead of http to fix page problems.

First off, thanks for offering to help make the website work correctly! This all looks pretty reasonable to me. I'm wondering though, would it be possible to break this patch up into a few smaller patches? Since we do not have any type of staging infrastructure for llvm.org, I would prefer we not change so many files all at once. I feel like three steps here might be appropriate:

  1. Try with one file (one of the files with a one or two line change) to ensure the changes work as we expect them to.
  2. Apply changes to the rest of the files with the exception of footer.incl.
  3. Apply the last patch to footer.incl which adds the javascript bits in the footer (my experience tells me this is the most likely to break something, though the JS you have provided LGTM).
Aug 29 2018, 10:28 AM

Jul 26 2018

sqlbyme committed rC338098: [WWW] Fixing file permissions for the .html pages..
[WWW] Fixing file permissions for the .html pages.
Jul 26 2018, 9:42 PM
sqlbyme committed rL338098: [WWW] Fixing file permissions for the .html pages..
[WWW] Fixing file permissions for the .html pages.
Jul 26 2018, 9:42 PM
sqlbyme committed rL338087: [WWW] Removing my test file as the auto-deployment script has been fixed..
[WWW] Removing my test file as the auto-deployment script has been fixed.
Jul 26 2018, 4:32 PM
sqlbyme committed rC338087: [WWW] Removing my test file as the auto-deployment script has been fixed..
[WWW] Removing my test file as the auto-deployment script has been fixed.
Jul 26 2018, 4:32 PM
sqlbyme committed rL338086: [WWW] Adding a test page to work out an auto-deployment issue..
[WWW] Adding a test page to work out an auto-deployment issue.
Jul 26 2018, 4:24 PM
sqlbyme committed rC338086: [WWW] Adding a test page to work out an auto-deployment issue..
[WWW] Adding a test page to work out an auto-deployment issue.
Jul 26 2018, 4:23 PM

Jul 19 2018

sqlbyme added a comment to D44910: [docs] Add Markdown support to Sphinx.

Hi,
I have added the recommonmark python package to the server. It should be available to the doc bot now so I would say go ahead and land this patch and let's see what happens.

Jul 19 2018, 4:27 PM

Jun 27 2018

sqlbyme committed rL335793: Updating clang ci dependency versions to match latest updates to Green Dragon….
Updating clang ci dependency versions to match latest updates to Green Dragon…
Jun 27 2018, 4:39 PM

Jun 18 2018

sqlbyme committed rL334960: Updating clang ci dependency versions to match Green Dragon bots..
Updating clang ci dependency versions to match Green Dragon bots.
Jun 18 2018, 9:32 AM

Apr 6 2018

sqlbyme accepted D44982: [zorg] Adding two new builders for armv7 and aarch64.

Though my Buildbot foo is a bit rusty these days, this LGTM.

Apr 6 2018, 3:12 PM

Apr 2 2018

sqlbyme added a comment to D44847: [profile] Fix value profile runtime merging issues.

Hi,
It appears the commit related to this review has cause a bot failure on
Green Dragon. This failure was masked by an earlier failure which was
reverted a short time ago. Please have a look at:
http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/44030/ and
either revert your commit or notify me if you will be submitting a patch
within the next hour.

Apr 2 2018, 12:55 PM
sqlbyme committed rCTE328997: Revert r328932 as it caused Windows and MacOS bot failures..
Revert r328932 as it caused Windows and MacOS bot failures.
Apr 2 2018, 11:07 AM
sqlbyme committed rL328997: Revert r328932 as it caused Windows and MacOS bot failures..
Revert r328932 as it caused Windows and MacOS bot failures.
Apr 2 2018, 11:07 AM

Mar 27 2018

sqlbyme committed rL328675: [ZORG] Updating the FQDN for the asset server for Green Dragon build.py jobs..
[ZORG] Updating the FQDN for the asset server for Green Dragon build.py jobs.
Mar 27 2018, 3:41 PM

Mar 12 2018

sqlbyme committed rCXX327304: [libcxx][test] Adding apple-clang-9 to UNSUPPORTED in iter_alloc_deduction.fail..
[libcxx][test] Adding apple-clang-9 to UNSUPPORTED in iter_alloc_deduction.fail.
Mar 12 2018, 11:14 AM
sqlbyme committed rL327304: [libcxx][test] Adding apple-clang-9 to UNSUPPORTED in iter_alloc_deduction.fail..
[libcxx][test] Adding apple-clang-9 to UNSUPPORTED in iter_alloc_deduction.fail.
Mar 12 2018, 11:10 AM

Mar 9 2018

sqlbyme committed rCXX327191: [libcxx][test] Reverting r327178 and r327190..
[libcxx][test] Reverting r327178 and r327190.
Mar 9 2018, 4:55 PM
sqlbyme committed rL327191: [libcxx][test] Reverting r327178 and r327190..
[libcxx][test] Reverting r327178 and r327190.
Mar 9 2018, 4:55 PM
sqlbyme committed rL327190: [libcxx][test] Marking libcpp-no-deduction-guides unsupported..
[libcxx][test] Marking libcpp-no-deduction-guides unsupported.
Mar 9 2018, 4:23 PM
sqlbyme committed rCXX327190: [libcxx][test] Marking libcpp-no-deduction-guides unsupported..
[libcxx][test] Marking libcpp-no-deduction-guides unsupported.
Mar 9 2018, 4:23 PM
sqlbyme committed rCXX327178: XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic..
XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic.
Mar 9 2018, 2:15 PM
sqlbyme committed rL327178: XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic..
XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic.
Mar 9 2018, 2:15 PM
sqlbyme closed D44103: XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp.
Mar 9 2018, 2:15 PM
sqlbyme retitled D44103: XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp from Adding additional UNSUPPORTED platform in libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp to XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp.
Mar 9 2018, 2:11 PM
sqlbyme updated subscribers of D44103: XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp.

Eric,
Any chance you could have one more look at this and let me know if the
patch is acceptable?

Mar 9 2018, 8:55 AM

Mar 5 2018

sqlbyme updated the diff for D44103: XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp.

I copied what Eric did here: https://github.com/llvm-mirror/libcxx/commit/6878e852d1d26cca0abee3013822311cd894ca3e. I have tested this on our bots and the fix works fine.

Mar 5 2018, 4:16 PM
sqlbyme created D44103: XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp.
Mar 5 2018, 12:14 PM

Nov 3 2017

sqlbyme added a reviewer for D39605: [debuginfo-tests] Decouple debuginfo-tests from the clang source tree.: gkistanova.
Nov 3 2017, 3:43 PM
sqlbyme added a comment to D39605: [debuginfo-tests] Decouple debuginfo-tests from the clang source tree..

I'm fine with the changes being made. We just need to coordinate a date & time for the cutover so we don't set Green Dragon ablaze.

Nov 3 2017, 3:42 PM

Nov 1 2017

sqlbyme committed rL317126: [WWW] Adding a link to Green Dragon on the Useful Links section of the home….
[WWW] Adding a link to Green Dragon on the Useful Links section of the home…
Nov 1 2017, 2:32 PM

Sep 19 2017

sqlbyme added a comment to D38057: Try again to fix libcxx CMake so that it doesn't break when no LLVM source tree is available.

So after locally reverting r313643 and then applying only the patch related to libcxx/cmake/Modules/HandleOutOfTreeLLVM.cmake I was able to configure and build libcxx successfully.

Sep 19 2017, 10:13 PM
sqlbyme closed D32704: [ZORG] Update Jenkins/build.py to force SVN upgrade of the working directory..
Sep 19 2017, 10:09 PM · Restricted Project
sqlbyme removed a reviewer for D32704: [ZORG] Update Jenkins/build.py to force SVN upgrade of the working directory.: cmatthews.
Sep 19 2017, 10:08 PM · Restricted Project
sqlbyme committed rL313706: Reverting due to Green Dragon bot failure..
Reverting due to Green Dragon bot failure.
Sep 19 2017, 6:22 PM
sqlbyme committed rL313634: Revert r313600 due to bot failures on Green Dragon..
Revert r313600 due to bot failures on Green Dragon.
Sep 19 2017, 7:53 AM

May 2 2017

sqlbyme committed rL301933: Fixing a test failure and refactoring the use of the update_svn_checkout….
Fixing a test failure and refactoring the use of the update_svn_checkout…
May 2 2017, 9:26 AM

May 1 2017

sqlbyme committed rL301886: Fixing an unbound local variable in Jenkins/build.py..
Fixing an unbound local variable in Jenkins/build.py.
May 1 2017, 5:09 PM
sqlbyme committed rL301884: [ZORG] Update Jenkins/build.py to force SVN upgrade of the working directory..
[ZORG] Update Jenkins/build.py to force SVN upgrade of the working directory.
May 1 2017, 4:55 PM
sqlbyme accepted D32704: [ZORG] Update Jenkins/build.py to force SVN upgrade of the working directory..

Chris Matthews asked me to make the above revisions and then go ahead and commit.

May 1 2017, 4:43 PM · Restricted Project
sqlbyme updated the diff for D32704: [ZORG] Update Jenkins/build.py to force SVN upgrade of the working directory..

Adjusted code per comments from cmatthews.

May 1 2017, 4:43 PM · Restricted Project
sqlbyme created D32704: [ZORG] Update Jenkins/build.py to force SVN upgrade of the working directory..
May 1 2017, 10:27 AM · Restricted Project
sqlbyme closed D25840: [GreenDragon] modify build.py to create destination directory prior to uploading artifacts.
May 1 2017, 10:17 AM · Restricted Project

Apr 24 2017

sqlbyme abandoned D32362: Update Jenkins Build.py to check and upgrade svn version in working dir as necessary..

Based on the feedback I have received form Mehdi, I am going to abandon this revision and go refactor this so it makes more sense. Thanks for the feedback Mehdi!

Apr 24 2017, 1:30 PM · Restricted Project

Apr 21 2017

sqlbyme added inline comments to D32362: Update Jenkins Build.py to check and upgrade svn version in working dir as necessary..
Apr 21 2017, 3:31 PM · Restricted Project
sqlbyme created D32362: Update Jenkins Build.py to check and upgrade svn version in working dir as necessary..
Apr 21 2017, 11:20 AM · Restricted Project

Oct 20 2016

sqlbyme committed rL284772: [GreenDragon] modify build.py to create destination directory prior to….
[GreenDragon] modify build.py to create destination directory prior to…
Oct 20 2016, 1:23 PM
sqlbyme accepted D25840: [GreenDragon] modify build.py to create destination directory prior to uploading artifacts.

cmatthews replied "LGTM" via email.

Oct 20 2016, 1:20 PM · Restricted Project
sqlbyme retitled D25840: [GreenDragon] modify build.py to create destination directory prior to uploading artifacts from to [GreenDragon] modify build.py to create destination directory prior to uploading artifacts.
Oct 20 2016, 1:05 PM · Restricted Project

Oct 11 2016

sqlbyme committed rL283950: Revert - When optimizing for size, enable loop rerolling by default.
Revert - When optimizing for size, enable loop rerolling by default
Oct 11 2016, 3:18 PM

Aug 30 2016

sqlbyme committed rL280171: [zorg] Removing the blank line from my test commit..
[zorg] Removing the blank line from my test commit.
Aug 30 2016, 3:57 PM
sqlbyme committed rL280170: [zorg] Adding a blank line as a test commit..
[zorg] Adding a blank line as a test commit.
Aug 30 2016, 3:49 PM

Feb 27 2016

sqlbyme added a comment to D17666: [zorg] Correcting a bug in ClangLTO3StageBuilder.py..

I will admit that I do not understand enough about how diff works to be confident that diff'ing the symbolic link to the binary would produce the same result as diff'ing the binary itself. It seems to. Probably dumb, but I wanted to be able to say with absolute certainty that I was diff'ing the just built binaries.

Feb 27 2016, 9:47 AM · Restricted Project

Feb 26 2016

sqlbyme closed D17669: [zorg] Fixing an incorrect variable name..
Feb 26 2016, 7:50 PM · Restricted Project
sqlbyme retitled D17669: [zorg] Fixing an incorrect variable name. from to [zorg] Fixing an incorrect variable name..
Feb 26 2016, 5:53 PM · Restricted Project
sqlbyme closed D17666: [zorg] Correcting a bug in ClangLTO3StageBuilder.py..
Feb 26 2016, 5:33 PM · Restricted Project
sqlbyme closed D17653: [zorg] Adding back the clang-3stage-ubuntu builder with a new build slave..
Feb 26 2016, 5:32 PM · Restricted Project
sqlbyme retitled D17666: [zorg] Correcting a bug in ClangLTO3StageBuilder.py. from to [zorg] Correcting a bug in ClangLTO3StageBuilder.py..
Feb 26 2016, 4:48 PM · Restricted Project
sqlbyme retitled D17655: A couple of minor tweaks to cmake. from to A couple of minor tweaks to cmake..
Feb 26 2016, 1:02 PM
sqlbyme retitled D17653: [zorg] Adding back the clang-3stage-ubuntu builder with a new build slave. from to [zorg] Adding back the clang-3stage-ubuntu builder with a new build slave..
Feb 26 2016, 11:15 AM · Restricted Project
sqlbyme closed D17617: [zorg] Removing a flakey builder from production build master..
Feb 26 2016, 11:05 AM · Restricted Project
sqlbyme closed D17620: [zorg] Adding an additional buildslave..
Feb 26 2016, 11:05 AM · Restricted Project

Feb 25 2016

sqlbyme retitled D17617: [zorg] Removing a flakey builder from production build master. from [zorg] Removing a flaky builder from production build master. to [zorg] Removing a flakey builder from production build master..
Feb 25 2016, 11:30 AM · Restricted Project
sqlbyme retitled D17620: [zorg] Adding an additional buildslave. from to [zorg] Adding an additional buildslave..
Feb 25 2016, 11:29 AM · Restricted Project
sqlbyme retitled D17617: [zorg] Removing a flakey builder from production build master. from to [zorg] Removing a flaky builder from production build master..
Feb 25 2016, 10:40 AM · Restricted Project
sqlbyme closed D17493: [zorg] ClangLTO3StageBuilder.py - Adding a cast string to list item and some asserts.
Feb 25 2016, 10:35 AM · Restricted Project
sqlbyme closed D17494: [zorg] ClangAndLLDBuilder.py - Adding a missing cast and adding some asserts.
Feb 25 2016, 10:35 AM · Restricted Project
sqlbyme closed D17495: [zorg] Builders.py - NFC - cleaning up some formatting of builder definitions I had posted earlier..
Feb 25 2016, 10:34 AM · Restricted Project

Feb 22 2016

sqlbyme updated the diff for D17494: [zorg] ClangAndLLDBuilder.py - Adding a missing cast and adding some asserts.

Removed unnecessary assertions.

Feb 22 2016, 6:52 PM · Restricted Project
sqlbyme updated the diff for D17493: [zorg] ClangLTO3StageBuilder.py - Adding a cast string to list item and some asserts.

Removed unnecessary assertions.

Feb 22 2016, 6:51 PM · Restricted Project
sqlbyme added a comment to D17493: [zorg] ClangLTO3StageBuilder.py - Adding a cast string to list item and some asserts.
Feb 22 2016, 6:48 PM · Restricted Project
sqlbyme added inline comments to D17493: [zorg] ClangLTO3StageBuilder.py - Adding a cast string to list item and some asserts.
Feb 22 2016, 6:47 PM · Restricted Project

Feb 21 2016

sqlbyme updated the diff for D17494: [zorg] ClangAndLLDBuilder.py - Adding a missing cast and adding some asserts.

After review from silvas, used the asserts in a better manner. Also removed unneeded parenthesis from the lit_args join expression.

Feb 21 2016, 9:36 PM · Restricted Project
sqlbyme updated the diff for D17493: [zorg] ClangLTO3StageBuilder.py - Adding a cast string to list item and some asserts.

I applied the comments silvas provided and also adjusted the formatting of the shell_command for the last build step.

Feb 21 2016, 9:24 PM · Restricted Project
sqlbyme added a comment to D17493: [zorg] ClangLTO3StageBuilder.py - Adding a cast string to list item and some asserts.
Feb 21 2016, 9:20 PM · Restricted Project
sqlbyme retitled D17495: [zorg] Builders.py - NFC - cleaning up some formatting of builder definitions I had posted earlier. from to [zorg] Builders.py - NFC - cleaning up some formatting of builder definitions I had posted earlier..
Feb 21 2016, 5:12 PM · Restricted Project
sqlbyme added a comment to D17494: [zorg] ClangAndLLDBuilder.py - Adding a missing cast and adding some asserts.

Galina,
I may have gone a bit overboard with the asserts, happy to hear your (or any other) opinion on the matter.

Feb 21 2016, 5:10 PM · Restricted Project
sqlbyme retitled D17494: [zorg] ClangAndLLDBuilder.py - Adding a missing cast and adding some asserts from to [zorg] ClangAndLLDBuilder.py - Adding a missing cast and adding some asserts.
Feb 21 2016, 5:09 PM · Restricted Project
sqlbyme retitled D17493: [zorg] ClangLTO3StageBuilder.py - Adding a cast string to list item and some asserts from to [zorg] ClangLTO3StageBuilder.py - Adding a cast string to list item and some asserts.
Feb 21 2016, 5:05 PM · Restricted Project

Feb 20 2016

sqlbyme abandoned D17478: [zorg] Refactor builder and factory definition for Clang-3Stage-Ubuntu bot..

New Rule: Mike is no longer allowed to post patches after Midnight PST. This is a bad fix. I will go and rethink the proper solution with a clear head now.

Feb 20 2016, 10:03 AM · Restricted Project
sqlbyme retitled D17478: [zorg] Refactor builder and factory definition for Clang-3Stage-Ubuntu bot. from to [zorg] Refactor builder and factory definition for Clang-3Stage-Ubuntu bot..
Feb 20 2016, 12:37 AM · Restricted Project
sqlbyme closed D17468: [zorg] Adding a new builder to test ClandLTO3StageBuilder.py.
Feb 20 2016, 12:32 AM · Restricted Project

Feb 19 2016

sqlbyme retitled D17468: [zorg] Adding a new builder to test ClandLTO3StageBuilder.py from to [zorg] Adding a new builder to test ClandLTO3StageBuilder.py.
Feb 19 2016, 5:41 PM · Restricted Project
sqlbyme closed D17351: [zorg] Addition of extraLitArgs variable to ClangAndLLDBuilder.py.
Feb 19 2016, 5:34 PM · Restricted Project
sqlbyme closed D17352: [zorg] Adding extraLitArgs to a builder definition..
Feb 19 2016, 5:34 PM · Restricted Project
sqlbyme closed D17364: [zorg] Adding ClangLTO3StageBuilder.py build factory..
Feb 19 2016, 5:34 PM · Restricted Project
sqlbyme updated the diff for D17351: [zorg] Addition of extraLitArgs variable to ClangAndLLDBuilder.py.
Feb 19 2016, 2:31 PM · Restricted Project
sqlbyme updated the diff for D17351: [zorg] Addition of extraLitArgs variable to ClangAndLLDBuilder.py.
Feb 19 2016, 11:51 AM · Restricted Project
sqlbyme added a comment to D17364: [zorg] Adding ClangLTO3StageBuilder.py build factory..

Galina, I had to change the name of the file because starting the name with the number 3 was a syntax error.

Feb 19 2016, 11:37 AM · Restricted Project
sqlbyme updated the diff for D17364: [zorg] Adding ClangLTO3StageBuilder.py build factory..
Feb 19 2016, 11:36 AM · Restricted Project
sqlbyme updated the diff for D17364: [zorg] Adding ClangLTO3StageBuilder.py build factory..
Feb 19 2016, 10:59 AM · Restricted Project

Feb 18 2016

sqlbyme added inline comments to D17364: [zorg] Adding ClangLTO3StageBuilder.py build factory..
Feb 18 2016, 3:49 PM · Restricted Project
sqlbyme updated the diff for D17364: [zorg] Adding ClangLTO3StageBuilder.py build factory..

Hi Galina,
I have updated per your comments. Let me know if anything else needs attention. Thanks for your help.

Feb 18 2016, 3:46 PM · Restricted Project

Feb 17 2016

sqlbyme retitled D17364: [zorg] Adding ClangLTO3StageBuilder.py build factory. from to [zorg] Adding 3StageClangLTOBuilder.py build factory..
Feb 17 2016, 6:46 PM · Restricted Project
sqlbyme retitled D17352: [zorg] Adding extraLitArgs to a builder definition. from to [zorg] Adding extraLitArgs to a builder definition..
Feb 17 2016, 2:45 PM · Restricted Project
sqlbyme retitled D17351: [zorg] Addition of extraLitArgs variable to ClangAndLLDBuilder.py from to [zorg] Addition of extraLitArgs variable to ClangAndLLDBuilder.py.
Feb 17 2016, 2:30 PM · Restricted Project
sqlbyme closed D17155: [PATCH] [zorg] Tweaking the ClangAndLLDbuilder.py build factory to better accommodate MSVC builds..
Feb 17 2016, 1:48 PM · Restricted Project

Feb 11 2016

sqlbyme retitled D17155: [PATCH] [zorg] Tweaking the ClangAndLLDbuilder.py build factory to better accommodate MSVC builds. from to [PATCH] [zorg] Tweaking the ClangAndLLDbuilder.py build factory to better accommodate MSVC builds..
Feb 11 2016, 10:44 AM · Restricted Project

Mar 31 2015

sqlbyme updated subscribers of D8723: Check Compile Flow Consistency tool (check_cfc.py).
Mar 31 2015, 2:32 PM