Page MenuHomePhabricator

[mlir][Linalg] Enable vectorization of 'mul', 'and', 'or' and 'xor' reductions
ClosedPublic

Authored by dcaballe on Oct 11 2021, 10:48 AM.

Details

Summary

This patch adds support for vectorizing 'mul', 'and', 'or' anx 'xor' reductions
to Linalg.

Diff Detail

Event Timeline

dcaballe created this revision.Oct 11 2021, 10:48 AM
dcaballe requested review of this revision.Oct 11 2021, 10:48 AM
aartbik added inline comments.Oct 11 2021, 10:58 AM
mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
131

since you are adding and/or, how about adding xor too?

pifon2a accepted this revision.Oct 11 2021, 11:05 AM
This revision is now accepted and ready to land.Oct 11 2021, 11:05 AM
ThomasRaoux accepted this revision.Oct 11 2021, 12:23 PM
dcaballe updated this revision to Diff 378852.Oct 11 2021, 6:56 PM

Added support for 'xor'

dcaballe retitled this revision from [mlir][Linalg] Enable vectorization of 'mul', 'and' and 'or' reductions to [mlir][Linalg] Enable vectorization of 'mul', 'and', 'or' and 'xor' reductions.Oct 11 2021, 6:57 PM
dcaballe edited the summary of this revision. (Show Details)
aartbik accepted this revision.Oct 12 2021, 9:28 AM
pifon2a accepted this revision.Oct 12 2021, 1:33 PM

I think this is ready to be landed.

This revision was landed with ongoing or failed builds.Oct 12 2021, 2:10 PM
This revision was automatically updated to reflect the committed changes.