[analyzer][NFC] Add RangeSet::dump

[martong]

Summary

This tiny change improves the debugging experience of the solver a lot!

[steakhal]

Please mark both of them LLVM_DUMP_METHODs. This way they will be stripped from release builds according to their documentation.

[ASDenysPetrov]

In D110911#3035911, @steakhal wrote:

Please mark both of them LLVM_DUMP_METHODs. This way they will be stripped from release builds according to their documentation.

And Range::dump as well.

[martong]

• Rebase
• Mark the dump methods with LLVM_DUMP_METHOD
• Add Range::dump

[ASDenysPetrov]

LGTM

[martong]

Thanks for the reivew!

clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h

const llvm::APSInt *getConcreteValue() const {
     return &From() == &To() ? &From() : nullptr;
   }
 
   void Profile(llvm::FoldingSetNodeID &ID) const {
     ID.AddPointer(&From());
     ID.AddPointer(&To());
   }
   void dump(raw_ostream &OS) const;
+  void dump() const;
 
   // In order to keep non-overlapping ranges sorted, we can compare only From
   // points.
   bool operator<(const Range &RHS) const { return From() < RHS.From(); }
 
   bool operator==(const Range &RHS) const { return Impl == RHS.Impl; }
   bool operator!=(const Range &RHS) const { return !operator==(RHS); }
 
public:
 
   /// Test whether the given point is contained by any of the ranges.
   ///
   /// Complexity: O(logN)
   ///             where N = size(this)
   bool contains(llvm::APSInt Point) const { return containsImpl(Point); }
 
   void dump(raw_ostream &OS) const;
+  void dump() const;
 
   bool operator==(const RangeSet &Other) const { return *Impl == *Other.Impl; }
   bool operator!=(const RangeSet &Other) const { return !(*this == Other); }
 
 private:
   /* implicit */ RangeSet(ContainerType *RawContainer) : Impl(RawContainer) {}
   /* implicit */ RangeSet(UnderlyingType Ptr) : Impl(Ptr) {}
 

clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

RangeSet RangeSet::Factory::deletePoint(RangeSet From,
 
   ++Upper;
   --Lower;
 
   // Notice that the lower bound is greater than the upper bound.
   return intersect(From, Upper, Lower);
 }
 
-void Range::dump(raw_ostream &OS) const {
+LLVM_DUMP_METHOD void Range::dump(raw_ostream &OS) const {
   OS << '[' << toString(From(), 10) << ", " << toString(To(), 10) << ']';
 }
+LLVM_DUMP_METHOD void Range::dump() const { dump(llvm::errs()); }
 
-void RangeSet::dump(raw_ostream &OS) const {
+LLVM_DUMP_METHOD void RangeSet::dump(raw_ostream &OS) const {
   OS << "{ ";
   llvm::interleaveComma(*this, OS, [&OS](const Range &R) { R.dump(OS); });
   OS << " }";
 }
+LLVM_DUMP_METHOD void RangeSet::dump() const { dump(llvm::errs()); }
 
 REGISTER_SET_FACTORY_WITH_PROGRAMSTATE(SymbolSet, SymbolRef)
 
 namespace {
 class EquivalenceClass;
 } // end anonymous namespace
 
 REGISTER_MAP_WITH_PROGRAMSTATE(ClassMap, SymbolRef, EquivalenceClass)