This is an archive of the discontinued LLVM Phabricator instance.

Differential D110779

[RISCV] Require tail policy argument to builtins to be an integer constant expression
ClosedPublic

Authored by craig.topper on Sep 29 2021, 2:59 PM.

Details

Reviewers
HsiangKai
kito-cheng
khchen
arcbbb
Commits
rGa5c3508ac71b: [RISCV] Require tail policy argument to builtins to be an integer constant…
Summary

The IR intrinsics use ImmArg for the policy operand so this needs to be enforced as a constant in the frontend.

Diff Detail

Event Timeline

craig.topper created this revision.Sep 29 2021, 2:59 PM
Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr and 25 others. · View Herald TranscriptSep 29 2021, 2:59 PM
craig.topper requested review of this revision.Sep 29 2021, 2:59 PM
Herald added a subscriber: MaskRay. · View Herald TranscriptSep 29 2021, 2:59 PM
Harbormaster completed remote builds in B126448: Diff 376045.Sep 29 2021, 3:40 PM
HsiangKai accepted this revision.Sep 29 2021, 7:56 PM

LGTM.

This revision is now accepted and ready to land.Sep 29 2021, 7:56 PM
This revision was landed with ongoing or failed builds.Oct 11 2021, 9:55 AM
Closed by commit rGa5c3508ac71b: [RISCV] Require tail policy argument to builtins to be an integer constant… (authored by craig.topper). · Explain Why
This revision was automatically updated to reflect the committed changes.
craig.topper added a commit: rGa5c3508ac71b: [RISCV] Require tail policy argument to builtins to be an integer constant….
Herald added a project: Restricted Project. · View Herald TranscriptOct 11 2021, 9:55 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
utils/
TableGen/
2 lines

Diff 378710

clang/utils/TableGen/RISCVVEmitter.cpp

Show First 20 Lines • Show All 1,178 Lines • ▼ Show 20 Lines for (auto *R : RV) {
} }
// If HasVL, append 'z' to the operand list. // If HasVL, append 'z' to the operand list.
if (HasVL) { if (HasVL) {
ProtoSeq.push_back("z"); ProtoSeq.push_back("z");
ProtoMaskSeq.push_back("z"); ProtoMaskSeq.push_back("z");
} }
if (HasPolicy) { if (HasPolicy) {
ProtoMaskSeq.push_back("z"); ProtoMaskSeq.push_back("Kz");
} }
// Create Intrinsics for each type and LMUL. // Create Intrinsics for each type and LMUL.
for (char I : TypeRange) { for (char I : TypeRange) {
for (int Log2LMUL : Log2LMULList) { for (int Log2LMUL : Log2LMULList) {
Optional<RVVTypes> Types = computeTypes(I, Log2LMUL, NF, ProtoSeq); Optional<RVVTypes> Types = computeTypes(I, Log2LMUL, NF, ProtoSeq);
// Ignored to create new intrinsic if there are any illegal types. // Ignored to create new intrinsic if there are any illegal types.
if (!Types.hasValue()) if (!Types.hasValue())
▲ Show 20 Lines • Show All 126 Lines • Show Last 20 Lines