This is an archive of the discontinued LLVM Phabricator instance.

[fir] Move parser/printer/verifier of fir.string_lit and add builders
ClosedPublic

Authored by clementval on Sep 29 2021, 1:25 AM.

Details

Summary

Move the parser, printer and verifier to the .cpp file. Add builders
needed for lowering.

This patch is part of the upstreaming effort from fir-dev branch.

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>

Diff Detail

Event Timeline

clementval created this revision.Sep 29 2021, 1:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2021, 1:25 AM
clementval requested review of this revision.Sep 29 2021, 1:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2021, 1:25 AM
mehdi_amini added inline comments.Sep 29 2021, 10:22 AM
flang/include/flang/Optimizer/Dialect/FIROps.td
2785

Nit: inType for consistency between declaration and definition.

mehdi_amini accepted this revision.Sep 29 2021, 10:22 AM
This revision is now accepted and ready to land.Sep 29 2021, 10:22 AM
clementval marked an inline comment as done.

Address nit comment

flang/include/flang/Optimizer/Dialect/FIROps.td
2785

Good catch! Thanks for the review.

schweitz accepted this revision.Sep 29 2021, 12:38 PM