This is an archive of the discontinued LLVM Phabricator instance.

[TargetLibraryInfo] Pick new/delete calls by target
ClosedPublic

Authored by probinson on Sep 24 2021, 7:24 AM.

Details

Summary

There are two sets of new/delete functions, one with Windows/MSVC
mangling and one with Itanium mangling. Mark one set or the other
as unavailable depending on the target.

Diff Detail

Event Timeline

probinson created this revision.Sep 24 2021, 7:24 AM
probinson requested review of this revision.Sep 24 2021, 7:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2021, 7:24 AM
rnk added inline comments.Sep 24 2021, 10:47 AM
llvm/test/Transforms/InstCombine/malloc-free-delete.ll
2

For the C APIs (malloc, calloc, free), I would like this test to remain target-neutral. Do you mind splitting it into malloc-free.ll, new-delete-itanium.ll, new-delete-msvc.ll? The second two get triples, the first retains the C-only parts of the test.

probinson updated this revision to Diff 374959.Sep 24 2021, 2:19 PM

Split test into 3 parts.

rnk accepted this revision.Sep 27 2021, 3:20 PM

lgtm

This revision is now accepted and ready to land.Sep 27 2021, 3:20 PM
This revision was landed with ongoing or failed builds.Sep 28 2021, 10:11 AM
This revision was automatically updated to reflect the committed changes.