This is an archive of the discontinued LLVM Phabricator instance.

[SelectionDAG] Make WidenVecRes_SELECT work for scalable vectors
ClosedPublic

Authored by tangxingxin1008 on Sep 24 2021, 12:38 AM.

Details

Summary
This change make WidenVecRes_SELECT work for scalable vectors.

This patch is split from [D110319](https://reviews.llvm.org/D110319)

Signed-off-by: Eric Tang <tangxingxin1008@gmail.com>

Diff Detail

Event Timeline

tangxingxin1008 requested review of this revision.Sep 24 2021, 12:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2021, 12:38 AM
david-arm added inline comments.Sep 24 2021, 6:22 AM
llvm/test/CodeGen/AArch64/sve-select.ll
234

Would you mind also adding a test for the case when the condition is a vector that needs widening, i.e.

%sel = select <vscale x 1 x i1> %p, <vscale x 1 x i64> %a, <vscale x 1 x i64> %dst
ret <vscale x 1 x i64> %sel

Address david-arm's comments and add more tests.

llvm/test/CodeGen/AArch64/sve-select.ll
234

Addressed your comments.

This revision is now accepted and ready to land.Oct 1 2021, 12:39 AM
tangxingxin1008 reopened this revision.Nov 16 2021, 2:52 AM

Sorry, I don't know how to merged this patch, and get a wrong way to close this revision. Please forgive me for my mistake.

This revision is now accepted and ready to land.Nov 16 2021, 2:52 AM

Sorry, I don't know how to merged this patch, and get a wrong way to close this revision.

To merge a patch you'll need to request commit access to LLVM (see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access) so that you can do git push. This then closes the revision in Phabricator automatically.

If you don't have commit access yet, I'd be happy to commit the patch for you.

Sorry, I don't know how to merged this patch, and get a wrong way to close this revision.

To merge a patch you'll need to request commit access to LLVM (see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access) so that you can do git push. This then closes the revision in Phabricator automatically.

If you don't have commit access yet, I'd be happy to commit the patch for you.

Thank you very much, @sdesmalen , I don't have the commit access, please help me.

This revision was landed with ongoing or failed builds.Nov 17 2021, 12:56 AM
This revision was automatically updated to reflect the committed changes.