Differential D110179

[NFC][IR] Remove unused assignment to Offset
AcceptedPublic
Actions

Authored by gAlfonso-bit on Sep 21 2021, 8:15 AM.

Tags

Subscribers

Details

Reviewers

dexonsmith
jeroen.dobbelaere
hiraditya

Summary

This value is overwritten anyway, so let's remove it

Diff Detail

Event Timeline

gAlfonso-bit created this revision.Sep 21 2021, 8:15 AM

Herald added subscribers: dexonsmith, hiraditya. · View Herald TranscriptSep 21 2021, 8:15 AM

gAlfonso-bit requested review of this revision.Sep 21 2021, 8:15 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2021, 8:15 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

gAlfonso-bit added a reviewer: dexonsmith.Sep 21 2021, 8:15 AM

Use correct data type

gAlfonso-bit updated this revision to Diff 373947.Sep 21 2021, 8:37 AM

Harbormaster completed remote builds in B124928: Diff 373947.Sep 21 2021, 9:06 AM

gAlfonso-bit added a reviewer: ldionne.Sep 21 2021, 9:40 AM

gAlfonso-bit added a reviewer: MaskRay.Sep 21 2021, 12:52 PM

gAlfonso-bit set the repository for this revision to rG LLVM Github Monorepo.

I'm not certain how you selected the reviewers, but I am not the right person to review this. Feel free to add me on libc++ and libc++abi reviews or Clang driver reviews that have something to do with the standard library, but I've never touched this code.

MaskRay resigned from this revision.Sep 23 2021, 2:45 PM

gAlfonso-bit edited reviewers, added: jeroen.dobbelaere, hiraditya; removed: ldionne, MaskRay.Sep 25 2021, 6:02 AM

LGTM.

This revision is now accepted and ready to land.Jan 16 2022, 11:02 PM

Revision Contents
Changeset List

Path

Size

llvm/

lib/

IR/

8 lines

Diff 373947

llvm/lib/IR/Operator.cpp

Loading...