[NFC][IR] Remove unused assignment to Offset

[gAlfonso-bit]

Summary

This value is overwritten anyway, so let's remove it

[gAlfonso-bit]

Use correct data type

[ldionne]

I'm not certain how you selected the reviewers, but I am not the right person to review this. Feel free to add me on libc++ and libc++abi reviews or Clang driver reviews that have something to do with the standard library, but I've never touched this code.

[hiraditya]

LGTM.

[gAlfonso-bit]

Any updates on this?

[gAlfonso-bit]

Rebased

[gAlfonso-bit]

Note: I am unable to commit this directly. If you can, please do so for me

Using the email [e-mail]

and name Alfonso Gregory

[arsenm]

dd50e26f8a844aa7dc9908b94bce66188c4d4e91

llvm/lib/IR/Operator.cpp

 
 Align GEPOperator::getMaxPreservedAlignment(const DataLayout &DL) const {
   /// compute the worse possible offset for every level of the GEP et accumulate
   /// the minimum alignment into Result.
 
   Align Result = Align(llvm::Value::MaximumAlignment);
   for (gep_type_iterator GTI = gep_type_begin(this), GTE = gep_type_end(this);
        GTI != GTE; ++GTI) {
-    int64_t Offset = 1;
+    uint64_t Offset;
     ConstantInt *OpC = dyn_cast<ConstantInt>(GTI.getOperand());
 
     if (StructType *STy = GTI.getStructTypeOrNull()) {
       const StructLayout *SL = DL.getStructLayout(STy);
       Offset = SL->getElementOffset(OpC->getZExtValue());
     } else {
       assert(GTI.isSequential() && "should be sequencial");
-      /// If the index isn't know we take 1 because it is the index that will
+      /// If the index isn't known, we take 1 because it is the index that will
       /// give the worse alignment of the offset.
-      int64_t ElemCount = 1;
-      if (OpC)
-        ElemCount = OpC->getZExtValue();
+      const uint64_t ElemCount = OpC ? OpC->getZExtValue() : 1;
       Offset = DL.getTypeAllocSize(GTI.getIndexedType()) * ElemCount;
     }
     Result = Align(MinAlign(Offset, Result.value()));
   }
   return Result;
 }
 
 bool GEPOperator::accumulateConstantOffset(