[mlir] Clean up boolean flags usage in LIT tests

[vinograd47]

Summary

• Call llvm_canonicalize_cmake_booleans for all CMake options, which are propagated to lit.local.cfg files.
• Use Python native boolean values instead of strings for such options.

This fixes the cases, when CMake variables have values other than ON (like TRUE).
This might happen due to IDE integration or due to CMake preset usage.

[vinograd47]

Fix llvm_canonicalize_cmake_booleans usage

[vinograd47]

@mehdi_amini @rriddle @ftynse @aartbik @nicolasvasilache @herhut Gentle reminder, could you please take a look at this patch?

[ftynse]

Looks good, thanks!

[mehdi_amini]

Sorry, I missed this originally.
LGTM, thanks!

mlir/test/CMakeLists.txt

 add_subdirectory(CAPI)
 add_subdirectory(lib)
 
-llvm_canonicalize_cmake_booleans(
-  MLIR_ENABLE_BINDINGS_PYTHON
-  LLVM_BUILD_EXAMPLES
-  MLIR_ENABLE_CUDA_CONVERSIONS
-  MLIR_ENABLE_CUDA_RUNNER
-  MLIR_ENABLE_ROCM_CONVERSIONS
-  MLIR_ENABLE_ROCM_RUNNER
-  MLIR_ENABLE_SPIRV_CPU_RUNNER
-  MLIR_ENABLE_VULKAN_RUNNER
-  )
-
 # Passed to lit.site.cfg.py.so that the out of tree Standalone dialect test
 # can find MLIR's CMake configuration
 set(MLIR_CMAKE_DIR
   "${CMAKE_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/cmake/mlir")
 
 # Passed to lit.site.cfg.py.in to set up the path where to find the libraries
 # for linalg integration tests.
 set(MLIR_DIALECT_LINALG_INTEGRATION_TEST_LIB_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
if (MLIR_INCLUDE_INTEGRATION_TESTS)
   file(COPY ${CMAKE_CURRENT_SOURCE_DIR}/Integration/data/mttkrp_b.tns
             ${CMAKE_CURRENT_SOURCE_DIR}/Integration/data/test.mtx
             ${CMAKE_CURRENT_SOURCE_DIR}/Integration/data/test.tns
             ${CMAKE_CURRENT_SOURCE_DIR}/Integration/data/wide.mtx
             ${CMAKE_CURRENT_SOURCE_DIR}/Integration/data/zero.mtx
           DESTINATION ${MLIR_INTEGRATION_TEST_DIR}/data/)
 endif()
 
+llvm_canonicalize_cmake_booleans(
+  LLVM_BUILD_EXAMPLES
+  MLIR_ENABLE_BINDINGS_PYTHON
+  MLIR_ENABLE_CUDA_CONVERSIONS
+  MLIR_ENABLE_CUDA_RUNNER
+  MLIR_ENABLE_ROCM_CONVERSIONS
+  MLIR_ENABLE_ROCM_RUNNER
+  MLIR_ENABLE_SPIRV_CPU_RUNNER
+  MLIR_ENABLE_VULKAN_RUNNER
+  MLIR_INCLUDE_INTEGRATION_TESTS
+  MLIR_RUN_AMX_TESTS
+  MLIR_RUN_CUDA_TENSOR_CORE_TESTS
+  MLIR_RUN_X86VECTOR_TESTS
+  )
+
 configure_lit_site_cfg(
   ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in
   ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg.py
   MAIN_CONFIG
   ${CMAKE_CURRENT_SOURCE_DIR}/lit.cfg.py
   )
 configure_lit_site_cfg(
   ${CMAKE_CURRENT_SOURCE_DIR}/Unit/lit.site.cfg.py.in

mlir/test/Integration/Dialect/Vector/CPU/AMX/lit.local.cfg

 import sys
 
 # AMX tests must be enabled via build flag.
-if config.mlir_run_amx_tests != 'ON':
+if not config.mlir_run_amx_tests:
     config.unsupported = True
 
 # No JIT on win32.
 if sys.platform == 'win32':
     config.unsupported = True
 
 if config.intel_sde_executable:
     # Run test in emulator (Intel SDE): AMX needs Sapphire Rapids CPU.
     config.substitutions.append(('%lli', config.intel_sde_executable + ' -spr -- lli'))
 else:
     config.substitutions.append(('%lli', 'lli'))

mlir/test/Integration/Dialect/Vector/CPU/X86Vector/lit.local.cfg

 import sys
 
 # X86Vector tests must be enabled via build flag.
-if config.mlir_run_x86vector_tests != 'ON':
+if not config.mlir_run_x86vector_tests:
     config.unsupported = True
 
 # No JIT on win32.
 if sys.platform == 'win32':
     config.unsupported = True
 
 if config.intel_sde_executable:
     # Run test in emulator (Intel SDE).
     config.substitutions.append(('%lli', config.intel_sde_executable + ' -tgl -- lli'))
 else:
     config.substitutions.append(('%lli', 'lli'))

mlir/test/Integration/GPU/CUDA/TensorCore/lit.local.cfg

 import sys
 
 # TensorCore tests must be enabled via build flag.
-if config.mlir_run_cuda_tensor_core_tests != 'ON':
+if not config.mlir_run_cuda_tensor_core_tests:
   config.unsupported = True

mlir/test/Integration/lit.local.cfg

-if config.mlir_include_integration_tests != 'ON':
+if not config.mlir_include_integration_tests:
     config.unsupported = True

mlir/test/lit.site.cfg.py.in

 config.enable_rocm_runner = @MLIR_ENABLE_ROCM_RUNNER@
 config.spirv_wrapper_library_dir = "@MLIR_SPIRV_WRAPPER_LIBRARY_DIR@"
 config.enable_spirv_cpu_runner = @MLIR_ENABLE_SPIRV_CPU_RUNNER@
 config.vulkan_wrapper_library_dir = "@MLIR_VULKAN_WRAPPER_LIBRARY_DIR@"
 config.enable_vulkan_runner = @MLIR_ENABLE_VULKAN_RUNNER@
 config.enable_bindings_python = @MLIR_ENABLE_BINDINGS_PYTHON@
 config.mlir_integration_test_dir = "@MLIR_INTEGRATION_TEST_DIR@"
 config.intel_sde_executable = "@INTEL_SDE_EXECUTABLE@"
-config.mlir_run_amx_tests = "@MLIR_RUN_AMX_TESTS@"
-config.mlir_run_x86vector_tests = "@MLIR_RUN_X86VECTOR_TESTS@"
-config.mlir_run_cuda_tensor_core_tests = "@MLIR_RUN_CUDA_TENSOR_CORE_TESTS@"
-config.mlir_include_integration_tests = "@MLIR_INCLUDE_INTEGRATION_TESTS@"
+config.mlir_run_amx_tests = @MLIR_RUN_AMX_TESTS@
+config.mlir_run_x86vector_tests = @MLIR_RUN_X86VECTOR_TESTS@
+config.mlir_run_cuda_tensor_core_tests = @MLIR_RUN_CUDA_TENSOR_CORE_TESTS@
+config.mlir_include_integration_tests = @MLIR_INCLUDE_INTEGRATION_TESTS@
 
 # Support substitution of the tools_dir with user parameters. This is
 # used when we can't determine the tool dir at configuration time.
 try:
     config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
     config.llvm_lib_dir = config.llvm_lib_dir % lit_config.params
     config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params
 except KeyError:

mlir/test/python/integration/lit.local.cfg

-if config.mlir_include_integration_tests != 'ON':
+if not config.mlir_include_integration_tests:
     config.unsupported = True