Page MenuHomePhabricator

[mlir] Clean up boolean flags usage in LIT tests
ClosedPublic

Authored by vinograd47 on Sep 20 2021, 7:36 AM.

Details

Summary
  • Call llvm_canonicalize_cmake_booleans for all CMake options, which are propagated to lit.local.cfg files.
  • Use Python native boolean values instead of strings for such options.

This fixes the cases, when CMake variables have values other than ON (like TRUE).
This might happen due to IDE integration or due to CMake preset usage.

Diff Detail

Event Timeline

vinograd47 created this revision.Sep 20 2021, 7:36 AM
vinograd47 requested review of this revision.Sep 20 2021, 7:36 AM

Fix llvm_canonicalize_cmake_booleans usage

@mehdi_amini @rriddle @ftynse @aartbik @nicolasvasilache @herhut Gentle reminder, could you please take a look at this patch?

ftynse accepted this revision.Mon, Oct 11, 8:26 AM

Looks good, thanks!

This revision is now accepted and ready to land.Mon, Oct 11, 8:26 AM

Sorry, I missed this originally.
LGTM, thanks!

This revision was automatically updated to reflect the committed changes.