Page MenuHomePhabricator

[libunwind][ARM] Handle end of stack during unwind
ClosedPublic

Authored by danielkiss on Sep 15 2021, 2:39 PM.

Details

Reviewers
cjdb
manojgupta
MaskRay
compnerd
mstorsjo
Group Reviewers
Restricted Project
Restricted Project
Commits
rG632acec73776: [libunwind][ARM] Handle end of stack during unwind
Summary

When unwind step reaches the end of the stack that means the force unwind should notify the stop function.
This is not an error, it could mean just the thread is cleaned up completely.

Diff Detail

Event Timeline

danielkiss created this revision.Sep 15 2021, 2:39 PM
danielkiss requested review of this revision.Sep 15 2021, 2:39 PM
danielkiss retitled this revision from [libunwind][ARM] Fix _Unwind_ForcedUnwind to [libunwind][ARM] Handle end of stack during unwind.
danielkiss edited the summary of this revision. (Show Details)
danielkiss edited the summary of this revision. (Show Details)
danielkiss added reviewers: Restricted Project, Restricted Project.

Rerun clang-format.

Make the CI happy.

Looks reasonable I think. Is this a deficiency in the EHABI implementation only, i.e. this aspect works as it should in the regular dwarf implementation?

Looks reasonable I think. Is this a deficiency in the EHABI implementation only, i.e. this aspect works as it should in the regular dwarf implementation?

Yes, it works on dwarf already ( also the test pass on X86/Aarch64 ).

mstorsjo accepted this revision.Fri, Nov 26, 3:46 AM

Looks reasonable I think. Is this a deficiency in the EHABI implementation only, i.e. this aspect works as it should in the regular dwarf implementation?

Yes, it works on dwarf already ( also the test pass on X86/Aarch64 ).

Ok, thanks for the clarification!

This revision is now accepted and ready to land.Fri, Nov 26, 3:46 AM
This revision was automatically updated to reflect the committed changes.
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFri, Nov 26, 4:26 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript