Page MenuHomePhabricator

manojgupta (Manoj Gupta)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2016, 10:04 PM (197 w, 17 h)

Recent Activity

Fri, Sep 4

manojgupta accepted D87143: Check whether Gentoo-specific configuration directory exists.

Looks ok to me.

Fri, Sep 4, 11:18 AM · Restricted Project
manojgupta added a reviewer for D87143: Check whether Gentoo-specific configuration directory exists: mgorny.
Fri, Sep 4, 9:43 AM · Restricted Project

Fri, Aug 28

manojgupta updated subscribers of D86762: [ELF] Add documentation for --warn-backrefs: a GNU ld compatibility checking tool (and lesser of layering detection).

--warn-backrefs-exclude='*' disables all warnings. We may need --no-warn-backrefs if it is more like the option users want to use. If you are happy to try out, I'd happy to know whether ChromeOS packages have no warnings if --warn-backrefs is added (--fatal-warnings upgrade warnings to errors).

Fri, Aug 28, 11:24 AM · Restricted Project
manojgupta added a comment to D86762: [ELF] Add documentation for --warn-backrefs: a GNU ld compatibility checking tool (and lesser of layering detection).

@MaskRay Is there a global option to disable e.g --no-warn-backrefs . It is not easy for us to add -warn-backrefs-exclude=<glob> individually to all packages where we need to suppress the error.

Fri, Aug 28, 9:06 AM · Restricted Project

Jun 1 2020

manojgupta added a comment to D80870: [LV] Make sure smallest/widest type sizes are powers-of-2..

D80491 has been breaking our ToT builds for a week now. Can this be submitted soon. If not please consider reverting D80491.

Jun 1 2020, 11:19 AM · Restricted Project

Apr 28 2020

manojgupta added a comment to D78862: [IR] Convert null-pointer-is-valid into an enum attribute.

@nikic Thanks for the work.

Apr 28 2020, 2:34 PM · Restricted Project, Restricted Project
manojgupta added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

@manojgupta can you give a build recipe? None of the buildbots are failing.

Apr 28 2020, 2:02 PM · Restricted Project
manojgupta added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

Hi @manojgupta. I am not familiar enough with this piece of code to understand whether it could be fixed by simply using any other general-purpose register instead of r7.

Can you request it to someone more accustomed to compiler-rt?

Apr 28 2020, 10:11 AM · Restricted Project
manojgupta updated subscribers of D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

@vhscampos This change is more restrictive than GCC. e.g. https://godbolt.org/z/wP8_ic where clang errors out but GCC does not error out.

Apr 28 2020, 9:38 AM · Restricted Project

Apr 26 2020

manojgupta added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

I believe chromium's version is a copy of compiler-rt's implementation of clear_cache [1] .
@vhscampos Can you please fix compiler-rt version as well?

Apr 26 2020, 3:11 AM · Restricted Project

Apr 7 2020

manojgupta added a comment to D71082: Allow system header to provide their own implementation of some builtin.

I opened https://github.com/ClangBuiltLinux/linux/issues/979 to see if we can fix this in Linux kernel.

Apr 7 2020, 12:31 PM · Restricted Project

Apr 2 2020

manojgupta added a comment to D71082: Allow system header to provide their own implementation of some builtin.

Yes, it'd be nice if all of the FORTIFY handling can be improved. For a simple call like memcpy of 8 bytes in the example, there is no reason to emit all these stack/range checks since they'd degrade memcpy performance.

Apr 2 2020, 6:27 PM · Restricted Project

Apr 1 2020

manojgupta updated subscribers of D67900: [libc++] Use builtin type traits whenever possible.

Copying an email reply to phab thread from @EricWF , not sure why it did not make it here.

Apr 1 2020, 10:26 AM · Restricted Project

Mar 31 2020

manojgupta added a comment to D71082: Allow system header to provide their own implementation of some builtin.

Unfortunately, cherry-picking the kernel patches didn't work including latest memcpy for x86 (https://github.com/torvalds/linux/commit/170d13ca3a2fdaaa0283399247631b76b441cca2 and https://github.com/torvalds/linux/commit/c228d294f2040c3a5f5965ff04d4947d0bf6e7da ).
Also tried ToT Linux kernel but still the same problem.

Mar 31 2020, 10:00 PM · Restricted Project
manojgupta updated subscribers of D71082: Allow system header to provide their own implementation of some builtin.

I was able to reduce to following:

Mar 31 2020, 8:22 PM · Restricted Project
manojgupta added a comment to D71082: Allow system header to provide their own implementation of some builtin.

Sure, I am trying to root cause the issue. Will report back hopefully soon.

Mar 31 2020, 3:59 PM · Restricted Project
manojgupta added a comment to D71082: Allow system header to provide their own implementation of some builtin.

We believe this change (relanded as https://reviews.llvm.org/rGd437fba8ef626b6d8b7928540f630163a9b04021) is causing a mis-compile in Linux kernel 4.4 builds resulting in local test failures.
Chrome OS bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1066638

Mar 31 2020, 2:52 PM · Restricted Project
manojgupta accepted D62627: [NFC] Do not run CGProfilePass when not using integrated assembler.
Mar 31 2020, 9:24 AM · Restricted Project, Restricted Project

Mar 23 2020

manojgupta added a comment to D62627: [NFC] Do not run CGProfilePass when not using integrated assembler.

Noticed a few typos. Rest lgtm but deferring to other reviewers for now for approval.

Mar 23 2020, 2:11 PM · Restricted Project, Restricted Project

Mar 20 2020

manojgupta added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

Thanks for the quick fix, verified that the crash is fixed on trunk.

Mar 20 2020, 11:55 AM · Restricted Project, Restricted Project, Restricted Project, debug-info
manojgupta added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

Still causing a crash using a previously supplied test https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c7. Any reason this was not tested with a previous repro?

Mar 20 2020, 10:17 AM · Restricted Project, Restricted Project, Restricted Project, debug-info

Mar 18 2020

manojgupta added a comment to D48680: Add missing visibility annotation for __base.

Thanks a lot!

Mar 18 2020, 3:13 PM · Restricted Project
manojgupta added a comment to D48680: Add missing visibility annotation for __base.

Friendly ping @pcc and @ldionne . We have been carrying this patch I think for too long now.
Also, we have not discovered any LTO issues elsewhere so can't tell from our side if there are other places in libc++ that need visibility annotations.

Mar 18 2020, 1:35 PM · Restricted Project

Mar 17 2020

manojgupta updated subscribers of D62627: [NFC] Do not run CGProfilePass when not using integrated assembler.
Mar 17 2020, 8:31 AM · Restricted Project, Restricted Project

Mar 13 2020

manojgupta added a comment to D76164: Fix an assertion error when emitting call site info that combines two DW_OP_stack_values..

Can you also test on the reduced test cases in https://bugs.llvm.org/show_bug.cgi?id=45181 ?

Mar 13 2020, 3:40 PM · Restricted Project, debug-info

Mar 12 2020

manojgupta added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

I see another crash with this change when building gdb.

Mar 12 2020, 2:19 AM · Restricted Project, Restricted Project, Restricted Project, debug-info

Mar 6 2020

manojgupta added a comment to D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast.

Thanks, Verified that this fixes the kernel warnings in my local builds with https://gist.github.com/nathanchance/767cccf4d093c1342e1994083518815e!

Mar 6 2020, 12:08 PM · Restricted Project

Mar 4 2020

manojgupta accepted D75065: [cmake] Strip quotes in compiler-rt/lib/crt and explicitly throw error if check executable fails.
Mar 4 2020, 2:41 PM · Restricted Project, Restricted Project

Feb 27 2020

manojgupta updated subscribers of D75238: [DAGCombine] Fix alias analysis for unaligned accesses.
Feb 27 2020, 11:34 AM · Restricted Project

Feb 24 2020

manojgupta added a reviewer for D75065: [cmake] Strip quotes in compiler-rt/lib/crt and explicitly throw error if check executable fails: phosek.
Feb 24 2020, 11:07 AM · Restricted Project, Restricted Project

Feb 18 2020

manojgupta added a reviewer for D74698: [Driver] -pg -mfentry should respect target specific decisions for -mframe-pointer=all: hfinkel.
Feb 18 2020, 10:35 AM · Restricted Project

Feb 5 2020

manojgupta added a comment to D74039: Make llvm::crc32() work also for input sizes larger than 32 bits..

Thanks, should this be cherry picked to 11.0 release as well?

Feb 5 2020, 1:21 PM · Restricted Project

Oct 10 2019

manojgupta added inline comments to D68764: [ARM][AsmParser] handles offset expression in parentheses.
Oct 10 2019, 1:16 PM · Restricted Project

Sep 30 2019

manojgupta updated subscribers of rL373168: [MC] Emit unused undefined symbol even if its binding is not set.

Opened PR43518 with repro instructions.

Sep 30 2019, 5:33 PM
manojgupta added a comment to rL373168: [MC] Emit unused undefined symbol even if its binding is not set.

Heads up: This is causing an error when building Chrome on ARM32 (Thumb2):

Sep 30 2019, 5:17 PM

Sep 13 2019

manojgupta committed rG41d9d5092a17: Reland r371785: Add -Wpoison-system-directories warning (authored by manojgupta).
Reland r371785: Add -Wpoison-system-directories warning
Sep 13 2019, 11:00 AM
manojgupta committed rL371878: Reland r371785: Add -Wpoison-system-directories warning.
Reland r371785: Add -Wpoison-system-directories warning
Sep 13 2019, 11:00 AM

Sep 12 2019

manojgupta committed rG38f6b3fd8dd7: Revert r371785. (authored by manojgupta).
Revert r371785.
Sep 12 2019, 5:33 PM
manojgupta committed rL371799: Revert r371785..
Revert r371785.
Sep 12 2019, 5:33 PM
manojgupta closed D52524: Add -Wpoison-system-directories warning.

Submitted as https://reviews.llvm.org/rL371785.
Thanks for the patch!

Sep 12 2019, 3:50 PM · Restricted Project
manojgupta committed rG4fe273216190: Add -Wpoison-system-directories warning (authored by manojgupta).
Add -Wpoison-system-directories warning
Sep 12 2019, 3:41 PM
manojgupta committed rL371785: Add -Wpoison-system-directories warning.
Add -Wpoison-system-directories warning
Sep 12 2019, 3:41 PM

Sep 4 2019

manojgupta added a comment to D67090: [llvm-objcopy][llvm-strip] Support --only-keep-debug.

Thanks for working on it. Have you tested if Linux perf can symbolize the perf traces using the split debug files especially with large binaries?

Sep 4 2019, 4:15 AM · Restricted Project

Aug 23 2019

manojgupta committed rG30232770fbe5: Revert r369233. (authored by manojgupta).
Revert r369233.
Aug 23 2019, 11:04 AM
manojgupta committed rL369790: Revert r369233..
Revert r369233.
Aug 23 2019, 11:04 AM

Aug 21 2019

manojgupta updated subscribers of rL369233: [MC] Don't emit .symver redirected symbols to the symbol table.

Hi Fangrui,

Aug 21 2019, 3:05 PM

Aug 19 2019

manojgupta added reviewers for D52524: Add -Wpoison-system-directories warning: rtrieu, aaron.ballman.

Adding a few more reviewers since I am not very familiar with this part of clang.
Please also update the patch description as suggested by @thakis

Aug 19 2019, 12:10 PM · Restricted Project
manojgupta added inline comments to D52524: Add -Wpoison-system-directories warning.
Aug 19 2019, 10:51 AM · Restricted Project

Aug 14 2019

manojgupta added inline comments to D52524: Add -Wpoison-system-directories warning.
Aug 14 2019, 8:20 PM · Restricted Project
manojgupta added a comment to D52524: Add -Wpoison-system-directories warning.

Wouldn't those projects just move to also disabling the warning by passing -Wno-poison-system-directories? If there are projects that are actively adding -I/usr/include, that means they're consciously fighting the build system and you've kind of already lost, no? Can't you tell them to not use -I/usr/include?

Aug 14 2019, 7:59 PM · Restricted Project
manojgupta added a comment to D52524: Add -Wpoison-system-directories warning.

Couldn't cross build users just pass -nostdsysteminc to tell clang to not look in system header locations?

Aug 14 2019, 4:15 PM · Restricted Project

Aug 3 2019

manojgupta updated subscribers of D65019: [ARM] push LR before __gnu_mcount_nc.
Aug 3 2019, 10:52 AM · Restricted Project, Restricted Project

Jul 16 2019

manojgupta added a comment to D48680: Add missing visibility annotation for __base.

@pcc can you please submit this patch if there are no objections?

Jul 16 2019, 10:47 AM · Restricted Project

Jul 15 2019

manojgupta added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

@dankm are you still working on this patch?

Jul 15 2019, 11:32 AM · Restricted Project, Restricted Project, Restricted Project

Jun 24 2019

manojgupta added a comment to D48680: Add missing visibility annotation for __base.

@ldionne Does Peter's example answer your questions?

Jun 24 2019, 1:28 PM · Restricted Project

May 29 2019

manojgupta added inline comments to D62627: [NFC] Do not run CGProfilePass when not using integrated assembler.
May 29 2019, 2:41 PM · Restricted Project, Restricted Project

May 28 2019

manojgupta added a comment to D48680: Add missing visibility annotation for __base.

Hi Peter and Marshall,

May 28 2019, 11:54 AM · Restricted Project

Apr 10 2019

manojgupta added a comment to D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64.
Apr 10 2019, 8:04 AM · Restricted Project
manojgupta added a comment to D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64.
Apr 10 2019, 8:00 AM · Restricted Project
manojgupta added a comment to D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64.

The motivation for this change is to make "crypto" setting an additive option e.g. like "-mavx" used in many media packages. Some packages in Chrome want to enable crypto conditionally for a few files to allow crypto feature to be used based on runtime cpu detection. They set "-march=armv8+crypto" flag but it gets overridden by the global "-march=armv8a" flag set by the build system in Chrome OS because the target cpu does not support crypto causing compile-time errors.
Ability to specify "-mcrypto" standalone makes it an additive option and ensures that it it is not lost. i.e. this will help in decoupling "-mcrypto" from "-march" so that they could be set independently. The current additive alternate is '-Xclang -target-feature -Xclang "+crypto" ' which is ugly.

Apr 10 2019, 7:37 AM · Restricted Project

Apr 9 2019

manojgupta added inline comments to D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64.
Apr 9 2019, 11:03 AM · Restricted Project

Mar 13 2019

manojgupta added inline comments to D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux.
Mar 13 2019, 4:14 PM · Restricted Project, Restricted Project
manojgupta updated subscribers of D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux.
Mar 13 2019, 1:55 PM · Restricted Project, Restricted Project

Mar 9 2019

manojgupta added a comment to D53608: [builtins] Build float128 soft float builtins for x86_64..

Hi
What's the status for __float128 support? Has it already been finished?

Mar 9 2019, 8:37 AM · Restricted Project, Restricted Project

Nov 14 2018

manojgupta added a comment to D54487: Implement llvm.commandline named metadata.

Yes, but that is somewhat different. The "-g" option seems to just append the command line to the producer string, yes? It is harder to parse out later and it can be stripped out. gcc has both -g and -f forms.

Nov 14 2018, 12:52 PM

Nov 13 2018

manojgupta added a comment to D54487: Implement llvm.commandline named metadata.

Doesn't clang already has -grecord-gcc-switches option (https://clang.llvm.org/docs/ClangCommandLineReference.html#debug-information-flags) ?

Nov 13 2018, 6:37 PM

Oct 24 2018

manojgupta added a comment to D53608: [builtins] Build float128 soft float builtins for x86_64..

Took another look and seems like long double is hardcoded in many of the builtins. So I think the current patch needs to rename a lot of places using long double to __float128 type.

Oct 24 2018, 1:35 PM · Restricted Project, Restricted Project

Oct 23 2018

manojgupta added a comment to D53608: [builtins] Build float128 soft float builtins for x86_64..

I am also getting these tests failures because of missing trunctfxf2 and extendxftf2. These are provided by libgcc but compiler-rt does not seem to have an implementation for them.

Oct 23 2018, 3:17 PM · Restricted Project, Restricted Project
manojgupta added inline comments to D53608: [builtins] Build float128 soft float builtins for x86_64..
Oct 23 2018, 2:53 PM · Restricted Project, Restricted Project
manojgupta updated the diff for D53608: [builtins] Build float128 soft float builtins for x86_64..

Added checked for defined(FLOAT128) || defined(SIZEOF_FLOAT128)

Oct 23 2018, 2:50 PM · Restricted Project, Restricted Project
manojgupta added inline comments to D53608: [builtins] Build float128 soft float builtins for x86_64..
Oct 23 2018, 1:42 PM · Restricted Project, Restricted Project
manojgupta created D53608: [builtins] Build float128 soft float builtins for x86_64..
Oct 23 2018, 1:38 PM · Restricted Project, Restricted Project

Sep 26 2018

manojgupta added a reviewer for D52524: Add -Wpoison-system-directories warning: rsmith.
Sep 26 2018, 11:14 AM · Restricted Project

Sep 20 2018

manojgupta added a comment to D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs.

lgtm. But someone more familiar with these code paths should approve.

Sep 20 2018, 1:15 PM

Sep 19 2018

manojgupta added a comment to D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs.

As per https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80868, I thought GCC also emits this error but only with -pedantic. So probably should keep this error but under -Wextra or another appropriate group?

Sep 19 2018, 3:19 PM

Sep 12 2018

manojgupta added a comment to D51713: Support -fno-omit-frame-pointer with -pg..

What is the call generated with -pg for AMR32, gnu_mcount_nc or _mount? gnu_mcount_nc with "-pg" is known to be broken ( https://bugs.llvm.org/show_bug.cgi?id=33845)

I CCed myself on that issue as we are trying to do a better job of supporting code coverage, but I don't think this bug is relevant for this patch.

Unless there are any additional reviews, I will likely submit this patch in a few hours.

Sep 12 2018, 2:44 PM
manojgupta added a comment to D51713: Support -fno-omit-frame-pointer with -pg..

What is the call generated with -pg for AMR32, gnu_mcount_nc or _mount? gnu_mcount_nc with "-pg" is known to be broken ( https://bugs.llvm.org/show_bug.cgi?id=33845)

Sep 12 2018, 1:32 PM

Sep 4 2018

manojgupta added inline comments to D48580: [AArch64] Support reserving x1-7 registers..
Sep 4 2018, 8:36 PM

Aug 29 2018

manojgupta added a comment to D51440: [ToolChains] Link to compiler-rt with -L + -l when possible.

Just a minor comment regarding test cases: Since you are adding both -L/path/ and -l<libname>, the test cases should be updated to check for the -L/path/ argument as well.

I guess I could do that, although we don't know the path in the test, so we can only check for -L.*.

Aug 29 2018, 11:21 AM
manojgupta added a comment to D51440: [ToolChains] Link to compiler-rt with -L + -l when possible.

Just a minor comment regarding test cases: Since you are adding both -L/path/ and -l<libname>, the test cases should be updated to check for the -L/path/ argument as well.

Aug 29 2018, 10:31 AM

Jul 30 2018

manojgupta added a comment to D50000: [Inline] Copy "null-pointer-is-valid" attribute in caller..

Congrats on D50000 :)

Jul 30 2018, 12:50 PM
manojgupta committed rL338292: [Inline] Copy "null-pointer-is-valid" attribute in caller..
[Inline] Copy "null-pointer-is-valid" attribute in caller.
Jul 30 2018, 12:34 PM
manojgupta closed D50000: [Inline] Copy "null-pointer-is-valid" attribute in caller..
Jul 30 2018, 12:34 PM
manojgupta created D50000: [Inline] Copy "null-pointer-is-valid" attribute in caller..
Jul 30 2018, 12:06 PM

Jul 26 2018

manojgupta added a comment to D47895: llvm: Add support for "-fno-delete-null-pointer-checks".

Random uneducated thought - how does it work with multiple translation units, where not all of them have/don't have that flag set?

Jul 26 2018, 11:59 AM

Jul 25 2018

manojgupta added a comment to D47895: llvm: Add support for "-fno-delete-null-pointer-checks".

Note that, I am expecting that functions with alwaysinline attribute should still get inlined. If that happens and caller does not have this attribute, then optimizer is free to remove the checks.

Not that I actually hit that, but it was questionable when reading the code - why that way? From LangRef: alwaysinline "indicates that the inliner should attempt to inline this function into callers whenever possible, ignoring any active inlining size threshold for this caller." So there is some freedom by not doing the inlining, even in the presence of the attribute.

Wouldn't it be better not to inline or to add the attribute to the caller?

Jul 25 2018, 12:50 PM

Jul 23 2018

manojgupta added a comment to D49690: ConstantFolding: Avoid a crash..

Thanks for the quick review!

Jul 23 2018, 3:29 PM
manojgupta committed rL337742: ConstantFolding: Avoid a crash..
ConstantFolding: Avoid a crash.
Jul 23 2018, 2:20 PM
manojgupta closed D49690: ConstantFolding: Avoid a crash..
Jul 23 2018, 2:20 PM
manojgupta added a comment to D49690: ConstantFolding: Avoid a crash..

Thanks Piotr for the testcase.

Jul 23 2018, 12:11 PM
manojgupta created D49690: ConstantFolding: Avoid a crash..
Jul 23 2018, 12:10 PM

Jul 19 2018

manojgupta added a comment to D48580: [AArch64] Support reserving x1-7 registers..

What clang version is that? Works fine for me.

Jul 19 2018, 10:51 AM
manojgupta added a comment to D48580: [AArch64] Support reserving x1-7 registers..

@efriedma Maybe not relevant to the patch here but our kernel devs were looking into preserve_all but it does not seem to work for AArch64.

Jul 19 2018, 10:45 AM

Jul 18 2018

manojgupta committed rL337433: [clang]: Add support for "-fno-delete-null-pointer-checks".
[clang]: Add support for "-fno-delete-null-pointer-checks"
Jul 18 2018, 5:50 PM
manojgupta committed rC337433: [clang]: Add support for "-fno-delete-null-pointer-checks".
[clang]: Add support for "-fno-delete-null-pointer-checks"
Jul 18 2018, 5:50 PM
manojgupta closed D47894: [clang]: Add support for "-fno-delete-null-pointer-checks".
Jul 18 2018, 5:49 PM
manojgupta updated subscribers of D48580: [AArch64] Support reserving x1-7 registers..
Jul 18 2018, 4:38 PM
manojgupta updated the summary of D47894: [clang]: Add support for "-fno-delete-null-pointer-checks".
Jul 18 2018, 1:38 PM

Jul 17 2018

manojgupta updated the diff for D47894: [clang]: Add support for "-fno-delete-null-pointer-checks".

Added helper text, updated tests.

Jul 17 2018, 8:06 AM

Jul 16 2018

manojgupta added a reviewer for D47894: [clang]: Add support for "-fno-delete-null-pointer-checks": george.burgess.iv.
Jul 16 2018, 2:31 PM