Page MenuHomePhabricator

manojgupta (Manoj Gupta)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2016, 10:04 PM (328 w, 2 d)

Recent Activity

Mon, Mar 27

manojgupta added a comment to D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations.

This is firing even in checked length codes, is that expected?

Mon, Mar 27, 10:48 AM · Restricted Project, Restricted Project

Tue, Mar 21

manojgupta added a comment to D136765: [ASan][libcxx] Annotating std::vector with all allocators.

I do agree however that if someone (in this case Chrome) is using a not-yet-released snapshot of trunk that happens to have _LIBCPP_CLANG_VER >= 1600 yet isn't something we've released as LLVM 16, then it's probably not reasonable for us to try to support that. Imagine coming up with that policy, I think it would mean that we can't ever rely on _LIBCPP_CLANG_VER >= 1600 during the libc++ 16 release, which would be pretty unfortunate.

(FWIW it's ChromeOS, not Chrome, that's using an older Clang version. And if necessary they can probably patch in the needed compiler-rt changes. Also, https://libcxx.llvm.org/ technically says that clang "16-git" is supported, which is what they are using ;)

It's "16-git" as-in current trunk, not some random version from a few months ago.

I'll stop harping on about this, but I think gating functionality on _LIBCPP_CLANG_VER isn't great for the reason we've seen here. (And Eric predicted it in his "It smells weird, and it looks weird, and I think it'll lead to bugs." comment). I'm pleased to see that it's currently only used in two places in libc++, one of which is for a deprecation warning. As mentioned above, the best would be if compiler-rt exposed some kind of feature check for this, but if we can't have that, I think >= 17 is the way to go.

I don't think >= 17 is an option. You are basically asking us to keep the code around for another release because someone used some wacky unsupported configuration. Either live at head or use releases. They exist for a reason.

Tue, Mar 21, 12:05 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 8

manojgupta updated subscribers of D136765: [ASan][libcxx] Annotating std::vector with all allocators.

FYI this is causing (yet another) bug on Chrome/Chrome OS: https://crbug.com/1422033

We've root caused this to ChromeOS using a toolchain based on llvmorg-16-init-6711-g11897708c022, which is before the ASan runtime gained support for unaligned container memory in llvmorg-16-init-9006-gdd1b7b797a11, which this patch depends on. (https://crbug.com/1422033#c11 has a reproducer).

I see that the patch is already trying to handle this with the #if _LIBCPP_CLANG_VER >= 1600 check. However, that doesn't quite work since there were many revisions with that version number before the ASan change.

Should it be checking _LIBCPP_CLANG_VER >= 1700 instead, or is there some more precise way to handle this? (Does the ASan runtime have some way to check if it supports this for example?)

Wed, Mar 8, 7:22 AM · Restricted Project, Restricted Project, Restricted Project

Jan 25 2023

manojgupta added a comment to D141836: [AArch64] Disable __muloti4 libcalls for AArch64.

At least for ChromeOS, as long as this change is limited to clang not making calls to it and function is not removed from compiler-rt, it works for us . We ship a libgcc_s.so using compiler-rt sources so we need so compatibility there so that older binaries keep working.

Jan 25 2023, 4:16 PM · Restricted Project, Restricted Project

Jan 20 2023

manojgupta accepted D111456: [InlineCost] model calls to llvm.objectsize.*.

The change looks simple enough and do not see any issues raised.

Jan 20 2023, 6:48 AM · Restricted Project, Restricted Project

Jan 18 2023

manojgupta added a comment to D111456: [InlineCost] model calls to llvm.objectsize.*.

The patch looks simple enough to me. But I do not know this code patch well enough to accept it. Agree that Inlining cost estimation work should not block this.

Jan 18 2023, 11:20 AM · Restricted Project, Restricted Project

Dec 16 2022

manojgupta updated subscribers of D140224: [Driver] Revert D139717 and add -Xparser instead.

If ChromeOS needs time for migration, I think -Xcompiler can be temporarily ignored.

Dec 16 2022, 9:59 PM · Restricted Project, Restricted Project
manojgupta added a comment to D140224: [Driver] Revert D139717 and add -Xparser instead.

Here are a few instances of Xcompiler usage for a non-exhaustive search (I can't look inside package tarballs if they are using it ):

Dec 16 2022, 10:31 AM · Restricted Project, Restricted Project
manojgupta added a comment to D140224: [Driver] Revert D139717 and add -Xparser instead.

Without -Xcompiler, ChromeOS code will break. It may not be supported by GCC but it is supported in some other compilers like Cuda and a few others if you search. Also being supported by libtool makes it more important to keep it working.

Dec 16 2022, 9:54 AM · Restricted Project, Restricted Project

Dec 15 2022

manojgupta added a comment to D139717: Revert "[Driver] Remove Joined -X".

Xlinker still works. Xcompiler is failing.

Dec 15 2022, 8:31 AM · Restricted Project, Restricted Project

Dec 12 2022

manojgupta added a comment to D139717: Revert "[Driver] Remove Joined -X".

We use -Xcompiler and -Xlinker which are passed in programs and they raise error now.

Dec 12 2022, 8:43 AM · Restricted Project, Restricted Project

Dec 9 2022

manojgupta added a comment to D139717: Revert "[Driver] Remove Joined -X".

The removal is also breaking ChromeOS builds which use -Xpattern in some cases.

Dec 9 2022, 11:07 PM · Restricted Project, Restricted Project

Nov 3 2022

manojgupta committed rG2497d5aa7716: Define _GNU_SOURCE for arm baremetal in C++ mode. (authored by manojgupta).
Define _GNU_SOURCE for arm baremetal in C++ mode.
Nov 3 2022, 1:59 PM · Restricted Project, Restricted Project
manojgupta closed D136712: Define _GNU_SOURCE for arm baremetal in C++ mode..
Nov 3 2022, 1:59 PM · Restricted Project, Restricted Project
manojgupta updated the diff for D136712: Define _GNU_SOURCE for arm baremetal in C++ mode..

Updated test.

Nov 3 2022, 12:32 PM · Restricted Project, Restricted Project
manojgupta updated the diff for D136712: Define _GNU_SOURCE for arm baremetal in C++ mode..

Restore back to C++ only.

Nov 3 2022, 9:18 AM · Restricted Project, Restricted Project
manojgupta updated the diff for D136712: Define _GNU_SOURCE for arm baremetal in C++ mode..

restore back to C++ only

Nov 3 2022, 9:18 AM · Restricted Project, Restricted Project

Oct 28 2022

manojgupta added a comment to D136712: Define _GNU_SOURCE for arm baremetal in C++ mode..

@tomhughes has more details on this but if we do not define it in clang itself, we'll need to define it for every package manually at build time since the usage goes deep inside newlib headers.

Oct 28 2022, 1:38 PM · Restricted Project, Restricted Project
manojgupta added reviewers for D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.: MaskRay, efriedma.

I am not sure who is a good reviewer for this. Starting with @MaskRay and @efriedma

Oct 28 2022, 1:17 PM · Restricted Project, Restricted Project

Oct 26 2022

manojgupta added a comment to D136667: Check return address stored in normal stack and CET shadow stack in unwind process phase2.

thanks, I assume @MaskRay is a good reviewer for it.

Oct 26 2022, 8:33 AM · Restricted Project, Restricted Project, Restricted Project

Oct 25 2022

manojgupta updated the diff for D136712: Define _GNU_SOURCE for arm baremetal in C++ mode..

Removed c++ limitation.

Oct 25 2022, 1:56 PM · Restricted Project, Restricted Project
manojgupta requested review of D136712: Define _GNU_SOURCE for arm baremetal in C++ mode..
Oct 25 2022, 1:12 PM · Restricted Project, Restricted Project
manojgupta updated subscribers of D136708: [libcxx] Disable assert when building with newlib.
Oct 25 2022, 1:08 PM · Restricted Project, Restricted Project
manojgupta added reviewers for D136708: [libcxx] Disable assert when building with newlib: ldionne, abidh.
Oct 25 2022, 12:10 PM · Restricted Project, Restricted Project
manojgupta abandoned D136705: libcxx: Disable __regex_word assert on newlib.

Abandon in favor of D136708

Oct 25 2022, 12:09 PM · Restricted Project, Restricted Project
manojgupta requested review of D136705: libcxx: Disable __regex_word assert on newlib.
Oct 25 2022, 11:14 AM · Restricted Project, Restricted Project

Oct 7 2022

manojgupta committed rG5e5d21462d1e: BareMetal: detect usr/include/c++/v1 path in sysroot (authored by manojgupta).
BareMetal: detect usr/include/c++/v1 path in sysroot
Oct 7 2022, 9:26 PM · Restricted Project, Restricted Project
manojgupta closed D134478: BareMetal: detect usr/include/c++/v1 path in sysroot.
Oct 7 2022, 9:26 PM · Restricted Project, Restricted Project

Oct 5 2022

manojgupta updated the diff for D134478: BareMetal: detect usr/include/c++/v1 path in sysroot.

address comments and check CI.

Oct 5 2022, 7:36 PM · Restricted Project, Restricted Project

Oct 3 2022

manojgupta added a comment to D134478: BareMetal: detect usr/include/c++/v1 path in sysroot.

friendly ping for review.

Oct 3 2022, 10:27 AM · Restricted Project, Restricted Project

Sep 22 2022

manojgupta requested review of D134478: BareMetal: detect usr/include/c++/v1 path in sysroot.
Sep 22 2022, 2:01 PM · Restricted Project, Restricted Project
manojgupta added a comment to D134454: [Driver][Distro] Fix ArchLinux sysroot detection.

Thanks for the patch. Can you please post a full diff (git diff -U9999).

Sep 22 2022, 10:11 AM · Restricted Project, Restricted Project

Aug 10 2022

manojgupta committed rG06fc5a771462: Driver: Refactor and support per target dirs in baremetal (authored by manojgupta).
Driver: Refactor and support per target dirs in baremetal
Aug 10 2022, 9:17 AM · Restricted Project, Restricted Project
manojgupta closed D131225: Driver: Refactor and support per target dirs in baremetal.
Aug 10 2022, 9:17 AM · Restricted Project, Restricted Project, Restricted Project

Aug 9 2022

manojgupta updated the diff for D131225: Driver: Refactor and support per target dirs in baremetal.

Going back to older handlesTarget() style in Baremetal.
Apparently RISCV can be both Baremetal or RISCVToolchain for the
same tuple. I do not know of the nuances so trying not to disturb that for
now.

Aug 9 2022, 9:31 PM · Restricted Project, Restricted Project, Restricted Project
manojgupta updated the diff for D131225: Driver: Refactor and support per target dirs in baremetal.

Fix clang-format complains.

Aug 9 2022, 5:30 PM · Restricted Project, Restricted Project, Restricted Project
manojgupta updated the diff for D131225: Driver: Refactor and support per target dirs in baremetal.

Address maskray comments.

Aug 9 2022, 11:30 AM · Restricted Project, Restricted Project, Restricted Project

Aug 8 2022

manojgupta added inline comments to D131225: Driver: Refactor and support per target dirs in baremetal.
Aug 8 2022, 1:00 PM · Restricted Project, Restricted Project, Restricted Project
manojgupta updated the diff for D131225: Driver: Refactor and support per target dirs in baremetal.

Address more style lints.

Aug 8 2022, 12:59 PM · Restricted Project, Restricted Project, Restricted Project
manojgupta updated the diff for D131225: Driver: Refactor and support per target dirs in baremetal.

Address style nits.

Aug 8 2022, 12:53 PM · Restricted Project, Restricted Project, Restricted Project
manojgupta updated the diff for D131225: Driver: Refactor and support per target dirs in baremetal.

Moved defs to Triple.cpp

Aug 8 2022, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
manojgupta added inline comments to D131225: Driver: Refactor and support per target dirs in baremetal.
Aug 8 2022, 11:45 AM · Restricted Project, Restricted Project, Restricted Project
manojgupta updated the diff for D131225: Driver: Refactor and support per target dirs in baremetal.

Moved Baremetal triple related code to Triple.h.

Aug 8 2022, 11:41 AM · Restricted Project, Restricted Project, Restricted Project
manojgupta added inline comments to D131225: Driver: Refactor and support per target dirs in baremetal.
Aug 8 2022, 9:44 AM · Restricted Project, Restricted Project, Restricted Project

Aug 4 2022

manojgupta requested review of D131225: Driver: Refactor and support per target dirs in baremetal.
Aug 4 2022, 5:59 PM · Restricted Project, Restricted Project, Restricted Project

Jun 27 2022

manojgupta added a comment to D128680: [SLP]Fix PR56251: Do not remove the reordering from the root node, being used as an operand..

Thanks, I can verify that this fixes the crash I reported.

Jun 27 2022, 2:51 PM · Restricted Project, Restricted Project
manojgupta added a comment to D115462: [SLP]Improve shuffles cost estimation where possible..

Still crashes on trunk.

Jun 27 2022, 1:00 PM · Restricted Project, Restricted Project

Jun 26 2022

manojgupta added a comment to D115462: [SLP]Improve shuffles cost estimation where possible..

Heads up: I am seeing a clang crash on arm with this commit:

Jun 26 2022, 9:44 PM · Restricted Project, Restricted Project

Jun 25 2022

manojgupta added a comment to D127226: [libc++] Simplify type_traits and use more builtins.

If you can't wait until Wednesday or Thursday you can always revert the diff downstream.

Jun 25 2022, 12:41 PM · Restricted Project, Restricted Project
manojgupta added a reverting change for rG42f8f5579897: [libc++] Simplify type_traits and use more builtins: rGda0448a361d4: Revert "[libc++] Simplify type_traits and use more builtins".
Jun 25 2022, 12:39 PM · Restricted Project, Restricted Project
manojgupta committed rGda0448a361d4: Revert "[libc++] Simplify type_traits and use more builtins" (authored by manojgupta).
Revert "[libc++] Simplify type_traits and use more builtins"
Jun 25 2022, 12:39 PM · Restricted Project, Restricted Project
manojgupta added a reverting change for D127226: [libc++] Simplify type_traits and use more builtins: rGda0448a361d4: Revert "[libc++] Simplify type_traits and use more builtins".
Jun 25 2022, 12:39 PM · Restricted Project, Restricted Project
manojgupta closed D128587: Revert "[libc++] Simplify type_traits and use more builtins".
Jun 25 2022, 12:39 PM · Restricted Project, Restricted Project
manojgupta added a comment to D128587: Revert "[libc++] Simplify type_traits and use more builtins".

Will submit after CI results come back.

Jun 25 2022, 10:03 AM · Restricted Project, Restricted Project
manojgupta added a comment to rG42f8f5579897: [libc++] Simplify type_traits and use more builtins.

Will submit after CI results.

Jun 25 2022, 10:03 AM · Restricted Project, Restricted Project
manojgupta added a reverting change for rG42f8f5579897: [libc++] Simplify type_traits and use more builtins: D128587: Revert "[libc++] Simplify type_traits and use more builtins".
Jun 25 2022, 10:02 AM · Restricted Project, Restricted Project
manojgupta requested review of D128587: Revert "[libc++] Simplify type_traits and use more builtins".
Jun 25 2022, 10:02 AM · Restricted Project, Restricted Project
manojgupta added a reverting change for D127226: [libc++] Simplify type_traits and use more builtins: D128587: Revert "[libc++] Simplify type_traits and use more builtins".
Jun 25 2022, 10:02 AM · Restricted Project, Restricted Project

Jun 24 2022

manojgupta added a comment to D127226: [libc++] Simplify type_traits and use more builtins.

@philnik @ldionne Can this patch please be reverted? There are clear test cases that it breaks.

Jun 24 2022, 4:55 PM · Restricted Project, Restricted Project

Jun 22 2022

manojgupta added a comment to D127226: [libc++] Simplify type_traits and use more builtins.

The following code now longer works after this patch:

Jun 22 2022, 1:18 PM · Restricted Project, Restricted Project
manojgupta added a comment to D127226: [libc++] Simplify type_traits and use more builtins.

This seems like same as the problem that was fixed by https://reviews.llvm.org/rGe6a39f00e8d0cd3684df54fb03d288efe2969202 and re-introduced by this patch.

Jun 22 2022, 1:13 PM · Restricted Project, Restricted Project
manojgupta updated subscribers of D127226: [libc++] Simplify type_traits and use more builtins.
Jun 22 2022, 1:11 PM · Restricted Project, Restricted Project

Jun 5 2022

manojgupta added a comment to D126868: [libunwind] Remove unused ARM SEH placeholder code.

Thanks for clarifying that ELF is not affected, I just wanted someone from ARM to verify.

Jun 5 2022, 1:52 PM · Restricted Project, Restricted Project, Restricted Project
manojgupta added a reviewer for D126869: [libunwind] Don't store a predecremented PC when using SEH: danielkiss.

@danielkiss can you please review?

Jun 5 2022, 1:36 PM · Restricted Project, Restricted Project, Restricted Project
manojgupta added a reviewer for D126868: [libunwind] Remove unused ARM SEH placeholder code: danielkiss.

Daniel, can you please check if this removal is ok. I am particularly worried about pthread_cancel which is often hard to debug.

Jun 5 2022, 1:34 PM · Restricted Project, Restricted Project, Restricted Project

Jun 3 2022

manojgupta added a comment to D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux.

Yes, LLVM_ENABLE_RUNTIMES and LLVM_ENABLE_PER_TARGET_RUNTIME_DIR are two separate things.

Jun 3 2022, 8:32 AM · Restricted Project, Restricted Project, Restricted Project

May 25 2022

manojgupta added inline comments to D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".
May 25 2022, 8:54 AM · Restricted Project, Restricted Project

May 16 2022

manojgupta added a comment to D123779: [AArch64] Add `foldOverflowCheck` DAG combine.

We are noticing a clang crash after this commit: https://github.com/llvm/llvm-project/issues/55510

May 16 2022, 10:37 AM · Restricted Project, Restricted Project

May 10 2022

manojgupta added a comment to D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".

Thanks Christopher,

May 10 2022, 1:02 PM · Restricted Project, Restricted Project

May 5 2022

manojgupta added inline comments to D125074: [ELF] Change (NOLOAD) type mismatch to use SHT_NOBITS instead of SHT_PROGBITS.
May 5 2022, 10:59 PM · Restricted Project, Restricted Project
manojgupta added a comment to D118840: [ELF] Support (TYPE=<value>) to customize the output section type.

We can close the discussion as Fangrui has uploaded https://reviews.llvm.org/D125074 to keep older behavior.

May 5 2022, 10:32 PM · Restricted Project, Restricted Project
manojgupta added a comment to D125074: [ELF] Change (NOLOAD) type mismatch to use SHT_NOBITS instead of SHT_PROGBITS.

Thanks fangrui.

May 5 2022, 10:31 PM · Restricted Project, Restricted Project
manojgupta updated subscribers of D118840: [ELF] Support (TYPE=<value>) to customize the output section type.
May 5 2022, 2:33 PM · Restricted Project, Restricted Project
Herald added a project to D118840: [ELF] Support (TYPE=<value>) to customize the output section type: Restricted Project.

This change is breaking rust embedded use cases where NOLOAD in a linker script is no longer being honored. So we had to revert it (locally) in ChromeOS.

May 5 2022, 2:30 PM · Restricted Project, Restricted Project

Apr 30 2022

manojgupta added a comment to D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

Hmm, the commit message says that Wno-error should work but this is not really the case :(.

Apr 30 2022, 12:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
manojgupta added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.

Following behavior is also surprising:

Apr 30 2022, 9:30 AM · Restricted Project, Restricted Project
manojgupta added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.

Tried locally but I still see the warning with -fno-knr-functions. It also says that the argument is unused.

Apr 30 2022, 9:27 AM · Restricted Project, Restricted Project
manojgupta added a comment to D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

We are finding a lot of failures in our ToT builds with this change. here is an example for a configure script:

Apr 30 2022, 9:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 29 2022

manojgupta added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.

Unless I probably mis-interpreted something, -fno-knr-functions does not suppress the warning: https://godbolt.org/z/rbEfbbb33

Apr 29 2022, 11:27 AM · Restricted Project, Restricted Project
manojgupta added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.
Basically, I'm wondering if you'd be able to enable -fno-knr-function?

Thanks. this looks promising. Any ideas when -fno-knr-function support was added?

Apr 29 2022, 11:23 AM · Restricted Project, Restricted Project
manojgupta added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.
Is disabling the pedantic warning an option for your users?
Apr 29 2022, 8:36 AM · Restricted Project, Restricted Project

Apr 28 2022

manojgupta added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.

Some of our users are not very happy with the churn probably caused by this change where the declaration has the "void" argument but the later definition does not have explicit "void".

Apr 28 2022, 6:17 PM · Restricted Project, Restricted Project

Apr 27 2022

manojgupta added a comment to D124522: [libunwind][AArch64] Fix _Unwind_ForcedUnwind via sigreturn..

Thanks, this also fixes one of the test failures we were seeing on AArch64 boards.

Apr 27 2022, 8:44 AM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2022

manojgupta added a comment to D123300: [Clang] Enable opaque pointers by default.

We noticed a new crash that still repros at head.

Apr 14 2022, 5:59 PM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2022

manojgupta committed rG1f82d0f795d1: [msan] Add interceptors for Linux 64-bit stat variants (authored by manojgupta).
[msan] Add interceptors for Linux 64-bit stat variants
Mar 15 2022, 8:23 PM · Restricted Project
manojgupta closed D121652: [msan] Add interceptors for Linux 64-bit stat variants.
Mar 15 2022, 8:23 PM · Restricted Project, Restricted Project
manojgupta updated the diff for D121652: [msan] Add interceptors for Linux 64-bit stat variants.

Replaced uses of /dev/stdin by /dev/null and added asserts.

Mar 15 2022, 7:21 PM · Restricted Project, Restricted Project
manojgupta updated the diff for D121652: [msan] Add interceptors for Linux 64-bit stat variants.

Added tests for stat64 and fstatat64

Mar 15 2022, 7:12 PM · Restricted Project, Restricted Project

Mar 14 2022

manojgupta added inline comments to D121652: [msan] Add interceptors for Linux 64-bit stat variants.
Mar 14 2022, 9:56 PM · Restricted Project, Restricted Project
manojgupta added inline comments to D121652: [msan] Add interceptors for Linux 64-bit stat variants.
Mar 14 2022, 9:55 PM · Restricted Project, Restricted Project
manojgupta added a comment to D121652: [msan] Add interceptors for Linux 64-bit stat variants.

to avoid crash you need:
INIT_STAT64;
INIT_LSTAT64;
around sanitizer_common_interceptors.inc:10554

can you please add corresponding tests similar to
llvm-project/compiler-rt/test/sanitizer_common/TestCases/Posix/lstat.cpp
llvm-project/compiler-rt/test/msan/fstat.cpp

Mar 14 2022, 9:44 PM · Restricted Project, Restricted Project
manojgupta updated the diff for D121652: [msan] Add interceptors for Linux 64-bit stat variants.

Fixed crash and added suggested tests.

Mar 14 2022, 9:40 PM · Restricted Project, Restricted Project
manojgupta added a comment to D121652: [msan] Add interceptors for Linux 64-bit stat variants.

I am noticing a unit tests error with this change for glob_altdirfunc.cpp file but not sure how to resolve it.

MemorySanitizer:DEADLYSIGNAL
==3854677==ERROR: MemorySanitizer: SEGV on unknown address 0x000000000000 (pc 0x000000000000 bp 0x7ffeeab8eb60 sp 0x7ffeeab8eb28 T3854677)
==3854677==Hint: pc points to the zero page.
==3854677==The signal is caused by a READ memory access.
==3854677==Hint: address points to the zero page.
Mar 14 2022, 4:56 PM · Restricted Project, Restricted Project
manojgupta requested review of D121652: [msan] Add interceptors for Linux 64-bit stat variants.
Mar 14 2022, 4:54 PM · Restricted Project, Restricted Project

Mar 9 2022

manojgupta added a comment to D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static""".

For the background, we had hit this in Chrome OS when building bluetooth code.

Mar 9 2022, 1:38 PM · Restricted Project, Restricted Project

Mar 4 2022

manojgupta added a comment to D118376: [x86] try harder to scalarize a vector load with extracted integer op uses.

We are noticing some failures in internal unit tests with this change.

Tests pass at 588f121ada6d541 but start failing at b4b97ec813a0258.

Mar 4 2022, 8:22 AM · Restricted Project, Restricted Project
Herald added a project to D118376: [x86] try harder to scalarize a vector load with extracted integer op uses: Restricted Project.

We are noticing some failures in internal unit tests with this change.

Mar 4 2022, 8:17 AM · Restricted Project, Restricted Project

Mar 3 2022

Herald added a project to D116821: [DebugInfo][InstrRef] Move instr-ref controlling flag out of TargetOptions: Restricted Project.

We noticed another crash with this change that still repros on ToT: https://github.com/llvm/llvm-project/issues/54190

Mar 3 2022, 6:20 PM · Restricted Project, Restricted Project

Mar 2 2022

manojgupta added a comment to D120831: [libc++] Remove the deprecated <ext/hash_set> and <ext/hash_map>..

I attempted in Feb 2019 here: https://reviews.llvm.org/D57688.

I ended up dropping the effort after the discussion at https://discourse.llvm.org/t/removing-deprecated-ext-hash-set-ext-hash-map-and-ext-hash/51068.

FWIW, I still support this removal, but I'd like to get a better understanding of what's broken by it before moving forward.

Mar 2 2022, 10:13 AM · Restricted Project, Restricted Project

Feb 28 2022

manojgupta added a comment to D119969: [libc++] Unconditionally provide the ability for users to enable assertions.

Running readelf shows following in our shipping shared libs.

Feb 28 2022, 2:35 PM · Restricted Project, Restricted Project