Page MenuHomePhabricator

manojgupta (Manoj Gupta)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2016, 10:04 PM (284 w, 3 d)

Recent Activity

Wed, May 25

manojgupta added inline comments to D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".
Wed, May 25, 8:54 AM · Restricted Project, Restricted Project

Mon, May 16

manojgupta added a comment to D123779: [AArch64] Add `foldOverflowCheck` DAG combine.

We are noticing a clang crash after this commit: https://github.com/llvm/llvm-project/issues/55510

Mon, May 16, 10:37 AM · Restricted Project, Restricted Project

Tue, May 10

manojgupta added a comment to D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".

Thanks Christopher,

Tue, May 10, 1:02 PM · Restricted Project, Restricted Project

Thu, May 5

manojgupta added inline comments to D125074: [ELF] Change (NOLOAD) type mismatch to use SHT_NOBITS instead of SHT_PROGBITS.
Thu, May 5, 10:59 PM · Restricted Project, Restricted Project
manojgupta added a comment to D118840: [ELF] Support (TYPE=<value>) to customize the output section type.

We can close the discussion as Fangrui has uploaded https://reviews.llvm.org/D125074 to keep older behavior.

Thu, May 5, 10:32 PM · Restricted Project, Restricted Project
manojgupta added a comment to D125074: [ELF] Change (NOLOAD) type mismatch to use SHT_NOBITS instead of SHT_PROGBITS.

Thanks fangrui.

Thu, May 5, 10:31 PM · Restricted Project, Restricted Project
manojgupta updated subscribers of D118840: [ELF] Support (TYPE=<value>) to customize the output section type.
Thu, May 5, 2:33 PM · Restricted Project, Restricted Project
Herald added a project to D118840: [ELF] Support (TYPE=<value>) to customize the output section type: Restricted Project.

This change is breaking rust embedded use cases where NOLOAD in a linker script is no longer being honored. So we had to revert it (locally) in ChromeOS.

Thu, May 5, 2:30 PM · Restricted Project, Restricted Project

Sat, Apr 30

manojgupta added a comment to D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

Hmm, the commit message says that Wno-error should work but this is not really the case :(.

Sat, Apr 30, 12:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
manojgupta added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.

Following behavior is also surprising:

Sat, Apr 30, 9:30 AM · Restricted Project, Restricted Project
manojgupta added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.

Tried locally but I still see the warning with -fno-knr-functions. It also says that the argument is unused.

Sat, Apr 30, 9:27 AM · Restricted Project, Restricted Project
manojgupta added a comment to D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

We are finding a lot of failures in our ToT builds with this change. here is an example for a configure script:

Sat, Apr 30, 9:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Apr 29

manojgupta added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.

Unless I probably mis-interpreted something, -fno-knr-functions does not suppress the warning: https://godbolt.org/z/rbEfbbb33

Fri, Apr 29, 11:27 AM · Restricted Project, Restricted Project
manojgupta added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.
Basically, I'm wondering if you'd be able to enable -fno-knr-function?

Thanks. this looks promising. Any ideas when -fno-knr-function support was added?

Fri, Apr 29, 11:23 AM · Restricted Project, Restricted Project
manojgupta added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.
Is disabling the pedantic warning an option for your users?
Fri, Apr 29, 8:36 AM · Restricted Project, Restricted Project

Thu, Apr 28

manojgupta added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.

Some of our users are not very happy with the churn probably caused by this change where the declaration has the "void" argument but the later definition does not have explicit "void".

Thu, Apr 28, 6:17 PM · Restricted Project, Restricted Project

Apr 27 2022

manojgupta added a comment to D124522: [libunwind][AArch64] Fix _Unwind_ForcedUnwind via sigreturn..

Thanks, this also fixes one of the test failures we were seeing on AArch64 boards.

Apr 27 2022, 8:44 AM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2022

manojgupta added a comment to D123300: [Clang] Enable opaque pointers by default.

We noticed a new crash that still repros at head.

Apr 14 2022, 5:59 PM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2022

manojgupta committed rG1f82d0f795d1: [msan] Add interceptors for Linux 64-bit stat variants (authored by manojgupta).
[msan] Add interceptors for Linux 64-bit stat variants
Mar 15 2022, 8:23 PM · Restricted Project
manojgupta closed D121652: [msan] Add interceptors for Linux 64-bit stat variants.
Mar 15 2022, 8:23 PM · Restricted Project, Restricted Project
manojgupta updated the diff for D121652: [msan] Add interceptors for Linux 64-bit stat variants.

Replaced uses of /dev/stdin by /dev/null and added asserts.

Mar 15 2022, 7:21 PM · Restricted Project, Restricted Project
manojgupta updated the diff for D121652: [msan] Add interceptors for Linux 64-bit stat variants.

Added tests for stat64 and fstatat64

Mar 15 2022, 7:12 PM · Restricted Project, Restricted Project

Mar 14 2022

manojgupta added inline comments to D121652: [msan] Add interceptors for Linux 64-bit stat variants.
Mar 14 2022, 9:56 PM · Restricted Project, Restricted Project
manojgupta added inline comments to D121652: [msan] Add interceptors for Linux 64-bit stat variants.
Mar 14 2022, 9:55 PM · Restricted Project, Restricted Project
manojgupta added a comment to D121652: [msan] Add interceptors for Linux 64-bit stat variants.

to avoid crash you need:
INIT_STAT64;
INIT_LSTAT64;
around sanitizer_common_interceptors.inc:10554

can you please add corresponding tests similar to
llvm-project/compiler-rt/test/sanitizer_common/TestCases/Posix/lstat.cpp
llvm-project/compiler-rt/test/msan/fstat.cpp

Mar 14 2022, 9:44 PM · Restricted Project, Restricted Project
manojgupta updated the diff for D121652: [msan] Add interceptors for Linux 64-bit stat variants.

Fixed crash and added suggested tests.

Mar 14 2022, 9:40 PM · Restricted Project, Restricted Project
manojgupta added a comment to D121652: [msan] Add interceptors for Linux 64-bit stat variants.

I am noticing a unit tests error with this change for glob_altdirfunc.cpp file but not sure how to resolve it.

MemorySanitizer:DEADLYSIGNAL
==3854677==ERROR: MemorySanitizer: SEGV on unknown address 0x000000000000 (pc 0x000000000000 bp 0x7ffeeab8eb60 sp 0x7ffeeab8eb28 T3854677)
==3854677==Hint: pc points to the zero page.
==3854677==The signal is caused by a READ memory access.
==3854677==Hint: address points to the zero page.
Mar 14 2022, 4:56 PM · Restricted Project, Restricted Project
manojgupta requested review of D121652: [msan] Add interceptors for Linux 64-bit stat variants.
Mar 14 2022, 4:54 PM · Restricted Project, Restricted Project

Mar 9 2022

manojgupta added a comment to D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static""".

For the background, we had hit this in Chrome OS when building bluetooth code.

Mar 9 2022, 1:38 PM · Restricted Project, Restricted Project

Mar 4 2022

manojgupta added a comment to D118376: [x86] try harder to scalarize a vector load with extracted integer op uses.

We are noticing some failures in internal unit tests with this change.

Tests pass at 588f121ada6d541 but start failing at b4b97ec813a0258.

Mar 4 2022, 8:22 AM · Restricted Project, Restricted Project
Herald added a project to D118376: [x86] try harder to scalarize a vector load with extracted integer op uses: Restricted Project.

We are noticing some failures in internal unit tests with this change.

Mar 4 2022, 8:17 AM · Restricted Project, Restricted Project

Mar 3 2022

Herald added a project to D116821: [DebugInfo][InstrRef] Move instr-ref controlling flag out of TargetOptions: Restricted Project.

We noticed another crash with this change that still repros on ToT: https://github.com/llvm/llvm-project/issues/54190

Mar 3 2022, 6:20 PM · Restricted Project, Restricted Project

Mar 2 2022

manojgupta added a comment to D120831: [libc++] Remove the deprecated <ext/hash_set> and <ext/hash_map>..

I attempted in Feb 2019 here: https://reviews.llvm.org/D57688.

I ended up dropping the effort after the discussion at https://discourse.llvm.org/t/removing-deprecated-ext-hash-set-ext-hash-map-and-ext-hash/51068.

FWIW, I still support this removal, but I'd like to get a better understanding of what's broken by it before moving forward.

Mar 2 2022, 10:13 AM · Restricted Project, Restricted Project

Feb 28 2022

manojgupta added a comment to D119969: [libc++] Unconditionally provide the ability for users to enable assertions.

Running readelf shows following in our shipping shared libs.

Feb 28 2022, 2:35 PM · Restricted Project, Restricted Project
manojgupta added a comment to D119969: [libc++] Unconditionally provide the ability for users to enable assertions.

We had never defined LIBCXX_ENABLE_ASSERTIONS and _LIBCPP_DEBUG explicitly in our cmake config for Chrome OS.

Feb 28 2022, 2:33 PM · Restricted Project, Restricted Project

Feb 11 2022

manojgupta added inline comments to D47895: llvm: Add support for "-fno-delete-null-pointer-checks".
Feb 11 2022, 12:48 PM · Restricted Project

Jan 4 2022

manojgupta added a comment to D116589: Don't override __attribute__((no_stack_protector)) by inlining.

I am fine with this change but Nick should review.

Jan 4 2022, 9:29 AM · Restricted Project

Dec 1 2021

manojgupta added a comment to D114473: [runtimes] Remove support for GCC-style 32 bit multilib builds.

I have removed the usage of this flag from Chrome OS so fine for us as well.

Dec 1 2021, 9:25 AM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2021

manojgupta added a comment to D114473: [runtimes] Remove support for GCC-style 32 bit multilib builds.

testing out Chrome OS change at: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/3308214

Nov 29 2021, 5:38 PM · Restricted Project, Restricted Project, Restricted Project
manojgupta added a comment to D114473: [runtimes] Remove support for GCC-style 32 bit multilib builds.

Will it also fix the bug https://bugs.llvm.org/show_bug.cgi?id=49294 related to m32?

Nov 29 2021, 11:55 AM · Restricted Project, Restricted Project, Restricted Project
manojgupta added a comment to D114473: [runtimes] Remove support for GCC-style 32 bit multilib builds.

Thanks for adding me. This is going to break Chrome OS 32-bit builds so I'll need to check if I can remove uses of LIBCXX_BUILD_32_BITS with something more suitable.

Nov 29 2021, 11:53 AM · Restricted Project, Restricted Project, Restricted Project

Nov 22 2021

manojgupta committed rG2e67276d984d: libfuzzer: Disable broken tests for arm (authored by manojgupta).
libfuzzer: Disable broken tests for arm
Nov 22 2021, 10:34 AM
manojgupta closed D114312: libfuzzer: Disable broken tests for arm.
Nov 22 2021, 10:33 AM · Restricted Project

Nov 19 2021

manojgupta added a reviewer for D114312: libfuzzer: Disable broken tests for arm: vitalybuka.
Nov 19 2021, 10:15 PM · Restricted Project
manojgupta requested review of D114312: libfuzzer: Disable broken tests for arm.
Nov 19 2021, 10:11 PM · Restricted Project

Nov 18 2021

manojgupta added a comment to D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features..

More subjective: for most users this whole -march business is abstracted away in build systems, so they won't have to deal with this, that's why this isn't so much of an improvement.

Nov 18 2021, 8:31 PM · Restricted Project, Restricted Project
manojgupta committed rG2782cb8da0b3: libfuzzer: All building libfuzzer for ARM32 (authored by manojgupta).
libfuzzer: All building libfuzzer for ARM32
Nov 18 2021, 5:31 PM
manojgupta closed D112091: libfuzzer: All building libfuzzer for ARM32.
Nov 18 2021, 5:31 PM · Restricted Project
manojgupta added a comment to D100870: [MemCpyOpt] Allow variable lengths in memcpy optimizer.

Chrome OS bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1233594. Seems like it was tcl that was miscompiled, not LUA.

Nov 18 2021, 2:27 PM · Restricted Project
manojgupta added a comment to D100870: [MemCpyOpt] Allow variable lengths in memcpy optimizer.

Late comment but this broke LUA (could be a mis-compile ) which further broke building sqlite. This commit was reverted in Chrome OS (https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/3066844) but seems like the reporter forgot to mention it upstream.

Nov 18 2021, 2:24 PM · Restricted Project

Nov 17 2021

manojgupta added a reviewer for D112091: libfuzzer: All building libfuzzer for ARM32: morehouse.

Matt, do you think you can review this?

Nov 17 2021, 9:07 PM · Restricted Project

Nov 15 2021

manojgupta added a comment to D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features..

Yes, the current approach of "-march=<isa>+feature" is terrible and does not work with developers who want flexibility of features. This being pitched as a feature imo is akin to promoting a design bug as a feature.
Any additive or subtractive alternative is welcome.

Nov 15 2021, 7:38 AM · Restricted Project, Restricted Project

Nov 8 2021

manojgupta added a comment to D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux.

Assuming CMAKE_SYSTEM_NAME implies the machine, clang is being built on,
it may also break baremetal targets since clang does not currently handle per ABI runtime dirs for baremetal targets
e.g. see the problem in https://reviews.llvm.org/D98452

Nov 8 2021, 10:49 AM · Restricted Project, Restricted Project

Nov 7 2021

manojgupta committed rGdb27867dfc95: [compiler-rt] Produce the right arch suffix for arm baremetal (authored by manojgupta).
[compiler-rt] Produce the right arch suffix for arm baremetal
Nov 7 2021, 8:52 AM
manojgupta closed D113357: [compiler-rt] Produce the right arch suffix for arm baremetal.
Nov 7 2021, 8:52 AM · Restricted Project

Nov 6 2021

manojgupta added a comment to D98452: [compiler-rt] Produce the right arch suffix for arm libraries.

Sure, see D113357

Nov 6 2021, 7:18 PM · Restricted Project
manojgupta requested review of D113357: [compiler-rt] Produce the right arch suffix for arm baremetal.
Nov 6 2021, 7:17 PM · Restricted Project
manojgupta added a comment to D98452: [compiler-rt] Produce the right arch suffix for arm libraries.

Yes, you can check for COMPILER_RT_BAREMETAL_BUILD in cmake to keep the older naming for baremetal. The baremetal targets have very different driver searching mechanisms for libs, not sure why.

Nov 6 2021, 1:10 PM · Restricted Project

Nov 5 2021

manojgupta added a comment to D98452: [compiler-rt] Produce the right arch suffix for arm libraries.

Sorry for replying since this patch has been there for a while. But this has broken the installs for the baremetal targets eg armv7m-none-eabi.

Nov 5 2021, 9:00 PM · Restricted Project

Nov 4 2021

manojgupta added a comment to D109811: [compiler-rt][CET] Enable CET for compiler-rt builtin library.

@compnerd can you please check again.

Nov 4 2021, 11:00 AM · Restricted Project

Oct 28 2021

manojgupta added a comment to D112091: libfuzzer: All building libfuzzer for ARM32.

@kcc do you have any concerns?

Oct 28 2021, 8:24 AM · Restricted Project

Oct 25 2021

manojgupta added a comment to D88458: [CMake] Cache the compiler-rt library search results.

I'll send the cache and other details by email.

Oct 25 2021, 12:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 21 2021

manojgupta added a comment to D88458: [CMake] Cache the compiler-rt library search results.

This is also causing build failures in our ToT builds.

Oct 21 2021, 10:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 19 2021

manojgupta added a reviewer for D112091: libfuzzer: All building libfuzzer for ARM32: kcc.
Oct 19 2021, 1:09 PM · Restricted Project
manojgupta requested review of D112091: libfuzzer: All building libfuzzer for ARM32.
Oct 19 2021, 12:58 PM · Restricted Project
manojgupta added a comment to D112059: Fix inline builtin handling in case of redefinition.

thanks, I can verify that it fixes the crash we were seeing.

Oct 19 2021, 10:34 AM · Restricted Project

Oct 16 2021

manojgupta added a comment to D111009: Update inline builtin handling to honor gnu inline attribute.

I am noticing a clang crash with ToT after this change.

Oct 16 2021, 12:26 PM · Restricted Project

Oct 15 2021

manojgupta added a comment to D109811: [compiler-rt][CET] Enable CET for compiler-rt builtin library.

Unfortunately, explicit CXXFLAGS is not enough. If we add CXXFLAGS, it will make all of llvm including clang to be built with CET which is not what we want.

Oct 15 2021, 8:28 AM · Restricted Project

Oct 6 2021

manojgupta added a comment to D109811: [compiler-rt][CET] Enable CET for compiler-rt builtin library.

I tried to use it locally and ran into following issues:

Oct 6 2021, 9:35 AM · Restricted Project

Sep 15 2021

manojgupta added a reviewer for D109811: [compiler-rt][CET] Enable CET for compiler-rt builtin library: efriedma.
Sep 15 2021, 8:47 AM · Restricted Project
manojgupta added a reviewer for D109811: [compiler-rt][CET] Enable CET for compiler-rt builtin library: compnerd.
Sep 15 2021, 8:36 AM · Restricted Project

Sep 1 2021

manojgupta updated subscribers of D109047: [Unwind] Harmonise exception class for EHABI spec..
Sep 1 2021, 4:15 PM · Restricted Project, Restricted Project
manojgupta accepted D109047: [Unwind] Harmonise exception class for EHABI spec..

Thanks Daniel. We still have a problem with pthread_cancel but this resolves the immediate crash.

Sep 1 2021, 10:23 AM · Restricted Project, Restricted Project

Aug 24 2021

manojgupta added a comment to D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..

We have been trying to debug 1 issue on ARM32 Chrome OS devices related to pthread_cancel.
After some debugging, I found that glibc uses char[8] for the exception class [1] but libunwind is using uin64_t.
This causes crashes because of ABI mismatch when pthread_cancel calls Unwind routines.

Aug 24 2021, 12:26 PM · Restricted Project, Restricted Project

Aug 13 2021

manojgupta committed rG1f7b25ea76a9: [lldb] skip host build for lldb_tblgen with LLDB_TABLEGEN_EXE set (authored by manojgupta).
[lldb] skip host build for lldb_tblgen with LLDB_TABLEGEN_EXE set
Aug 13 2021, 2:19 PM
manojgupta closed D108053: [lldb] skip host build for lldb_tblgen with LLDB_TABLEGEN_EXE set.
Aug 13 2021, 2:18 PM · Restricted Project
manojgupta added a comment to D108053: [lldb] skip host build for lldb_tblgen with LLDB_TABLEGEN_EXE set.

This is a local patch we have been carrying in Chrome OS.
What we do to cross compile lldb-server:

  1. Create host build to build tools like llvm-tblgen, clang-tblgen, lldb-tblgen
  2. Cross compile llvm and clang libraries using the just build *tblgen.
  3. Cross compile lldb by setting the path to pre-cross compiled libraries and *tblgen binaries from step 1.
Aug 13 2021, 1:38 PM · Restricted Project
manojgupta requested review of D108053: [lldb] skip host build for lldb_tblgen with LLDB_TABLEGEN_EXE set.
Aug 13 2021, 1:34 PM · Restricted Project

Aug 10 2021

manojgupta added a comment to D107560: [libc++][libc++abi][CET] Support building libc++ and libc++abi with CET enabled..

Wait. Can't the user just specify -fcf-protection=full in CMAKE_CXX_FLAGS?

Aug 10 2021, 7:48 PM · Restricted Project, Restricted Project
manojgupta added inline comments to D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux.
Aug 10 2021, 12:08 PM · Restricted Project, Restricted Project

Aug 9 2021

manojgupta added inline comments to D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux.
Aug 9 2021, 9:39 PM · Restricted Project, Restricted Project
manojgupta added inline comments to D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux.
Aug 9 2021, 9:06 PM · Restricted Project, Restricted Project
manojgupta added a comment to D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..

Please also see https://bugs.llvm.org/show_bug.cgi?id=51416

Aug 9 2021, 9:40 AM · Restricted Project

Jul 23 2021

manojgupta added a comment to D106703: [libunwind] adds a way to synthesise libgcc.

I'd rather not be in a situation where a program built with a normal production toolchain appears to work, but then randomly crashes because the unwinder clashes with libgcc. Unless Chrome OS actually refuses to load binaries built with a normal Linux toolchain, we should ensure those binaries work.

Jul 23 2021, 6:25 PM · Restricted Project, Restricted Project
manojgupta added a comment to D106703: [libunwind] adds a way to synthesise libgcc.

If there's crosstalk between libgcc.a and libunwind.so, binaries built on systems with true libgcc.a will break on systems with libunwind.so installed as libgcc_s.so. Messing with the names is just covering up the issue.

Jul 23 2021, 3:14 PM · Restricted Project, Restricted Project

Jul 20 2021

manojgupta updated subscribers of D105968: [libunwind][CET] Support exception handling stack unwind in CET environment.

@pcc @cferris Would you be able to review this libunwind patch?

Jul 20 2021, 9:21 AM · Restricted Project, Restricted Project

Jul 19 2021

manojgupta added inline comments to D105603: [X86][CET] Support to build LLVM toolchain with CET enabled..
Jul 19 2021, 10:13 AM · Restricted Project

May 20 2021

manojgupta added a comment to D52524: Add -Wpoison-system-directories warning.

An earlier version did check for library directories [1]. I am not exactly sure why was it removed, maybe it didn't work. So if anyone is willing to test that, please apply the diff and try.

May 20 2021, 9:05 PM · Restricted Project

Apr 12 2021

manojgupta added a comment to D98511: [llvm-objcopy][NFC] Move ownership keeping code into restoreStatOnFile().

Thanks for the quick turn around, I can verify that https://reviews.llvm.org/rGee8a5e4bc2c986b8e6c07e81fb58dc1e5a5c2d17 fixes the issue.

Apr 12 2021, 12:19 PM · Restricted Project
manojgupta updated subscribers of D98511: [llvm-objcopy][NFC] Move ownership keeping code into restoreStatOnFile().

@cjdb please pick the fix once available to chrome os.

Apr 12 2021, 9:30 AM · Restricted Project

Apr 11 2021

manojgupta added a comment to D98511: [llvm-objcopy][NFC] Move ownership keeping code into restoreStatOnFile().

@avl Did you test this change? It has broken setuid permission preservation with sudo.

Apr 11 2021, 6:02 PM · Restricted Project

Mar 11 2021

manojgupta accepted D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection.

@MaskRay I have verified that Chrome OS builds are not affected by this change.

Mar 11 2021, 10:05 AM · Restricted Project

Mar 5 2021

manojgupta updated subscribers of D97993: [Driver] Suppress GCC detection under -B.

Thanks for the clarification. I do not have any objections but I feel that am not the right person to approve this change.
@tstellar can you please review it?

Mar 5 2021, 12:38 PM · Restricted Project
manojgupta added a comment to D97993: [Driver] Suppress GCC detection under -B.

Another concern is people generally want clang to work out of box without any special arguments. As a user, after installing clang's distro package or building from source, I expect that basic compilation should work out-of-box which includes gcc detection.
i.e. "clang foo.cpp -o foo" should just work in most cases.

Mar 5 2021, 12:10 PM · Restricted Project

Mar 4 2021

manojgupta added a comment to D97993: [Driver] Suppress GCC detection under -B.

Thanks for explaining that it only affects "-B". While I believe that this change won't affect us in Chrome OS, I think it should be reviewed and approved by a few Linux distro contributors since there is already known reliance e.g. Android on the current behavior.

Mar 4 2021, 5:49 PM · Restricted Project
manojgupta added a comment to D97902: [docs] Improve documentation of -B and --gcc-toolchain.

thanks, this is much needed documentation.

Mar 4 2021, 5:39 PM · Restricted Project
manojgupta added a comment to D97993: [Driver] Suppress GCC detection under -B.

I am not sure of the rationale or upside of this change and why do we want to drop gcc detection? GCC does not need to do the GCC detection because it has the needed information at configure time.

Mar 4 2021, 5:33 PM · Restricted Project
manojgupta added a comment to D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection.

With the special rule, it is: if --gcc-toolchain is $sysroot/usr, suppress sysroot GCC detection as well.

Clang -B and --gcc-toolchain have some weird behaviors. Hope you can share your opinions on https://lists.llvm.org/pipermail/cfe-dev/2021-March/067827.html

Mar 4 2021, 3:25 PM · Restricted Project
manojgupta added a comment to D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection.

In Chrome OS, we currently both "-B" and "--prefix". "-B" points to binutils bin directory and the "--prefix" has the binutils directory + target suffix. Should we drop "-B" and still get the same behavior?

Mar 4 2021, 2:10 PM · Restricted Project

Mar 3 2021

manojgupta added a comment to D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection.

Thanks @MaskRay for this clean up. I can't speak for all of Gentoo but please give me a couple of days to at least test this on Chrome OS.

Mar 3 2021, 4:31 PM · Restricted Project