This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC][GFX7][GFX10] Corrected image_atomic_fcmpswap
ClosedPublic

Authored by dp on Sep 10 2021, 10:45 AM.

Details

Summary

image_atomic_fcmpswap shall be identical to image_atomic_cmpswap (except that the former also handles NaN/INF/denorm).

Fixes bug 51725.

Diff Detail

Event Timeline

dp created this revision.Sep 10 2021, 10:45 AM
dp requested review of this revision.Sep 10 2021, 10:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 10 2021, 10:45 AM
critson added inline comments.
llvm/test/MC/Disassembler/AMDGPU/gfx10_mimg.txt
255–266

How do these changes relate to this patch?

dp added inline comments.Sep 13 2021, 1:19 AM
llvm/test/MC/Disassembler/AMDGPU/gfx10_mimg.txt
255–266

I attempted to bring some organization to the tests so I moved these to non-NSA section.

dp added a reviewer: critson.Sep 13 2021, 1:22 AM
foad added a comment.Sep 13 2021, 1:53 AM

No objections from me.

critson added inline comments.Sep 13 2021, 3:37 AM
llvm/test/MC/Disassembler/AMDGPU/gfx10_mimg.txt
255–266

Thanks for the clarification. Reorganisation makes sense.

rampitec accepted this revision.Sep 20 2021, 11:40 AM
This revision is now accepted and ready to land.Sep 20 2021, 11:40 AM
This revision was automatically updated to reflect the committed changes.