Page MenuHomePhabricator

[NFCI] Rename functions LLVMDIBuilder* to llvmDIBuilder*
AbandonedPublic

Authored by alok on Sep 10 2021, 3:16 AM.

Details

Summary

This change is triggered by D109343. where clang-tidy was not satisfied with existing function name.

Names are changed as per clang formatting.

Diff Detail

Unit TestsFailed

TimeTest
1,790 msx64 debian > LLVM.Bindings/Go::go.test
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llvm-go go=/usr/bin/go test llvm.org/llvm/bindings/go/llvm

Event Timeline

alok created this revision.Sep 10 2021, 3:16 AM
alok requested review of this revision.Sep 10 2021, 3:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 10 2021, 3:16 AM

The rest of the C API uses an "LLVM" prefix. Does it really make sense to use a different one for the DIBuilder functions?

alok added a comment.Sep 10 2021, 3:42 AM

The rest of the C API uses an "LLVM" prefix. Does it really make sense to use a different one for the DIBuilder functions?

Thanks for your comment. Do you vote for changing all the functions or leaving all the functions as it is ?

nikic requested changes to this revision.Sep 10 2021, 6:09 AM
nikic added a subscriber: nikic.

The LLVM C API is a stable FFI API. It's not possible to change any function names.

This revision now requires changes to proceed.Sep 10 2021, 6:09 AM
alok added a comment.Sep 10 2021, 6:48 AM

The LLVM C API is a stable FFI API. It's not possible to change any function names.

Thanks. I got it. Those clang-tidy warning should be ignored or clang-tidy should be fixed to not warn in such cases.

xgupta added a subscriber: xgupta.Sep 23 2021, 10:40 AM

This patch can be closed if can't be LG.

alok abandoned this revision.Sep 23 2021, 11:55 PM