Page MenuHomePhabricator
Differential D109520

[JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC)
ClosedPublic
Actions

Authored by sgraenitz on Sep 9 2021, 9:22 AM.

Details

Reviewers
StephenFan
lhames
Commits
rG68914dc99083: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC)
Summary

Following D109516, this patch re-uses the new helper function for ELF relocation traversal in the x86-64 backend.

Diff Detail

Unit TestsFailed
View All

TimeTest
300 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-tls.S
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-tls.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-tls.S

Event Timeline

sgraenitz created this revision.Sep 9 2021, 9:22 AM
Herald added subscribers: pengfei, hiraditya. · View Herald TranscriptSep 9 2021, 9:22 AM
sgraenitz requested review of this revision.Sep 9 2021, 9:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2021, 9:22 AM
sgraenitz added a comment.Sep 9 2021, 9:24 AM

The patch aims to be NFC (except debug output format). Please ping me if I introduced a functional change by accident.

Harbormaster completed remote builds in B123242: Diff 371622.Sep 9 2021, 10:13 AM
sgraenitz updated this revision to Diff 372230.Sep 13 2021, 6:19 AM

Account for modifications in the underlying patch && address pre-merge checks

Harbormaster completed remote builds in B123651: Diff 372230.Sep 13 2021, 7:11 AM
sgraenitz added a comment.Sep 17 2021, 8:28 AM

Ping! I was hoping to land this together with D109522.

StephenFan accepted this revision.Sep 17 2021, 9:07 AM

LGTM. Thanks @sgraenitz!

This revision is now accepted and ready to land.Sep 17 2021, 9:07 AM
This revision was landed with ongoing or failed builds.Sep 20 2021, 6:47 AM
Closed by commit rG68914dc99083: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC) (authored by sgraenitz). · Explain Why
This revision was automatically updated to reflect the committed changes.
sgraenitz added a commit: rG68914dc99083: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC).
foad added a subscriber: foad.Sep 20 2021, 6:50 AM
foad added inline comments.
llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp
371

This causes a warning when I do a release build with clang 10.0.0:

ELF_x86_64.cpp:308:13: warning: enumeration value 'PCRel32TLV' not handled in switch [-Wswitch]
GMNGeoffrey added a subscriber: GMNGeoffrey.Sep 20 2021, 10:26 AM
GMNGeoffrey added inline comments.
llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp
371

I'm also seeing this and build with -Werror

GMNGeoffrey added a subscriber: bkramer.Sep 20 2021, 10:54 AM
GMNGeoffrey added inline comments.
llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp
371

Looks like a bad merge with https://reviews.llvm.org/D109293 (thanks @bkramer for pointing this out). I'll send a fix

GitHub <noreply@github.com> mentioned this in rG01b097afd0ea: Fix bad merge the removed switch case.Sep 20 2021, 10:59 AM

Revision Contents
Changeset List

PathSize
llvm/
lib/
ExecutionEngine/
JITLink/
246 lines

Diff 372230

View Options

llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp

Loading...