Following D109516, this patch re-uses the new helper function for ELF relocation traversal in the RISCV backend.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
The patch aims to be NFC (except debug output format). Please ping me if I introduced a functional change by accident.
llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp | ||
---|---|---|
303 | std::move of a lambda is a strange thing to do |
llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp | ||
---|---|---|
297 | x64 -> riscv |
Account for modifications in the underlying patch
llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp | ||
---|---|---|
297 | Good catch! Actually, I made a copy/paste mistake here (from x86-64). This check didn't exist for RISCV. It'd be a functional change and thus I am going to drop it (even in case it's accurate for RISCV). | |
303 | Agree. It's been a leftover from my previous std::function sketches. Latest version passes the member function pointer directly. |
x64 -> riscv