This is an archive of the discontinued LLVM Phabricator instance.

[CUDA][NFC] Fix a wrong assert message
ClosedPublic

Authored by benshi001 on Sep 3 2021, 6:22 AM.

Reviewers

Commits

rG12fee64daf57: [CUDA][NFC] Fix wrong assert information

	Time	Test
	0 ms	x64 windows > Clang.CodeGen/aarch64-sve-intrinsics::acle_sve_st1b.c
	0 ms	x64 windows > Clang.CodeGen/aarch64-sve-intrinsics::acle_sve_st1h.c
	0 ms	x64 windows > Clang.CodeGen/aarch64-sve-intrinsics::acle_sve_st1w.c

benshi001 requested review of this revision.Sep 3 2021, 6:22 AM

benshi001 created this revision.

LGTM, guess this can be commited right away.

This revision is now accepted and ready to land.Sep 3 2021, 7:11 AM

This revision was landed with ongoing or failed builds.Sep 3 2021, 7:36 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

clang/

lib/

Driver/

2 lines

Show First 20 Lines • Show All 2,629 Lines • ▼ Show 20 Lines	void appendTopLevelActions(ActionList &AL) override {
return;		return;

// If we have CUDA actions at this point, that's because we have a have		// If we have CUDA actions at this point, that's because we have a have
// partial compilation, so we should have an action for each GPU		// partial compilation, so we should have an action for each GPU
// architecture.		// architecture.
assert(CudaDeviceActions.size() == GpuArchList.size() &&		assert(CudaDeviceActions.size() == GpuArchList.size() &&
"Expecting one action per GPU architecture.");		"Expecting one action per GPU architecture.");
assert(ToolChains.size() == 1 &&		assert(ToolChains.size() == 1 &&
"Expecting to have a sing CUDA toolchain.");		"Expecting to have a single CUDA toolchain.");
for (unsigned I = 0, E = GpuArchList.size(); I != E; ++I)		for (unsigned I = 0, E = GpuArchList.size(); I != E; ++I)
AddTopLevel(CudaDeviceActions[I], GpuArchList[I]);		AddTopLevel(CudaDeviceActions[I], GpuArchList[I]);

CudaDeviceActions.clear();		CudaDeviceActions.clear();
}		}

/// Get canonicalized offload arch option. \returns empty StringRef if the		/// Get canonicalized offload arch option. \returns empty StringRef if the
/// option is invalid.		/// option is invalid.
▲ Show 20 Lines • Show All 2,933 Lines • Show Last 20 Lines