Page MenuHomePhabricator

fodinabor (Joachim Meyer)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2020, 5:35 AM (43 w, 5 d)

Recent Activity

Fri, Jun 18

fodinabor added reviewers for D102590: [YAMLParser] Add multi-line literal folding support: dexonsmith, grimar.
Fri, Jun 18, 4:38 AM · Restricted Project

Wed, Jun 16

fodinabor committed rG053dbb939d4a: Use `-cfg-func-name` value as filter for `-view-cfg`, etc. (authored by fodinabor).
Use `-cfg-func-name` value as filter for `-view-cfg`, etc.
Wed, Jun 16, 2:52 PM
fodinabor closed D102011: Use `-cfg-func-name` value as filter for `-view-cfg`, etc..
Wed, Jun 16, 2:51 PM · Restricted Project

Thu, Jun 10

fodinabor committed rG4f01122c3f6c: [LV] Parallel annotated loop does not imply all loads can be hoisted. (authored by fodinabor).
[LV] Parallel annotated loop does not imply all loads can be hoisted.
Thu, Jun 10, 2:35 PM
fodinabor closed D103907: [LV] Parallel annotated loop does not imply all loads can be hoisted..
Thu, Jun 10, 2:35 PM · Restricted Project

Wed, Jun 9

fodinabor added a comment to D102011: Use `-cfg-func-name` value as filter for `-view-cfg`, etc..

Ping.

Wed, Jun 9, 8:00 AM · Restricted Project
fodinabor updated the summary of D103907: [LV] Parallel annotated loop does not imply all loads can be hoisted..
Wed, Jun 9, 2:11 AM · Restricted Project
fodinabor updated the diff for D103907: [LV] Parallel annotated loop does not imply all loads can be hoisted..

Remove broken-by-design force-ifcvt.ll test.

Wed, Jun 9, 2:10 AM · Restricted Project

Tue, Jun 8

fodinabor requested review of D103907: [LV] Parallel annotated loop does not imply all loads can be hoisted..
Tue, Jun 8, 9:19 AM · Restricted Project

Wed, Jun 2

fodinabor added a comment to D102590: [YAMLParser] Add multi-line literal folding support.

Not too deep into the YAML world, so just my two cents re the isLineBreak function.

Wed, Jun 2, 8:37 AM · Restricted Project

Mon, May 24

fodinabor added a comment to D102011: Use `-cfg-func-name` value as filter for `-view-cfg`, etc..

Ping.

Mon, May 24, 3:18 AM · Restricted Project

Fri, May 21

fodinabor accepted D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0.

LGTM :)

Fri, May 21, 12:22 PM · Restricted Project
fodinabor added a comment to D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0.

Sadly don't have stdibc++11 available locally as well.. so can't verify, but looks good to me except for the push and pop macros.

Fri, May 21, 11:27 AM · Restricted Project

May 14 2021

fodinabor updated the diff for D102011: Use `-cfg-func-name` value as filter for `-view-cfg`, etc..

Incorporate review of the test and document the behavior in Passes.rst.

May 14 2021, 12:54 AM · Restricted Project

May 7 2021

fodinabor added a comment to D102011: Use `-cfg-func-name` value as filter for `-view-cfg`, etc..

Also, would it make sense to un-hide and document the flag now, given it actually is useful now?

May 7 2021, 10:28 AM · Restricted Project
fodinabor updated the diff for D102011: Use `-cfg-func-name` value as filter for `-view-cfg`, etc..

clang-format file

May 7 2021, 10:26 AM · Restricted Project
fodinabor updated the diff for D102011: Use `-cfg-func-name` value as filter for `-view-cfg`, etc..

Add test for the filtering with -dot-cfg and -dot-cfg-only. As far as I see it, the view variant is not really testable. Happy to be proved wrong, though. :)

May 7 2021, 10:25 AM · Restricted Project
fodinabor added a comment to D102021: [NFC] Correctly assert the indents for printEnumValHelpStr..

Landed and added to release blockers for 12.0.1

May 7 2021, 5:33 AM · Restricted Project
fodinabor committed rGd9f2960c932c: [NFC] Correctly assert the indents for printEnumValHelpStr. (authored by fodinabor).
[NFC] Correctly assert the indents for printEnumValHelpStr.
May 7 2021, 5:28 AM
fodinabor closed D102021: [NFC] Correctly assert the indents for printEnumValHelpStr..
May 7 2021, 5:28 AM · Restricted Project

May 6 2021

fodinabor requested review of D102021: [NFC] Correctly assert the indents for printEnumValHelpStr..
May 6 2021, 1:23 PM · Restricted Project
fodinabor added a comment to D93494: [Support] Indent multi-line descr of enum cli options..

mhh... I'd just say the assert was wrong.
The BaseIndent is the maximum width of an option. e.g. --compilation-database=<string>.
printEnumValHelpStr does not deal with that part at all, only with the help string that comes after that (e.g. This is the first enum value\nwhich has a really long description\nthus it is multi-line.).
For nice formatting in the first line - and are prepended for the enum values in the first line and later BaseIndent + are used for the indent.
What the assert should have verified is only that BaseIndent >= FirstLineIndentedBy so that we can later have the indent: BaseIndent - FirstLineIndentedBy and be sure it's >=0.
(and that really should always be true..)

May 6 2021, 1:21 PM · Restricted Project
fodinabor requested review of D102011: Use `-cfg-func-name` value as filter for `-view-cfg`, etc..
May 6 2021, 11:19 AM · Restricted Project

Feb 4 2021

fodinabor committed rGe3f02302e318: [Support] Indent multi-line descr of enum cli options. (authored by fodinabor).
[Support] Indent multi-line descr of enum cli options.
Feb 4 2021, 1:13 AM
fodinabor closed D93494: [Support] Indent multi-line descr of enum cli options..
Feb 4 2021, 1:13 AM · Restricted Project

Feb 3 2021

fodinabor added a comment to D93494: [Support] Indent multi-line descr of enum cli options..

Ping :)

Feb 3 2021, 2:20 PM · Restricted Project

Jan 27 2021

fodinabor added a comment to D93494: [Support] Indent multi-line descr of enum cli options..

Given the awful formatting in clang-format is merged in release/12.x, would be great to get this in, before 12.0.0 final.. :)

Jan 27 2021, 4:53 AM · Restricted Project

Jan 26 2021

fodinabor updated the diff for D93494: [Support] Indent multi-line descr of enum cli options..

Add print option info test for multiline value descriptions.

Jan 26 2021, 1:58 AM · Restricted Project

Jan 12 2021

fodinabor added a comment to D93494: [Support] Indent multi-line descr of enum cli options..

Happy new year's ping :)

Jan 12 2021, 12:55 AM · Restricted Project

Dec 22 2020

fodinabor updated subscribers of D93494: [Support] Indent multi-line descr of enum cli options..
Dec 22 2020, 12:23 PM · Restricted Project

Dec 18 2020

fodinabor updated the diff for D93494: [Support] Indent multi-line descr of enum cli options..

Fix naming to make clang-tidy happy.

Dec 18 2020, 4:23 AM · Restricted Project

Dec 17 2020

fodinabor requested review of D93494: [Support] Indent multi-line descr of enum cli options..
Dec 17 2020, 2:58 PM · Restricted Project
fodinabor committed rGc755e41c336c: Fix -Wno-error= parsing in clang-format. (authored by fodinabor).
Fix -Wno-error= parsing in clang-format.
Dec 17 2020, 1:22 PM
fodinabor closed D93459: Fix -Wno-error= parsing in clang-format..
Dec 17 2020, 1:22 PM · Restricted Project, Restricted Project
fodinabor updated the diff for D93459: Fix -Wno-error= parsing in clang-format..

Update ClangFormat.rst.
This is manually well formatted.. will try to make a new patch in the coming days to actually fix it in the support library.

Dec 17 2020, 1:00 PM · Restricted Project, Restricted Project
fodinabor updated the diff for D93459: Fix -Wno-error= parsing in clang-format..

Add lit test to ensure behaviour of the -Wno-error=unkown flag.

Dec 17 2020, 8:35 AM · Restricted Project, Restricted Project
fodinabor added a comment to D93459: Fix -Wno-error= parsing in clang-format..

Quoting my questions from the other review, as it should be more appropriate to discuss this here:

Dec 17 2020, 7:10 AM · Restricted Project, Restricted Project
fodinabor edited projects for D93459: Fix -Wno-error= parsing in clang-format., added: Restricted Project; removed Restricted Project.
Dec 17 2020, 7:08 AM · Restricted Project, Restricted Project
fodinabor requested review of D93459: Fix -Wno-error= parsing in clang-format..
Dec 17 2020, 7:07 AM · Restricted Project, Restricted Project
fodinabor added a comment to D86137: Add -Wno-error=unknown flag to clang-format..

I can reproduce the issue, but not sure what introduced this.

Dec 17 2020, 6:32 AM · Restricted Project, Restricted Project, Restricted Project

Oct 29 2020

fodinabor committed rGeaee608448c8: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers. (authored by fodinabor).
[OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.
Oct 29 2020, 3:25 PM
fodinabor closed D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers..
Oct 29 2020, 3:25 PM · Restricted Project
fodinabor added a comment to D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers..

Thanks, will land it later.

Oct 29 2020, 2:04 PM · Restricted Project
fodinabor updated the diff for D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers..

Add missing macro definitions.

Oct 29 2020, 1:23 PM · Restricted Project
fodinabor updated the summary of D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers..
Oct 29 2020, 12:19 PM · Restricted Project
fodinabor requested review of D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers..
Oct 29 2020, 12:17 PM · Restricted Project

Sep 21 2020

MarcusJohnson91 awarded D86137: Add -Wno-error=unknown flag to clang-format. a Love token.
Sep 21 2020, 1:54 PM · Restricted Project, Restricted Project, Restricted Project

Sep 19 2020

fodinabor committed rGf64903fd8176: Add -Wno-error=unknown flag to clang-format. (authored by fodinabor).
Add -Wno-error=unknown flag to clang-format.
Sep 19 2020, 1:18 AM
fodinabor closed D86137: Add -Wno-error=unknown flag to clang-format..
Sep 19 2020, 1:18 AM · Restricted Project, Restricted Project, Restricted Project
fodinabor committed rGecf98246bd92: [NFC] Test commit (authored by fodinabor).
[NFC] Test commit
Sep 19 2020, 1:15 AM

Sep 18 2020

fodinabor added a comment to D86137: Add -Wno-error=unknown flag to clang-format..

Okay, I requested commit access.
So the patch is fine with you from a clang-format perspective?

Sep 18 2020, 7:46 AM · Restricted Project, Restricted Project, Restricted Project
fodinabor retitled D86137: Add -Wno-error=unknown flag to clang-format. from Add ignore-unknown-options flag to clang-format. to Add -Wno-error=unknown flag to clang-format..
Sep 18 2020, 7:11 AM · Restricted Project, Restricted Project, Restricted Project
fodinabor updated the diff for D86137: Add -Wno-error=unknown flag to clang-format..

Fix the nit :)
Anyone with access may commit this now (ideally ofc someone with a final opinion on the clang-format part).

Sep 18 2020, 7:09 AM · Restricted Project, Restricted Project, Restricted Project

Sep 15 2020

fodinabor added a comment to D86137: Add -Wno-error=unknown flag to clang-format..

All comments should be adressed now.

Sep 15 2020, 1:22 AM · Restricted Project, Restricted Project, Restricted Project
fodinabor updated the diff for D86137: Add -Wno-error=unknown flag to clang-format..

Unit test cleanups.

Sep 15 2020, 1:21 AM · Restricted Project, Restricted Project, Restricted Project

Sep 12 2020

fodinabor updated the diff for D86137: Add -Wno-error=unknown flag to clang-format..

Address review comments, copy the help text into docs and add some basic unit tests.

Sep 12 2020, 10:57 AM · Restricted Project, Restricted Project, Restricted Project

Sep 8 2020

fodinabor updated the diff for D86137: Add -Wno-error=unknown flag to clang-format..

Remove test entry form .clang-format :)

Sep 8 2020, 5:25 AM · Restricted Project, Restricted Project, Restricted Project
fodinabor updated the diff for D86137: Add -Wno-error=unknown flag to clang-format..

Incorporating review comments:

  • renaming option to -Wno-error=unknown and adding warning in description
  • emit warnings instead of fully ignoring the issues
Sep 8 2020, 5:24 AM · Restricted Project, Restricted Project, Restricted Project

Sep 7 2020

fodinabor updated subscribers of D86137: Add -Wno-error=unknown flag to clang-format..

Thank you so far for the feedback!
maybe you can give further guidance on the comments on the comments :)

Sep 7 2020, 6:23 AM · Restricted Project, Restricted Project, Restricted Project

Sep 5 2020

fodinabor added a comment to D86137: Add -Wno-error=unknown flag to clang-format..

I see the possible issue with the possible version mismatches and that is why I'd make people opt-in for this option, to still being able to format their files (e.g. if using out-dated built-in versions like in Visual Studio - I know you can specify your own binary) but the real formatting can be done with a pre-commit script or similar, where the new options are actually supported.

Sep 5 2020, 7:56 AM · Restricted Project, Restricted Project, Restricted Project
fodinabor added a comment to D86137: Add -Wno-error=unknown flag to clang-format..

Ping

Sep 5 2020, 7:22 AM · Restricted Project, Restricted Project, Restricted Project

Aug 18 2020

fodinabor requested review of D86137: Add -Wno-error=unknown flag to clang-format..
Aug 18 2020, 5:57 AM · Restricted Project, Restricted Project, Restricted Project