[flang] COMMAND_ARGUMENT_COUNT runtime implementation

[rovka]

Summary

Grab whatever ProgramStart has stored in
executionEnvironment.argc and subtract 1 (based on the
assumption that ProgramStart is called with a C-style argc
that counts the command name as an argument).

Spoiler alert: The tests will evolve into fixtures when we
implement GET_COMMAND_ARGUMENT etc.

[klausler]

flang/runtime/command.cpp

1

I don't think that you need the "*- C++ *" stuff in *.cpp files, just in headers (*.h).

14

Braced initialization, please; it's often safer.

[rovka]

flang/runtime/command.cpp

1

Right, copy-paste artifact :) It seems we have it in 23 out of 45 .cpp files in the runtime, I'll remove it from all of them.

14

Sorry, muscle memory... /hides under a rock.

[kiranchandramohan]

@rovka will you be implementing iargc which is mostly the same? What about get_command_argument, get_arg etc?
https://gcc.gnu.org/onlinedocs/gcc-4.2.4/gfortran/IARGC.html
https://gcc.gnu.org/onlinedocs/gfortran/GETARG.html

flang/runtime/CMakeLists.txt

 # with different names
 include_directories(AFTER ${CMAKE_CURRENT_BINARY_DIR})
 
 add_flang_library(FortranRuntime
   ISO_Fortran_binding.cpp
   allocatable.cpp
   assign.cpp
   buffer.cpp
+  command.cpp
   complex-reduction.c
   copy.cpp
   character.cpp
   connection.cpp
   derived.cpp
   derived-api.cpp
   descriptor.cpp
   descriptor-io.cpp

flang/runtime/command.cpp

+//===-- runtime/command.cpp -------------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "command.h"
+#include "environment.h"
+
+namespace Fortran::runtime {
+CppTypeFor<TypeCategory::Integer, 4> RTNAME(ArgumentCount)() {
+  int argc = executionEnvironment.argc;
+  if (argc > 1) {
+    // C counts the command name as one of the arguments, but Fortran doesn't.
+    return argc - 1;
+  }
+  return 0;
+}
+} // namespace Fortran::runtime

flang/unittests/Runtime/CMakeLists.txt

 add_flang_unittest(FlangRuntimeTests
   BufferTest.cpp
   CharacterTest.cpp
+  CommandTest.cpp
   CrashHandlerFixture.cpp
   ExternalIOTest.cpp
   Format.cpp
   ListInputTest.cpp
   Matmul.cpp
   MiscIntrinsic.cpp
   Namelist.cpp
   Numeric.cpp

flang/unittests/Runtime/CommandTest.cpp

+//===-- flang/unittests/RuntimeGTest/CommandTest.cpp ----------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "../../runtime/command.h"
+#include "gtest/gtest.h"
+#include "../../runtime/descriptor.h"
+#include "../../runtime/main.h"
+
+using namespace Fortran::runtime;
+
+TEST(ArgumentCount, ZeroArguments) {
+  const char *argv[] = {"aProgram"};
+  RTNAME(ProgramStart)(1, argv, {});
+  EXPECT_EQ(0, RTNAME(ArgumentCount)());
+}
+
+TEST(ArgumentCount, OneArgument) {
+  const char *argv[] = {"aProgram", "anArgument"};
+  RTNAME(ProgramStart)(2, argv, {});
+  EXPECT_EQ(1, RTNAME(ArgumentCount)());
+}
+
+TEST(ArgumentCount, SeveralArguments) {
+  const char *argv[] = {"aProgram", "arg1", "arg2", "arg3", "arg4"};
+  RTNAME(ProgramStart)(5, argv, {});
+  EXPECT_EQ(4, RTNAME(ArgumentCount)());
+}