Clang used to support [[nodebug]] everywhere except on typedefs. Since
we don't support such old Clangs anymore, we can get rid of _LIBCPP_NODEBUG_TYPE
in favour of always using _LIBCPP_NODEBUG.
Details
- Reviewers
• Quuxplusone - Group Reviewers
Restricted Project - Commits
- rG3557c7c1226f: [libc++] Remove workarounds for [[nodebug]] not working properly on typedefs in…
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
LGTM! The commit message should mention that (it looks like) old Clang didn't support the attribute on typedefs but did support it elsewhere. You're basically merging _LIBCPP_NODEBUG_TYPE into _LIBCPP_NODEBUG; i.e., we still have to support compilers that don't respect it, but those that do respect it, respect it on typedefs as well as on [other things].
libcxx/include/__functional/hash.h | ||
---|---|---|
853–856 | Nit: two spaces before =, for no apparent reason | |
libcxx/include/__functional/weak_result_type.h | ||
113–125 | Nit: two spaces before _Rp, for no apparent reason | |
libcxx/include/__memory/unique_ptr.h | ||
153–163 | Nit: two spaces before = for no apparent reason | |
363 | (et seq) Nit: two spaces... you know the drill. | |
libcxx/include/__tuple | ||
331 | two spaces | |
462 | two spaces | |
libcxx/include/__utility/integer_sequence.h | ||
46 | two spaces (and line 57 also) |
Nit: two spaces before =, for no apparent reason