Page MenuHomePhabricator

[MLIR] Correct linkage of lowered globalop
ClosedPublic

Authored by wsmoses on Aug 17 2021, 3:25 PM.

Details

Summary

LLVM considers global variables marked as externals to be defined within the module if it is initialized (including to an undef). Other external globals are considered as being defined externally and imported into the current translation unit. Lowering of MLIR Global Ops does not properly propagate undefined initializers, resulting in a global which is expected to be defined within the current TU, not being defined.

Diff Detail

Event Timeline

wsmoses created this revision.Aug 17 2021, 3:25 PM
wsmoses requested review of this revision.Aug 17 2021, 3:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2021, 3:25 PM
mehdi_amini accepted this revision.Aug 18 2021, 12:56 AM
This revision is now accepted and ready to land.Aug 18 2021, 12:56 AM
This revision was automatically updated to reflect the committed changes.