This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Fix atomic float max/min intrinsics
ClosedPublic

Authored by Joe_Nash on Aug 17 2021, 8:12 AM.

Details

Summary

Hooked up raw.buffer.atomic.fmin/max.f64
This instruction should be available on GFX6, GFX7, and GFX10.
It was implemented for GFX90a with a different name.

Added intrinsic def for image_atomic_fmin/fmax; the instruction
defs were already there.

Diff Detail

Event Timeline

Joe_Nash created this revision.Aug 17 2021, 8:12 AM
Joe_Nash requested review of this revision.Aug 17 2021, 8:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2021, 8:12 AM

Should also test globalisel

Joe_Nash updated this revision to Diff 366962.Aug 17 2021, 11:13 AM

add globalisel tests. Apparently gisel does some checking of addrspaces
that sdag does not, so I changed the addrspace

add globalisel tests. Apparently gisel does some checking of addrspaces
that sdag does not, so I changed the addrspace

Not sure what you mean here. Are you just hitting broken addrspace(1) stores on SI?

add globalisel tests. Apparently gisel does some checking of addrspaces
that sdag does not, so I changed the addrspace

Not sure what you mean here. Are you just hitting broken addrspace(1) stores on SI?

Yes.

arsenm accepted this revision.Aug 17 2021, 3:28 PM
This revision is now accepted and ready to land.Aug 17 2021, 3:28 PM
This revision was automatically updated to reflect the committed changes.